From: Dave Abrahams <dave@boostpro.com>
To: Lars Magne Ingebrigtsen <larsi@gnus.org>
Cc: 8891@debbugs.gnu.org
Subject: bug#8891: 23.3; save-buffer messages about writing files that may not be written
Date: Sun, 03 Jul 2011 16:26:28 -0400 [thread overview]
Message-ID: <m2iprjaz63.fsf@pluto.luannocracy.com> (raw)
In-Reply-To: <m3oc1bl4rt.fsf@quimbies.gnus.org> (Lars Magne Ingebrigtsen's message of "Sun, 03 Jul 2011 18:15:18 +0200")
on Sun Jul 03 2011, Lars Magne Ingebrigtsen <larsi-AT-gnus.org> wrote:
> Dave Abrahams <dave@boostpro.com> writes:
>
>> I have hooked write-file-functions for certain files to check the md5
>> sum of the file against what it was when last saved and simply mark the
>> file unmodified
>> (https://github.com/dabrahams/initsplit/blob/master/initsplit.el#L300)
>>
>> However, I get a message about saving these files even when there's been
>> no modification. I think these lines in save-buffer come too early:
>>
>> (if (and modp (buffer-file-name))
>> (message "Saving file %s..." (buffer-file-name)))
>
> Hm. If `modp' is true, then the buffer has been modified, hasn't it?
Yes... until `save-buffer' calls `basic-save-buffer' which invokes
`write-file-functions', one of which decides to override the notion of
"modified-ness" when it ascertains that the contents have not actually
changed. So modp tells the truth at the time it's checked, but IMO it's
checked too early.
--
Dave Abrahams
BoostPro Computing
http://www.boostpro.com
next prev parent reply other threads:[~2011-07-03 20:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-18 16:50 bug#8891: 23.3; save-buffer messages about writing files that may not be written Dave Abrahams
2011-07-03 16:15 ` Lars Magne Ingebrigtsen
2011-07-03 20:26 ` Dave Abrahams [this message]
2011-07-03 20:31 ` Lars Magne Ingebrigtsen
2011-07-03 20:51 ` Dave Abrahams
2011-07-04 2:35 ` Chong Yidong
2011-07-04 12:19 ` Lars Magne Ingebrigtsen
2011-07-04 17:41 ` Chong Yidong
2011-07-04 20:36 ` Dave Abrahams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2iprjaz63.fsf@pluto.luannocracy.com \
--to=dave@boostpro.com \
--cc=8891@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).