unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: Alex Murray <alex.murray@canonical.com>
Cc: 38371@debbugs.gnu.org
Subject: bug#38371: 27.0.50; network-stream-certificate fails to specify :port as a string for auth-source-search
Date: Tue, 26 Nov 2019 09:30:33 +0100	[thread overview]
Message-ID: <m2imn759au.fsf@gmail.com> (raw)
In-Reply-To: <87sgmcgoph.fsf@canonical.com> (Alex Murray's message of "Mon, 25 Nov 2019 22:20:02 +1030")

tags 38371 fixed
close 38371 27.1
quit

>>>>> On Mon, 25 Nov 2019 22:20:02 +1030, Alex Murray <alex.murray@canonical.com> said:

    Alex> Sending mail via SMTP in Emacs 27.0.50 fails when using the secrets
    Alex> auth-source backend - this seems to be due to network-stream-certificate
    Alex> calling auth-source-search with :port specified as an integer - since
    Alex> then later auth-source-secrets-listify-pattern fails with the following
    Alex> backtrace as it seems to expect all parameters to be strings.

    Alex> Attached is a patch to resolve this, in the same way bug#20541 was
    Alex> solved previously.

Thanks for the patch, pushed (with a slight modification, plus I added
the Bug# to the commit message).

    Alex> I wonder however if it might just be better to make
    Alex> auth-source-secrets-listify-pattern smarter to handle numeric elements

Maybe. But this is enough for now (and the recent flipping of the
default of network-stream-use-client-certificates would hide it
anyway).

Robert





  reply	other threads:[~2019-11-26  8:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-25 11:50 bug#38371: 27.0.50; network-stream-certificate fails to specify :port as a string for auth-source-search Alex Murray
2019-11-26  8:30 ` Robert Pluim [this message]
2019-11-26 10:43   ` Michael Albinus
2019-11-26 10:54     ` Robert Pluim
2019-11-26 11:04   ` Alex Murray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2imn759au.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=38371@debbugs.gnu.org \
    --cc=alex.murray@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).