From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alex Bochannek Newsgroups: gmane.emacs.bugs Subject: bug#48801: 28.0.50; [PATCH] Feature suggestion gnus-retrieve-headers check for nov-is-evil when agent is enabled Date: Fri, 04 Jun 2021 10:40:53 -0700 Message-ID: References: <87im2v9y4u.fsf@gnus.org> <874kee0y6l.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30583"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (darwin) Cc: 48801@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 04 19:41:19 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lpDot-0007nO-Us for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Jun 2021 19:41:19 +0200 Original-Received: from localhost ([::1]:60300 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lpDos-0004UP-UW for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Jun 2021 13:41:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58174) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lpDoc-0004Qc-6T for bug-gnu-emacs@gnu.org; Fri, 04 Jun 2021 13:41:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36314) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lpDob-0005OP-U1 for bug-gnu-emacs@gnu.org; Fri, 04 Jun 2021 13:41:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lpDob-0004yj-RJ for bug-gnu-emacs@gnu.org; Fri, 04 Jun 2021 13:41:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Alex Bochannek Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Jun 2021 17:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48801 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 48801-submit@debbugs.gnu.org id=B48801.162282845919120 (code B ref 48801); Fri, 04 Jun 2021 17:41:01 +0000 Original-Received: (at 48801) by debbugs.gnu.org; 4 Jun 2021 17:40:59 +0000 Original-Received: from localhost ([127.0.0.1]:47860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lpDoZ-0004yK-GE for submit@debbugs.gnu.org; Fri, 04 Jun 2021 13:40:59 -0400 Original-Received: from ns.lapseofthought.com ([50.0.39.240]:25432 helo=mail.lapseofthought.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lpDoW-0004yA-JO for 48801@debbugs.gnu.org; Fri, 04 Jun 2021 13:40:58 -0400 Original-Received: from awb-mbp.local (unknown [IPv6:2601:646:4200:b470:6d0d:ee85:8d40:371e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lapseofthought.com (Postfix) with ESMTPSA id 4FxVRT5sN0z3pdjV; Fri, 4 Jun 2021 10:40:53 -0700 (PDT) Authentication-Results: ORIGINATING; auth=pass smtp.auth=alex smtp.mailfrom=alex@bochannek.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:208033 Archived-At: Lars Ingebrigtsen writes: > Alex Bochannek writes: > >> Is there any documentation you would like to see before accepting this >> change? > > I don't think the patch is the right thing to do: I did mention in my initial email that this wasn't fully cooked and I am happy to accept alternatives :) > So you're basically disabling the Agent when gnus-nov-is-evil is set, > and while it solves this problem, it's not a good general solution -- > the two things are kinda-sort orthogonal. Instead you should just > exclude the nnvirtual component groups from the Agent. What I am trying to achieve is: - Allow limiting and scoring by newsgroup name in an nnvirtual group - Still use caching and agent mode for the nnvirtual and constituent groups For the second part I simply set `gnus-agent-cache' to non-nil and add the constituent groups to the agent. I didn't see a need to add the virtual group to the agent, because as long as all constituent groups are, I still get caching and agent mode. If I use a hook on the nnvirtual group to set nov-is-evil, the constituent groups end up with the extra headers in their .overview file. That seems to address both points above, except that if I open the constituent groups directly, I don't get that information. I tried to set nov-is-evil as a group parameter for the constituent groups, but that doesn't work when they are in an agent category and was the reason for the below code. > + (not (symbol-value > + (intern > + (format "%s-nov-is-evil" (car gnus-command-method)))))) > > (And this isn't correct anyway -- not all backends have a -nov-is-evil > variable). I noticed that and ended up defining a nnvirtual-nov-is-evil, but it never made it to this clause because of my specific setup. P.S.: Is there a better place to discuss this? gmane.emacs.gnus.general? -- Alex.