From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Newsgroups: gmane.emacs.bugs Subject: bug#74966: 31.0.50; Crash report (using igc on macOS) Date: Sat, 21 Dec 2024 15:57:22 +0100 Message-ID: References: <86a5cqkc2g.fsf@gnu.org> <86o716ah09.fsf@gnu.org> <87r062jpi1.fsf@protonmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26510"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: spd@toadstyle.org, Pip Cet , acorallo@gnu.org, Eli Zaretskii , 74966@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 21 15:59:15 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tP0wk-0006le-EA for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 21 Dec 2024 15:59:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tP0wZ-00015x-VS; Sat, 21 Dec 2024 09:59:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tP0wY-00015S-93 for bug-gnu-emacs@gnu.org; Sat, 21 Dec 2024 09:59:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tP0wY-0008OA-0e for bug-gnu-emacs@gnu.org; Sat, 21 Dec 2024 09:59:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=0O4uxqlVTKD3iuclV2fvDhPW1gQirNTKuau1s0VE//s=; b=rBQrvemcfiHEu5H6b79y4DGUSwMqx3XFy9+JuRMJ7S4yhJYEqi7OuwIDK9o+DCNFZ+uhwkAUIcrH99AvS++SJkk6AjhDqi62kWOYhhLZLbUoUQ9O2Oh7KW7nEVM/dG7+rV7RbA56bwKhTAlzt3NRFfF+ygSepY1vPMqzpfi0DtdCC7xeJ7gPXgfiaW544lw94tq7yKgMsnlrjtr1Ggx2PknfuUDtex1E4MTOOgwVecf7yNrBpEzwWga81ps2hnKlOsXPOTTXGeeNvpXKoLwhc+ht5wzCRlwTm94UfLKVlEGZVdS/8H4u6eav5NQBGuzPRC6lo6UniBSZFmBj9lLF8Q==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tP0wX-0007jQ-Ot for bug-gnu-emacs@gnu.org; Sat, 21 Dec 2024 09:59:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Dec 2024 14:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74966 X-GNU-PR-Package: emacs Original-Received: via spool by 74966-submit@debbugs.gnu.org id=B74966.173479310729674 (code B ref 74966); Sat, 21 Dec 2024 14:59:01 +0000 Original-Received: (at 74966) by debbugs.gnu.org; 21 Dec 2024 14:58:27 +0000 Original-Received: from localhost ([127.0.0.1]:47258 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tP0vy-0007iY-WE for submit@debbugs.gnu.org; Sat, 21 Dec 2024 09:58:27 -0500 Original-Received: from mail-ed1-f45.google.com ([209.85.208.45]:46375) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tP0vw-0007iQ-RT for 74966@debbugs.gnu.org; Sat, 21 Dec 2024 09:58:25 -0500 Original-Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-5d0ac27b412so3646035a12.1 for <74966@debbugs.gnu.org>; Sat, 21 Dec 2024 06:58:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734793044; x=1735397844; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=0O4uxqlVTKD3iuclV2fvDhPW1gQirNTKuau1s0VE//s=; b=YjwF9VSrez/XpVfPRGqBUrvUNCBJJ4jJx1ReEWE7D5KiWsnObfucLgy9G9WJrLLbPs ZBZZTS+Uekjj8/UZ9wtd1+7uoMwC+qSd5bZc6LLVQ0p/3WlWmzzeWSzq7eRAvJDFVH8J BCQMfQ94wd1DqmijGd9y0WBu84fFGwndxHtPMG9zmv/nra8b5MM5SWOA0zeoZ/SR2ogB QbddDwi34aR4odD1s694cexFLuCArUT1eAODthyfORUchXIPQUCPHNA/nliTqY+NLsC1 1oQlAr64iVvWOCAwnmpBM658t1Q+LM6+xOhB2oWNx0aIXtYrSWhhRudWi4TnkBbZ5k6M Gg7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734793044; x=1735397844; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0O4uxqlVTKD3iuclV2fvDhPW1gQirNTKuau1s0VE//s=; b=IlDFeQ3CBOocqam/7eWOsVU9PPEHt9lwGcPHMxfKvaD+yBpSzTLxQKR+/9ljMzWNqz sSdbo2R2GZwkNRZr91nhsPVrsA7UhlJ0vcUpmJ0aSVxYz/KpYtLCNmRQlGH+e8Q6qwcQ 6T/rzFnow0aPcfa43X3hGV7WlyH7sWWmZNHameSs9rLhHhHGwGZ9N28mdQljBp8/SxL7 PfSPZKb4e378IHSCxMV8RgSLBU/B9aXQWhaGZ7w+XnQHF3Jqd2mT/wtZDOo0ivYjYsoN DDpxbw0yIcffFPeHoiqAvFZ9+dGwnyTl+FuWR8ggwpSq8RWn8vQr/ZMqcNWxQKOrxm7I QAkA== X-Forwarded-Encrypted: i=1; AJvYcCVKq2ccsfoMN/8ZnvRDkGar2KxWf0sXICUxo0XRvfi7/dcKVsRjSuZGKAt12OLmauaUHk2uUA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyMSYIeKS9u1gix+g4IS8Db780ZZGEJkR77eoU8EDz+aNlLSW1T lPkwZhw0EdzsyoiHzqkywaIEDWFXRrzYL4S1szMdFi+uMAalIrxZ/Kwp3TEV X-Gm-Gg: ASbGncvPo7A3BDlMxKIsa16p+wfoWV2iETiFkAe0hBXuCLK/tB5KzjUlmHqWUXFx5vz YArUMcME5BkS60tEtHs/f9iHBuSLLhYwORE17zNpXYkf8RMN3UmvsRQk5sxcv3wHXaiMX/wrNEA 4+v/DiwVbGAVlzCSvuA0dGhDWxN11YYWbRsAjvNPRc7yJ3bsceeTr4uAO8ezGtm30EjN4a+H90D jJRCBpExyyl2DltfqFjLUxlnn7r9hygI1pB5kOIz77lmRy5I9t4B6LnB23AVHE5U3ZFSdwSZ2i4 3aQnXC7fPesyjXNcdRHdugr7WSNHV50MkaxIG9VbbbUcgWA+gd9CSgKv8DN7q4qQ1w== X-Google-Smtp-Source: AGHT+IEv+R2XvXb37s3ELZbQKJf6J7RTLZBNv90BBe9dSmLuraB2sHthWBKPqxgSODhaVeWyU4KOEg== X-Received: by 2002:a17:907:8004:b0:aae:b9e5:ed07 with SMTP id a640c23a62f3a-aaeb9e5f697mr71900166b.58.1734793043514; Sat, 21 Dec 2024 06:57:23 -0800 (PST) Original-Received: from pro2 (p200300e0b7162300456cde412cc45ae9.dip0.t-ipconnect.de. [2003:e0:b716:2300:456c:de41:2cc4:5ae9]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aac0efe4bd4sm293577066b.120.2024.12.21.06.57.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Dec 2024 06:57:23 -0800 (PST) In-Reply-To: (Stefan Monnier's message of "Sat, 21 Dec 2024 09:26:24 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297528 Archived-At: Stefan Monnier writes: >>> `offset` here should be fixnum that gives the position of this docstring >>> in the DOC file. And FUN should be a function for which we found >> >> Yes, but the nativecomp code assumes ->doc is an index into a >> nativecomp'd subr's constant vector. > > Aha! > >> So we overwrite it with a docfile >> index, access an out-of-bounds index and crash. >> >> I think the best thing to do is to use separate fields for the "offset" >> doc and the "index" doc; or at least, the second best thing, after >> removing the entire docfile hack. > > I think a much simpler change is to use the sign bit to distinguish indices > into the constant vector from indices into the DOC file. > > > Stefan Simpler maybe, but not cleaner than what Pip has in his lastest patch, which separates DOC offset and index into constant vector. And it's a pretty simple change.