From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.bugs Subject: bug#8344: (substring ...) crashes on large vectors Date: Sun, 27 Mar 2011 09:52:58 +0200 Message-ID: References: <4D8CDC3A.4010705@cs.ucla.edu> <4D8D0DB6.4040206@cs.ucla.edu> <4D8E9E93.80303@cs.ucla.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1301213251 11267 80.91.229.12 (27 Mar 2011 08:07:31 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 27 Mar 2011 08:07:31 +0000 (UTC) Cc: 8344@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 27 10:07:27 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Q3l0P-0001zb-HB for geb-bug-gnu-emacs@m.gmane.org; Sun, 27 Mar 2011 10:07:25 +0200 Original-Received: from localhost ([127.0.0.1]:34706 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q3l0N-0003ZZ-SM for geb-bug-gnu-emacs@m.gmane.org; Sun, 27 Mar 2011 04:07:23 -0400 Original-Received: from [140.186.70.92] (port=38229 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q3l0H-0003YX-64 for bug-gnu-emacs@gnu.org; Sun, 27 Mar 2011 04:07:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q3l0F-0008Lj-KP for bug-gnu-emacs@gnu.org; Sun, 27 Mar 2011 04:07:16 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49601) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q3l0F-0008Lc-IO for bug-gnu-emacs@gnu.org; Sun, 27 Mar 2011 04:07:15 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Q3knS-0003E6-B8; Sun, 27 Mar 2011 03:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andreas Schwab Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Mar 2011 07:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8344 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 8344-submit@debbugs.gnu.org id=B8344.130121238912344 (code B ref 8344); Sun, 27 Mar 2011 07:54:02 +0000 Original-Received: (at 8344) by debbugs.gnu.org; 27 Mar 2011 07:53:09 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q3kma-0003D3-St for submit@debbugs.gnu.org; Sun, 27 Mar 2011 03:53:09 -0400 Original-Received: from mail-out.m-online.net ([212.18.0.9]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q3kmX-0003CZ-QE for 8344@debbugs.gnu.org; Sun, 27 Mar 2011 03:53:06 -0400 Original-Received: from frontend1.mail.m-online.net (unknown [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id D79221C08E0A; Sun, 27 Mar 2011 09:52:59 +0200 (CEST) Original-Received: from localhost (dynscan1.mnet-online.de [192.168.8.164]) by mail.m-online.net (Postfix) with ESMTP id 9F0951C000B1; Sun, 27 Mar 2011 09:52:59 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Original-Received: from mail.mnet-online.de ([192.168.8.180]) by localhost (dynscan1.mail.m-online.net [192.168.8.164]) (amavisd-new, port 10024) with ESMTP id GtJ3bSdzncIx; Sun, 27 Mar 2011 09:52:59 +0200 (CEST) Original-Received: from igel.home (ppp-88-217-102-255.dynamic.mnet-online.de [88.217.102.255]) by mail.mnet-online.de (Postfix) with ESMTP; Sun, 27 Mar 2011 09:52:58 +0200 (CEST) Original-Received: by igel.home (Postfix, from userid 501) id 93B80CA2A0; Sun, 27 Mar 2011 09:52:58 +0200 (CEST) X-Yow: We place two copies of PEOPLE magazine in a DARK, HUMID mobile home. 45 minutes later CYNDI LAUPER emerges wearing a BIRD CAGE on her head! In-Reply-To: <4D8E9E93.80303@cs.ucla.edu> (Paul Eggert's message of "Sat, 26 Mar 2011 19:18:59 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sun, 27 Mar 2011 03:54:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:45393 Archived-At: Paul Eggert writes: > @@ -373,10 +373,10 @@ > path = Fsubstring (path, make_number (2), Qnil); > > new_argv_volatile = new_argv = (const unsigned char **) > - alloca (max (2, nargs - 2) * sizeof (char *)); > + alloca ((nargs > 4 ? nargs - 2 : 2) * sizeof (char *)); That should perhaps be converted to use SAFE_ALLOCA. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."