From: Andreas Schwab <schwab@linux-m68k.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 8344@debbugs.gnu.org
Subject: bug#8344: (substring ...) crashes on large vectors
Date: Sun, 27 Mar 2011 09:52:58 +0200 [thread overview]
Message-ID: <m2hbap0zl1.fsf@igel.home> (raw)
In-Reply-To: <4D8E9E93.80303@cs.ucla.edu> (Paul Eggert's message of "Sat, 26 Mar 2011 19:18:59 -0700")
Paul Eggert <eggert@cs.ucla.edu> writes:
> @@ -373,10 +373,10 @@
> path = Fsubstring (path, make_number (2), Qnil);
>
> new_argv_volatile = new_argv = (const unsigned char **)
> - alloca (max (2, nargs - 2) * sizeof (char *));
> + alloca ((nargs > 4 ? nargs - 2 : 2) * sizeof (char *));
That should perhaps be converted to use SAFE_ALLOCA.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2011-03-27 7:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-25 18:17 bug#8344: (substring ...) crashes on large vectors Paul Eggert
2011-03-25 21:24 ` Stefan Monnier
2011-03-25 21:48 ` Paul Eggert
2011-03-27 2:18 ` Paul Eggert
2011-03-27 7:52 ` Andreas Schwab [this message]
2011-03-27 9:09 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2hbap0zl1.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=8344@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).