From: Andreas Schwab <schwab@linux-m68k.org>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: 11894@debbugs.gnu.org, Dmitry Gutov <dgutov@yandex.ru>
Subject: bug#11894: 24.1.50; [PATCH] diff-apply-hunk can be off by 1 line when the hunk is 0-context pure removal
Date: Thu, 19 Jul 2012 10:40:57 +0200 [thread overview]
Message-ID: <m2hat4jg86.fsf@igel.home> (raw)
In-Reply-To: <jwva9yww5ec.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Thu, 19 Jul 2012 03:58:55 -0400")
Stefan Monnier <monnier@IRO.UMontreal.CA> writes:
>>> This looks like a bug in those versions of diff (not that I know
>>> a non-buggy version, tho).
>> Maybe, but that's how POSIX wants it:
>
>> The ending line number of an empty range shall be the number of the
>> preceding line, or 0 if the range is at the start of the file.
>
> Hmm... but the number we're talking about is the starting-line-number,
> isn't it?
There is no starting-line-number.
Next, the range of lines in file1 shall be written in the following
format if the range contains two or more lines:
"*** %d,%d ****\n", <beginning line number>, <ending line number>
and the following format otherwise:
"*** %d ****\n", <ending line number>
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2012-07-19 8:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-10 1:46 bug#11894: 24.1.50; [PATCH] diff-apply-hunk can be off by 1 line when the hunk is 0-context pure removal Dmitry Gutov
2012-07-18 12:53 ` Stefan Monnier
2012-07-18 13:28 ` Andreas Schwab
2012-07-19 7:58 ` Stefan Monnier
2012-07-19 8:40 ` Andreas Schwab [this message]
2012-07-18 17:25 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2hat4jg86.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=11894@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).