unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: Glenn Morris <rgm@gnu.org>
Cc: 37165@debbugs.gnu.org
Subject: bug#37165: lookup-family-specification test fails
Date: Sat, 24 Aug 2019 15:00:26 +0200	[thread overview]
Message-ID: <m2h866pvkl.fsf@gmail.com> (raw)
In-Reply-To: <g5imqnsmsx.fsf@fencepost.gnu.org> (Glenn Morris's message of "Fri, 23 Aug 2019 15:29:18 -0400")

>>>>> On Fri, 23 Aug 2019 15:29:18 -0400, Glenn Morris <rgm@gnu.org> said:

    GM> Package: emacs
    GM> Severity: minor
    GM> Version: 27.0.50

    GM> The test lookup-family-specification fails on hydra.nixos.org:

    GM>     google.com/0 Name or service not known
    GM>     Test lookup-family-specification condition:
    GM>         (ert-test-failed
    GM>          ((should
    GM>            (network-lookup-address-info "google.com" 'ipv4))
    GM>           :form
    GM>           (network-lookup-address-info "google.com" ipv4)
    GM>           :value nil))
    GM>        FAILED   1/18  lookup-family-specification (0.002023 sec)

    GM> Perhaps the system doesn't having working DNS, in which case you
    GM> probably just want to add

    GM> (skip-unless (not (getenv "EMACS_HYDRA_CI")))

OK, Iʼve added that where appropriate.

    GM> I suppose this could be true of other systems too, but don't know how
    GM> you check that.

By doing a DNS lookup :-)

    GM> Note that test lookup-google passes, but based on the above it should not.
    GM> (should (length X)) seems like a buggy test condition (it passes when X
    GM> is nil).

Yes, plus some others pass that shouldn't. Should be fixed now.

Robert





  reply	other threads:[~2019-08-24 13:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-23 19:29 bug#37165: lookup-family-specification test fails Glenn Morris
2019-08-24 13:00 ` Robert Pluim [this message]
2019-09-02 15:32   ` Robert Pluim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2h866pvkl.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=37165@debbugs.gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).