From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Filipp Gunbin Newsgroups: gmane.emacs.bugs Subject: bug#51037: [PATCH] Make `print-level` & `print-length` customizable in ERT batch tests Date: Wed, 24 Nov 2021 22:53:07 +0300 Message-ID: References: <86tuhvmtpl.fsf@runbox.com> <86fst5m48v.fsf@runbox.com> <87a6jd5891.fsf@gnus.org> <86mtmykxro.fsf@runbox.com> <87y26hz24c.fsf@gnus.org> <86bl3blcgm.fsf@runbox.com> <87wnlya9sj.fsf@gnus.org> <86wnlbmooj.fsf@runbox.com> <87fsry7qdy.fsf@gnus.org> <87bl2m7q9g.fsf@gnus.org> <86zgq5kn9y.fsf@runbox.com> <87ilws7d7e.fsf@gnus.org> <87pmqxlsob.fsf@gnus.org> <86pmqwkw1r.fsf@pobox.com> <86mtlylqm6.fsf@pobox.com> <86h7c4l1wa.fsf@pobox.com> <868rxdldoo.fsf@pobox.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7990"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (darwin) Cc: gazally@runbox.com, Lars Ingebrigtsen , 51037@debbugs.gnu.org To: Michael Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 24 21:01:20 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mpySE-0001rg-9w for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 24 Nov 2021 21:01:20 +0100 Original-Received: from localhost ([::1]:59402 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mpySD-0006aE-85 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 24 Nov 2021 15:01:17 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:43138) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpyLC-0003Px-DS for bug-gnu-emacs@gnu.org; Wed, 24 Nov 2021 14:54:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43499) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mpyLC-00008B-4l for bug-gnu-emacs@gnu.org; Wed, 24 Nov 2021 14:54:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mpyLC-0007be-3f for bug-gnu-emacs@gnu.org; Wed, 24 Nov 2021 14:54:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Filipp Gunbin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Nov 2021 19:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51037 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51037-submit@debbugs.gnu.org id=B51037.163778359829157 (code B ref 51037); Wed, 24 Nov 2021 19:54:02 +0000 Original-Received: (at 51037) by debbugs.gnu.org; 24 Nov 2021 19:53:18 +0000 Original-Received: from localhost ([127.0.0.1]:55034 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpyKU-0007aD-1N for submit@debbugs.gnu.org; Wed, 24 Nov 2021 14:53:18 -0500 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]:57577) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpyKS-0007Zu-52 for 51037@debbugs.gnu.org; Wed, 24 Nov 2021 14:53:17 -0500 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id E487D5C010A; Wed, 24 Nov 2021 14:53:10 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 24 Nov 2021 14:53:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=MPXG0+tzenz9GFXARi/mvvoauv 1SMyt4zLQQyjPUuVM=; b=T7zoEFC9f0zlbfa5mq9huR9w6YTGXZycrwP6gkF/b1 ATGY7iwGifzsW/Apvr7tQOL56lNcoBP5aNtLcO6wX1k9xKXazF+9OZmmjypso1rb LRmJYukcHZAIiMiXkTphxB+B4x/LcJc4MvDG4pd4FsWMmgIQSHaYbx2ka8y9xihJ u9+dVR0DGqAw1pTilFvaxvXFAV6Ul+jRFsE7WDhF2bxE7cM7kyEpQaFwPo2QXvvA K2Gx8vb74AwLTjEnaHpgF+IbROkL5zZq2KPUchgm9rRXYYzd5AN1QQ7WvnGfgXvA E1Q5TMKKkB3mQDYqZ26NZ4d3rebqcdP8EE0XJTK4O0YA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=MPXG0+ tzenz9GFXARi/mvvoauv1SMyt4zLQQyjPUuVM=; b=kZ7c0WKgO1r5w2NoUZko48 E/QSg7Ocu4f7OCtJWKPMTbS9UMDvqP00ULp60XEJrOJqLCGTMhagmPetK076s/jZ 1LKWdlMiMFP1r91N2+QZMxjPaVeO3x/frccXPBxf5SH0irTl9GNOsT4jprZFe46q tvu+MmNIOtpjCSedizWTcioUwDqBDw2UQrqG+x03uIzSItSWR9+uqkMws4V1LxhJ W8+Ws1g1mdp6gXkK5sn/yg7ivhg+2lXol0mAKb0kR2cjUv4JGdO46U2sUXeVDp1w w35Q+3Hb86nztL7h8VExSSt3dFY8GuwShnaQ3sXU/XjH5ISSx3yUX9gVbmFRNOng == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrgeekgddufeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhgffffkgggtsehttdertddtredtnecuhfhrohhmpefhihhlihhp phcuifhunhgsihhnuceofhhguhhnsghinhesfhgrshhtmhgrihhlrdhfmheqnecuggftrf grthhtvghrnhepvdevkeffvdeuvefhuddtjeehkedvueefveettddtveduudfgieffieev ieevhfdtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epfhhguhhnsghinhesfhgrshhtmhgrihhlrdhfmh X-ME-Proxy: Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 24 Nov 2021 14:53:09 -0500 (EST) In-Reply-To: <868rxdldoo.fsf@pobox.com> (Michael's message of "Wed, 24 Nov 2021 08:29:43 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220771 Archived-At: On 24/11/2021 08:29 -0800, Michael wrote: >>> So, we could do either of: >>> >>> 1. As Filipp suggests, just change the contract for >>> `ert-batch-backtrace-line-length' to: if set to nil, you get >>> full stack traces, period. >>> >>> 2. change `cl-print-to-string-with-limit' to respect the >>> existing values of `print-length' & `print-level' when >>> `limit' is nil. Note that the only caller (in Emacs) of this >>> function is the backtrace package. >>> >>> I vote for option 2. What say you all? >> >> I think the right way is 1 (which I already installed) because >> then, as >> the result of your patch, we get the ability to override >> backtrace-line-length with ert-batch-backtrace-line-length, and >> nothing >> more. >> >> Changing the semantics of backtrace-line-length should be done >> (if done) >> in a separate issue, IMO. >> >> Personally, I like that LIMIT in cl-print-to-string-with-limit >> is "hard >> override". > > *shrugs* OK... so can we close this issue? But it's closed already?