From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Brian Leung Newsgroups: gmane.emacs.bugs Subject: bug#53853: [PATCH] Don't use string-replace in flymake Date: Tue, 08 Feb 2022 08:28:21 +0000 Message-ID: References: <87r18e7fb7.fsf@gmail.com> <87zgn1ublj.fsf@gnus.org> <87mtj17oqg.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18996"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , joaotavora@gmail.com, 53853@debbugs.gnu.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 08 10:27:07 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nHMmB-0004it-Bs for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Feb 2022 10:27:07 +0100 Original-Received: from localhost ([::1]:45982 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nHMmA-00086v-66 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Feb 2022 04:27:06 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:38622) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHLvq-0004qA-Cn for bug-gnu-emacs@gnu.org; Tue, 08 Feb 2022 03:33:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51246) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nHLvq-0003g6-2b for bug-gnu-emacs@gnu.org; Tue, 08 Feb 2022 03:33:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nHLvp-0000dL-TU for bug-gnu-emacs@gnu.org; Tue, 08 Feb 2022 03:33:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Brian Leung Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Feb 2022 08:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53853 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 53853-submit@debbugs.gnu.org id=B53853.16443091672414 (code B ref 53853); Tue, 08 Feb 2022 08:33:01 +0000 Original-Received: (at 53853) by debbugs.gnu.org; 8 Feb 2022 08:32:47 +0000 Original-Received: from localhost ([127.0.0.1]:45143 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHLva-0000cr-PX for submit@debbugs.gnu.org; Tue, 08 Feb 2022 03:32:46 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]:59555) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHLvY-0000cd-AS for 53853@debbugs.gnu.org; Tue, 08 Feb 2022 03:32:45 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id E7965240103 for <53853@debbugs.gnu.org>; Tue, 8 Feb 2022 09:32:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1644309157; bh=WMevpxcl4FXY45FO475iC7dMqyo6vxdkf4mJIJKLraU=; h=From:To:Cc:Subject:Date:From; b=NFG6k6qHmYkkDCS5eMq5nw1KwBm2UoF4G91qjcu5O87mWTIjD7F5eAPWVJ+3V5pMF EAyPV54EX35iWnmtfhKvbUkMEFm18d3vMLSas1jYXbM+t9vbWqmNQIMChyTJ0ubzXd hH2ZPcJepNtIuUa2ojpf5U84z2I8c8PrVD2Nr2wOxVt6uyNAw5iQMxhFOQlV3zpTH1 SF7Xn+r381gHKyfuhaibWLwqi03GNu04mu6LolQRWUl5vEZbrVEUEc2XrgJOE8b5Vx c5qqPgax1MpVz5cxN+a8aeMt3wuCGfghZ1lI45XsM9jomCvyu3zsRTqyKZzvAPgWx/ w4jaUy3Eokvaw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4JtGTv5t0Sz9rxN; Tue, 8 Feb 2022 09:32:35 +0100 (CET) In-reply-to: <87mtj17oqg.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:226335 Archived-At: I'm not sure how this kind of thing is usually handled, but for=20 this specific fix, I think it's worth bumping the version since=20 there are probably a decent chunk of people on Emacs <=3D 27 who=20 will otherwise encounter an issue with Eglot (one guy reported=20 this yesterday on the mailing list). Robert Pluim writes: >>>>>> On Tue, 08 Feb 2022 07:16:40 +0100, Lars Ingebrigtsen=20 >>>>>> said: > > Lars> Brian Leung writes: > >> OK, I've updated the patch per your suggestions. I've=20 > >> also made the > >> commit apply to the emacs-28 branch, as opposed to the=20 > >> master branch. > > Lars> Thanks; pushed to emacs-28. > > I=CA=BCm not au fait with how core packages work, does this require a=20 > bump > in flymake's package version? > > Robert