From: Harald Maier <harald@maierh.de>
To: Ivan Andrus <IAndrus@omniture.com>
Cc: 3792@emacsbugs.donarmstrong.com
Subject: bug#3792: #3792 - 23.1.50; other-window misbehaving with C-tab keybinding - Emacs bug report logs
Date: Sat, 11 Jul 2009 19:55:54 +0200 [thread overview]
Message-ID: <m2fxd3ums5.fsf@ate.maierh> (raw)
In-Reply-To: <C67CB6D5.8F92E%iandrus@omniture.com> (Ivan Andrus's message of "Fri, 10 Jul 2009 09:13:55 -0600")
Ivan Andrus <IAndrus@omniture.com> writes:
> I noticed that view-lossage shows two <C-tab> for every time I press
> it. In nsterm.m it specifically checks for control-tab and references
> http://osdir.com/ml/editors.vim.mac/2007-10/msg00141.html Which in
> turn references
> https://bugzilla.mozilla.org/show_bug.cgi?id=374076#c12
>
> Which makes me think that in Mac OS 10.4 the control-tab keyDown event
> isn't sent, but in 10.5 it is. Or at the very least in the latest
> version of 10.5 (I'm running 10.5.7) it sends a keyDown event.
>
> I have implemented what I think is a very simple fix (though it is
> probably not ideal). It sets a flag if it recieves a C-tag keyDown,
> and if so does not send the corresponging keyUp. I like this because
> then it works on keyDown like everything else if possible, but if not
> it should work on keyUp. I don't have the facilities to test the
> latter assumption.
>
> Also the patch almost certainly is less efficient than it could be.
> For example it sets flags and code twice (I believe) to the same
> thing, but I'm not really familiar enough with the code to want to
> risk changing that (and it's only for the Cocoa port as well). I
> believe it should be correct at least.
>
> -Ivan Andrus
Works fine for me. Thanks!
Maybe you should resend the Patch. In line 3 at the end the two final
'@@' characters are missing.
IMHO, that workaround should be added to 23.1. In 2009-02-20 I too
reported the bug as #2402.
Harald
next prev parent reply other threads:[~2009-07-11 17:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-10 15:13 bug#3792: #3792 - 23.1.50; other-window misbehaving with C-tab keybinding - Emacs bug report logs Ivan Andrus
2009-07-11 7:44 ` bug#3792: 23.1.50; other-window misbehaving with C-tab keybinding YAMAMOTO Mitsuharu
2009-07-11 17:55 ` Harald Maier [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-07-13 17:17 bug#3792: #3792 - 23.1.50; other-window misbehaving with C-tab keybinding - Emacs bug report logs Ivan Andrus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2fxd3ums5.fsf@ate.maierh \
--to=harald@maierh.de \
--cc=3792@emacsbugs.donarmstrong.com \
--cc=IAndrus@omniture.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).