From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Filipp Gunbin Newsgroups: gmane.emacs.bugs Subject: bug#31446: 26.1; sql-interactive-mode buffer naming is broken Date: Mon, 21 May 2018 02:53:08 +0300 Message-ID: References: <83d0xti993.fsf@gnu.org> <83bmddi2ad.fsf@gnu.org> <83603lhrvw.fsf@gnu.org> <8336yoiuf4.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1526860330 15201 195.159.176.226 (20 May 2018 23:52:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 20 May 2018 23:52:10 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (darwin) Cc: psainty@orcon.net.nz, 31446@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 21 01:52:05 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fKY7P-0003oI-Qx for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 May 2018 01:52:04 +0200 Original-Received: from localhost ([::1]:48050 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fKY9X-0001oH-19 for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 May 2018 19:54:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55739) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fKY9N-0001mi-7f for bug-gnu-emacs@gnu.org; Sun, 20 May 2018 19:54:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fKY9K-0007Mr-5N for bug-gnu-emacs@gnu.org; Sun, 20 May 2018 19:54:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34357) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fKY9K-0007Mn-11 for bug-gnu-emacs@gnu.org; Sun, 20 May 2018 19:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fKY9J-00059R-PD for bug-gnu-emacs@gnu.org; Sun, 20 May 2018 19:54:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Filipp Gunbin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 May 2018 23:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31446 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31446-submit@debbugs.gnu.org id=B31446.152686039319721 (code B ref 31446); Sun, 20 May 2018 23:54:01 +0000 Original-Received: (at 31446) by debbugs.gnu.org; 20 May 2018 23:53:13 +0000 Original-Received: from localhost ([127.0.0.1]:42251 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fKY8X-000581-GI for submit@debbugs.gnu.org; Sun, 20 May 2018 19:53:13 -0400 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]:49733) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fKY8V-00057s-Ja for 31446@debbugs.gnu.org; Sun, 20 May 2018 19:53:12 -0400 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id EBF782237A; Sun, 20 May 2018 19:53:10 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 20 May 2018 19:53:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=1WJgLlXabzZ+peF+uUg1FKZcudExfp+6ne4edHsEKvI=; b=pCATxymG W5WruCPchuvRq4KyorgDcSEoMNRoSt+HsXtkHuM/GaU38vJLqpkXFmEcQvbiJdSk 1ttbxCz1WCZj/kNV35k/nQQQ8o8NgR67DI2YoQnCTGsj9gooSw2JcSBryq6t6gE/ HDs6kWyNHUUFLQ06+1Wk49MXTbMeZWvqi5CUQeABiPUe2BLV33IaISYTRHqsYwTK 83vyjIf6/oyqSTbTxh16Gc49qemNlBqZDC7/szj/jrAvyr50I211riUiPwDCIETF YCmguTqMibKkAasHUmf8Xt4vfHzmQKHNG1wV3HJiNGv+saytFxJyLIiid7OdgfhZ cetuBzOPdUqHjQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=1WJgLlXabzZ+peF+uUg1FKZcudExf p+6ne4edHsEKvI=; b=MDs+B1Kvkx1ndZnIJoYqbcA0ScNSM1+NKVs54L8G0UaBn GAFT81e5q9wZbaaZIUi+VnOnWIvRaAS/Pq06HntmsHArAkRHQMYD7a437dSNI9fD IHMdf/9oYPOyMgW+lLesSPSQewlS666FrAy8WItYMfBz6qzrUAgbwbbkfOivBOI1 A2PlF4ItFaysPL85j1af5/8mE+J1AKzl5mnCrqk60kS+6qyFW6FpahfLguxw1Obz mXMioVPt3Ya7k38cXYPYp49lFONrbB+4Xp/JYHy584BAKm0X3I1AiOQPFOPTrIGZ IVamsKkcKCRZC4x4ryc7zEjrjE3UlwrqJ6AHjbq/Q== X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Sender: Original-Received: from fgunbin.local (unknown [93.185.19.243]) by mail.messagingengine.com (Postfix) with ESMTPA id F31781025C; Sun, 20 May 2018 19:53:09 -0400 (EDT) In-Reply-To: <8336yoiuf4.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 18 May 2018 23:24:31 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:146330 Archived-At: On 18/05/2018 23:24 +0300, Eli Zaretskii wrote: >> From: Filipp Gunbin >> Cc: psainty@orcon.net.nz, 31446@debbugs.gnu.org >> Date: Fri, 18 May 2018 21:03:00 +0300 >> >> Your patch, while it may have fixed the bug, introduces some logic on >> setting buffer name - so we could get undesired behaviour change. > > AFAIK, the logic was already there, I just fixed it to behave more > reasonably. > > The original code was > > (if (and new-name (string-prefix-p "SQL" new-name t)) > new-name > (concat "SQL: " new-name)))) > > This is now > (cond > ((zerop new-name) > "*SQL*") > ((stringp new-name) > (if (string-prefix-p "SQL" new-name t) > new-name > (concat "*SQL: " new-name "*"))) > ((eq new-name '(4)) > (sql-rename-buffer new-name) > sql-alternate-buffer-name) > (t > (format "*SQL: %s*" new-name))))) > > which (a) avoids concatenating a string and a list '(4); (b) avoids > calling string-prefix-p with 2nd arg not a string, something that > works only by sheer luck; (c) calls sql-rename-buffer to choose the > buffer name, because that function implements the logic of naming the > buffer, and duplicating that sounds redundant; (d) does something > reasonable when new-name is neither a string nor a prefix arg nor nil. > > And that is the only thing that I changed. That looks reasonable, but, as I wrote earlier, why implement name-choosing logic here, if it's in `sql-comint' already. Even if some of such logic was here before the fix, it doesn't necessarily mean that was right. > ((eq new-name '(4)) > (sql-rename-buffer new-name) > sql-alternate-buffer-name) `sql-alternate-buffer-name' not always matches the effective name set by `sql-rename-buffer'.. I'll test my suggestion tomorrow and will write about the result, if you don't mind. Filipp