unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: alex.branham@gmail.com, Stefan Kangas <stefan@marxist.se>,
	30990@debbugs.gnu.org
Subject: bug#30990: Should the byte compiler warn about :type mismatches?
Date: Thu, 10 Oct 2019 15:11:20 +0200	[thread overview]
Message-ID: <m2ftk07nk7.fsf@gmail.com> (raw)
In-Reply-To: <87imox4rci.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 09 Oct 2019 22:05:33 +0200")

>>>>> On Wed, 09 Oct 2019 22:05:33 +0200, Lars Ingebrigtsen <larsi@gnus.org> said:

    Lars> Oh, I missed this bit in the sql code;
    Lars>     (dolist (ext '(".json.gpg" ".gpg" ".json" "") wallet)

    Lars> So `wallet' is returned and the code is fine...

Except that the underlying type is '(repeat ....) so I wonder if this:

    (dolist (ext '(".json.gpg" ".gpg" ".json" "") wallet)
      (unless wallet
        (setq w (locate-user-emacs-file (concat "sql-wallet" ext)
                                        (concat ".sql-wallet" ext)))
        (when (file-exists-p w)
          (setq wallet w))))) ; <= this returns a string
          
should use (setq wallet (list w)) instead

Robert





  reply	other threads:[~2019-10-10 13:11 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-29 16:55 bug#30990: Should the byte compiler warn about :type mismatches? Alex Branham
2018-03-29 17:11 ` Glenn Morris
2020-09-25 12:44   ` Lars Ingebrigtsen
2019-09-28 19:00 ` Stefan Kangas
2019-09-28 19:21   ` Eli Zaretskii
2019-09-30 11:49     ` Robert Pluim
2019-09-30 15:45       ` Lars Ingebrigtsen
2019-10-09 13:34         ` Robert Pluim
2019-10-09 17:57           ` Lars Ingebrigtsen
2019-10-09 20:05           ` Lars Ingebrigtsen
2019-10-10 13:11             ` Robert Pluim [this message]
2019-10-11  5:54               ` Lars Ingebrigtsen
2020-09-25 13:18               ` Lars Ingebrigtsen
2020-09-25 13:36                 ` Lars Ingebrigtsen
2020-09-25 13:43                   ` Lars Ingebrigtsen
2019-10-09 18:44 ` Mattias Engdegård
2019-10-11  9:31 ` Robert Pluim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2ftk07nk7.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=30990@debbugs.gnu.org \
    --cc=alex.branham@gmail.com \
    --cc=larsi@gnus.org \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).