unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#52303: [PATCH] Remove not defined face info-menu-5 from manoj-dark theme
@ 2021-12-05 17:43 Y. E. via Bug reports for GNU Emacs, the Swiss army knife of text editors
  2021-12-05 21:19 ` Lars Ingebrigtsen
  0 siblings, 1 reply; 9+ messages in thread
From: Y. E. via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2021-12-05 17:43 UTC (permalink / raw)
  To: 52303

[-- Attachment #1: Type: text/plain, Size: 439 bytes --]

Tags: patch

Hello,

The face 'info-menu-5' was obsoleted in favor to 'info-menu-star' back
in 2005 (185cff95450).

This patch suggests removal of the not defined face and not updating it,
because the de facto used 'info-menu-star' default value has served the
theme users during the last years.

A side-question: do I still need to add "Copyright-paperwork-exempt:
yes" to the minor commits even if I have the CA completed?

Thanks,
YE



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-etc-themes-manoj-dark-theme.el-Remove-not-defined-fa.patch --]
[-- Type: text/patch, Size: 985 bytes --]

From 85ca17dd7fd3d3aaf8be81d2358809a7768d598e Mon Sep 17 00:00:00 2001
From: YugaEgo <yet@ego.team>
Date: Sun, 5 Dec 2021 19:32:44 +0200
Subject: [PATCH] ; * etc/themes/manoj-dark-theme.el: Remove not defined face
 info-menu-5

Copyright-paperwork-exempt: yes
---
 etc/themes/manoj-dark-theme.el | 1 -
 1 file changed, 1 deletion(-)

diff --git a/etc/themes/manoj-dark-theme.el b/etc/themes/manoj-dark-theme.el
index f10b88507e..e80403f5b3 100644
--- a/etc/themes/manoj-dark-theme.el
+++ b/etc/themes/manoj-dark-theme.el
@@ -541,7 +541,6 @@ manoj-dark
  '(ido-indicator ((t (:background "red1" :foreground "yellow1" :width condensed))))
  '(ido-only-match ((t (:foreground "ForestGreen"))))
  '(ido-subdir ((t (:foreground "red1"))))
- '(info-menu-5 ((t (:underline t))))
  '(info-menu-header ((t (:bold t :weight bold))))
  '(info-node ((t (:bold t :italic t :foreground "yellow"))))
  '(info-node ((t (:italic t :bold t :foreground "white" :slant italic :weight bold))))
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* bug#52303: [PATCH] Remove not defined face info-menu-5 from manoj-dark theme
  2021-12-05 17:43 bug#52303: [PATCH] Remove not defined face info-menu-5 from manoj-dark theme Y. E. via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2021-12-05 21:19 ` Lars Ingebrigtsen
  2021-12-07 10:18   ` Y. E. via Bug reports for GNU Emacs, the Swiss army knife of text editors
  0 siblings, 1 reply; 9+ messages in thread
From: Lars Ingebrigtsen @ 2021-12-05 21:19 UTC (permalink / raw)
  To: Y. E.; +Cc: 52303

Y. E. <yet@ego.team> writes:

> The face 'info-menu-5' was obsoleted in favor to 'info-menu-star' back
> in 2005 (185cff95450).
>
> This patch suggests removal of the not defined face and not updating it,
> because the de facto used 'info-menu-star' default value has served the
> theme users during the last years.

Thanks; applied to Emacs 29.

> A side-question: do I still need to add "Copyright-paperwork-exempt:
> yes" to the minor commits even if I have the CA completed?

Nope.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#52303: [PATCH] Remove not defined face info-menu-5 from manoj-dark theme
  2021-12-05 21:19 ` Lars Ingebrigtsen
@ 2021-12-07 10:18   ` Y. E. via Bug reports for GNU Emacs, the Swiss army knife of text editors
  2021-12-07 20:23     ` Lars Ingebrigtsen
  0 siblings, 1 reply; 9+ messages in thread
From: Y. E. via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2021-12-07 10:18 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: 52303, yet

Hi Lars,

The pushed commit message caught my attention: it seems both the
suggested commit message and the corrected one got into.

See d3d8a6ccda7, and also 0d8e9588e1c, 6620d03e334.





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#52303: [PATCH] Remove not defined face info-menu-5 from manoj-dark theme
  2021-12-07 10:18   ` Y. E. via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2021-12-07 20:23     ` Lars Ingebrigtsen
  2021-12-08 10:14       ` Y. E. via Bug reports for GNU Emacs, the Swiss army knife of text editors
  0 siblings, 1 reply; 9+ messages in thread
From: Lars Ingebrigtsen @ 2021-12-07 20:23 UTC (permalink / raw)
  To: Y. E.; +Cc: 52303

Y. E. <yet@ego.team> writes:

> The pushed commit message caught my attention: it seems both the
> suggested commit message and the corrected one got into.
>
> See d3d8a6ccda7, and also 0d8e9588e1c, 6620d03e334.

Sorry, I don't understand what you mean here.

Is there something that should be changed?  If so, can you suggest a
patch to do so?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#52303: [PATCH] Remove not defined face info-menu-5 from manoj-dark theme
  2021-12-07 20:23     ` Lars Ingebrigtsen
@ 2021-12-08 10:14       ` Y. E. via Bug reports for GNU Emacs, the Swiss army knife of text editors
  2021-12-09  1:11         ` Lars Ingebrigtsen
  0 siblings, 1 reply; 9+ messages in thread
From: Y. E. via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2021-12-08 10:14 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: 52303, yet

>
>> The pushed commit message caught my attention: it seems both the
>> suggested commit message and the corrected one got into.
>>
>> See d3d8a6ccda7, and also 0d8e9588e1c, 6620d03e334.
>
> Sorry, I don't understand what you mean here.

Ah, sorry, I wasn't clear enough.

The mentioned commit messages seem to contain accidentally duplicated
content. For example, see the part of the `git show d3d8a6ccda7' output:

Date:   Sun Dec 5 22:18:18 2021 +0100

    ; * etc/themes/manoj-dark-theme.el: Remove not defined face info-menu-5
    
    * etc/themes/manoj-dark-theme.el (manoj-dark): Remove reference to
    face removed in 2005 (bug#52303).

diff --git a/etc/themes/manoj-dark-theme.el b/etc/themes/manoj-dark-theme.el

> Is there something that should be changed?

My guess was I should have notified you, in case this indeed was a kind
of a typo or broken automation. (I didn't see/notice such commit
messages in Emacs commit history before.)

Best,
YE





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#52303: [PATCH] Remove not defined face info-menu-5 from manoj-dark theme
  2021-12-08 10:14       ` Y. E. via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2021-12-09  1:11         ` Lars Ingebrigtsen
  2021-12-09 10:36           ` Y. E. via Bug reports for GNU Emacs, the Swiss army knife of text editors
  0 siblings, 1 reply; 9+ messages in thread
From: Lars Ingebrigtsen @ 2021-12-09  1:11 UTC (permalink / raw)
  To: Y. E.; +Cc: 52303

Y. E. <yet@ego.team> writes:

> The mentioned commit messages seem to contain accidentally duplicated
> content. For example, see the part of the `git show d3d8a6ccda7' output:
>
> Date:   Sun Dec 5 22:18:18 2021 +0100
>
>     ; * etc/themes/manoj-dark-theme.el: Remove not defined face info-menu-5
>
>     * etc/themes/manoj-dark-theme.el (manoj-dark): Remove reference to
>     face removed in 2005 (bug#52303).
>
> diff --git a/etc/themes/manoj-dark-theme.el b/etc/themes/manoj-dark-theme.el
>
>> Is there something that should be changed?
>
> My guess was I should have notified you, in case this indeed was a kind
> of a typo or broken automation. (I didn't see/notice such commit
> messages in Emacs commit history before.)

Do you mean that the commit message here is wrong?  I still don't quite
understand what you mean.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#52303: [PATCH] Remove not defined face info-menu-5 from manoj-dark theme
  2021-12-09  1:11         ` Lars Ingebrigtsen
@ 2021-12-09 10:36           ` Y. E. via Bug reports for GNU Emacs, the Swiss army knife of text editors
  2021-12-10  0:35             ` Lars Ingebrigtsen
  0 siblings, 1 reply; 9+ messages in thread
From: Y. E. via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2021-12-09 10:36 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: 52303, yet

>> The mentioned commit messages seem to contain accidentally duplicated
>> content. For example, see the part of the `git show d3d8a6ccda7' output:
>>
>> Date:   Sun Dec 5 22:18:18 2021 +0100
>>
>>     ; * etc/themes/manoj-dark-theme.el: Remove not defined face info-menu-5
>>
>>     * etc/themes/manoj-dark-theme.el (manoj-dark): Remove reference to
>>     face removed in 2005 (bug#52303).
>>
>> diff --git a/etc/themes/manoj-dark-theme.el b/etc/themes/manoj-dark-theme.el
>>
>>> Is there something that should be changed?
>>
>> My guess was I should have notified you, in case this indeed was a kind
>> of a typo or broken automation. (I didn't see/notice such commit
>> messages in Emacs commit history before.)
>
> Do you mean that the commit message here is wrong?  I still don't quite
> understand what you mean.

Yes, it seemed so to me: the two lines of the commit message saying
basically the same thing. If it's correct, then what purpose does it
serve?

Thanks.





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#52303: [PATCH] Remove not defined face info-menu-5 from manoj-dark theme
  2021-12-09 10:36           ` Y. E. via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2021-12-10  0:35             ` Lars Ingebrigtsen
  2021-12-10 10:52               ` Y. E. via Bug reports for GNU Emacs, the Swiss army knife of text editors
  0 siblings, 1 reply; 9+ messages in thread
From: Lars Ingebrigtsen @ 2021-12-10  0:35 UTC (permalink / raw)
  To: Y. E.; +Cc: 52303

Y. E. <yet@ego.team> writes:

> Yes, it seemed so to me: the two lines of the commit message saying
> basically the same thing. If it's correct, then what purpose does it
> serve?

The first is the summary line, and the rest is the ChangeLog style text.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#52303: [PATCH] Remove not defined face info-menu-5 from manoj-dark theme
  2021-12-10  0:35             ` Lars Ingebrigtsen
@ 2021-12-10 10:52               ` Y. E. via Bug reports for GNU Emacs, the Swiss army knife of text editors
  0 siblings, 0 replies; 9+ messages in thread
From: Y. E. via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2021-12-10 10:52 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: 52303, yet

> The first is the summary line, and the rest is the ChangeLog style text.

I'm glad there's no issue.

Thank you,
YE






^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2021-12-10 10:52 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-05 17:43 bug#52303: [PATCH] Remove not defined face info-menu-5 from manoj-dark theme Y. E. via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-05 21:19 ` Lars Ingebrigtsen
2021-12-07 10:18   ` Y. E. via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-07 20:23     ` Lars Ingebrigtsen
2021-12-08 10:14       ` Y. E. via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-09  1:11         ` Lars Ingebrigtsen
2021-12-09 10:36           ` Y. E. via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-10  0:35             ` Lars Ingebrigtsen
2021-12-10 10:52               ` Y. E. via Bug reports for GNU Emacs, the Swiss army knife of text editors

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).