From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Newsgroups: gmane.emacs.bugs Subject: bug#70357: 30.0.50; loadup.el, load nadvice before seq Date: Sat, 13 Apr 2024 09:07:43 +0200 Message-ID: References: <861q79ss2s.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7172"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 70357@debbugs.gnu.org, Stefan Monnier To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 13 09:09:12 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rvXVf-0001ev-Ac for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 Apr 2024 09:09:11 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rvXVO-00047K-He; Sat, 13 Apr 2024 03:08:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rvXVN-00046u-4F for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2024 03:08:53 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rvXVM-00058w-P3 for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2024 03:08:52 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rvXVW-0007qV-Ft for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2024 03:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Apr 2024 07:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70357 X-GNU-PR-Package: emacs Original-Received: via spool by 70357-submit@debbugs.gnu.org id=B70357.171299208629649 (code B ref 70357); Sat, 13 Apr 2024 07:09:02 +0000 Original-Received: (at 70357) by debbugs.gnu.org; 13 Apr 2024 07:08:06 +0000 Original-Received: from localhost ([127.0.0.1]:59911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvXUb-0007i5-BN for submit@debbugs.gnu.org; Sat, 13 Apr 2024 03:08:06 -0400 Original-Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]:46215) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvXUY-0007g5-DF for 70357@debbugs.gnu.org; Sat, 13 Apr 2024 03:08:04 -0400 Original-Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-56fd7df9ea9so1814001a12.0 for <70357@debbugs.gnu.org>; Sat, 13 Apr 2024 00:07:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712992066; x=1713596866; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=lvIbsm2YKbBXXlZYLgN2SwmGILOp23R8ZuQeVo20z0A=; b=eDFUve4twbp9B9ckFnL5KGv/RQMuY2XAoJdr8J0tL9xcSXSBGDYic0YyzaILw3qISc bsZna/a+xnXuWNrl+8n+1uDmerqll3mAwJeZB6fpfGXZnGg7lnAXMO+ASq4gF0R5cnf+ QMgEIabAPLJnVZVjtu8cCrmhGkpJz9ne0lCX6EbbtDKV+tvTvC5G3NPnre5JxNcEusCb eqBEE27qp0UjZXoUTBP0eMSPsgSULy56HQlv5BjQ2DUr1As64ztRS7vOhq7esDWTOPj1 xx/lTsBbmSHOStkX38Y3WkgtvON7Gegi7dac9Eihui3cLjqU8oB6cG+qTzDhtj/v+xrN 9XhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712992066; x=1713596866; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lvIbsm2YKbBXXlZYLgN2SwmGILOp23R8ZuQeVo20z0A=; b=Bw+UtSc7KUgk9iH1Ilni12bZ+8Pisp0crVdnzUC1nUmHrTzretF4fq4sJmfwl6IGWo yWbzp+XuO2RdfOpj9wt7SDD/54yXO/NhFT9rwmEs3Ahp8pmDMVrJbo4smh6HiryGgumN PggfRkrLzzSvdw3yHQ7Ubz4m8XpoVz3LcjYbdzPscYaN9Tb2oT7q6iBNTvX7Ib8N6nG0 PLCJqllFHRGWjVdfx1Mdg+tFw8o0EvCvxt9MpSveBkp1Cm5C/6R150CgZbXOD3DjMoPs MPrZM8LUE6xhUxu9R3iA18v8CawT2rYylIhIPQhSJ5y5OkOWWnCGJKfLX8GzevbICH7R noYQ== X-Forwarded-Encrypted: i=1; AJvYcCVRDzWD/dSC5WaxpxL2gOgvOiw42fjD8LYpUJF8pzky+yrVhjM4PYDb/ACeuoWQlsC+YFNHP/UwPNJThOhRfI3TCDG/Q7o= X-Gm-Message-State: AOJu0Yx4Dh0X8dLwbVDFVo8Pr2L0R6GqnjLVaS+rPdwkVNgRdeCKgQOd ob526+M4uxtdGA+em9mZGbRetfOfcExsw2T0ACGeUxo7ajX9plobNsnynGsJ X-Google-Smtp-Source: AGHT+IEC1xiImZS5S1AMkrBLKg9nia8GDSJuskSxSAY1e+MjEyjENRFmbu6c3hyv4z8w663yN/6Gmg== X-Received: by 2002:a50:ccd7:0:b0:56e:2e96:2f8f with SMTP id b23-20020a50ccd7000000b0056e2e962f8fmr3052879edj.6.1712992065761; Sat, 13 Apr 2024 00:07:45 -0700 (PDT) Original-Received: from Pro.fritz.box (p4fe3aa41.dip0.t-ipconnect.de. [79.227.170.65]) by smtp.gmail.com with ESMTPSA id z3-20020a056402274300b0056e3d80ca71sm2405551edd.35.2024.04.13.00.07.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 Apr 2024 00:07:45 -0700 (PDT) In-Reply-To: <861q79ss2s.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 13 Apr 2024 09:19:07 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283164 Archived-At: Eli Zaretskii writes: >> Cc: 70357@debbugs.gnu.org >> Date: Fri, 12 Apr 2024 16:43:56 -0400 >> From: Stefan Monnier via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> > If a seq.elc exists, and we dump bootstrap-emacs.pdmp, and seq.el gets >> > loaded, then the cl-generic machinery will want to warn about the fact >> > that certain method stuff in seq.elc is already compiled. This warning >> > wants to use somethign from nadvice, and ultimately a recursive load >> > (warnings.el requires icons.el, which uses seq, which leads to a >> > warning, etc). >> >> As a general rule, it's better (long term) to try and fix those circular >> dependencies by breaking the cycle. >> >> Maybe we could tweak `cl-generic` so it calls the byte-compiler in a way >> that silences all the warnings? >> Also, I'm not sure loading `icons` is necessary batch mode, so maybe we >> could make that conditional. > > Me, I don't think I understand the situation well enough. How come > this doesn't happen each time Emacs is built, for example? IOW, > there's something in the situation that triggers this that doesn't > happen "usually", and I don't understand from the description what > that its. This first sentence: > >> If a seq.elc exists, and we dump bootstrap-emacs.pdmp, and seq.el gets >> loaded, then the cl-generic machinery will want to warn about the fact >> that certain method stuff in seq.elc is already compiled. > > lost me: why is that warning being emitted, if all we need is to load > seq.el during loadup? loadup.el loads seq.elc in my case, not seq.el, and I think that's the difference. My mental model is, Stefan please correct me, that cl-generic calls the compiler on method functions, effective method function, and such. If seq.el, the source file, is loaded from loadup, these functions are not yet compiled. If seq.elc is loaded, the functions are apparently already compiled, and a warning is emitted.