From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alex Bochannek Newsgroups: gmane.emacs.bugs Subject: bug#73827: [ELPA] [PATCH] register-list fails on "Unprintable entity" registers Date: Wed, 16 Oct 2024 19:43:47 -0700 Message-ID: References: <87ldynk8un.fsf@jeremybryant.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13833"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 73827@debbugs.gnu.org To: Jeremy Bryant Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 17 04:45:06 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t1GVd-0003QD-Bp for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Oct 2024 04:45:05 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t1GVJ-0007m1-3C; Wed, 16 Oct 2024 22:44:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t1GVG-0007lr-EZ for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2024 22:44:42 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t1GVG-0001V3-6R for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2024 22:44:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=6BzOgU7KU7ykBEgptNy+xKQNZ0MDRNGctesxe8ruN6U=; b=Fcjhf8scj4/izjAZes3sUlCuzVftYrdeor+Ick/obhKBr0N57oKa5xqYl1Sg+90pk9yAWv844a5IX3osR+gbJlZXViXQcPihZvImOyg/c0Fdf8ngzjMBspzSlYxTRBwN9gC+YXdrLTllsUm//jbz95hlF5djkDyjdmu3LdLZKz8YFi8I1oDlegLDlAXJA2UUXwrXhjedQEpl30YyARoA5TKr2dt0NnvNpJfgt5wleQbVTUX0xoT2U6YuvnjyIHmkZSwJCDiOeHiKM4Z6QH8XqEGKXw3JsfAxPl2nN3exVBRNja8tq597QQtkI5jnM9YjVrZ5fN3adJ07oPAt5BI7cQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t1GVa-0003vG-4e for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2024 22:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alex Bochannek Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Oct 2024 02:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73827 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73827-submit@debbugs.gnu.org id=B73827.172913305715006 (code B ref 73827); Thu, 17 Oct 2024 02:45:02 +0000 Original-Received: (at 73827) by debbugs.gnu.org; 17 Oct 2024 02:44:17 +0000 Original-Received: from localhost ([127.0.0.1]:32842 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t1GUq-0003ty-NL for submit@debbugs.gnu.org; Wed, 16 Oct 2024 22:44:16 -0400 Original-Received: from ns.lapseofthought.com ([50.0.39.240]:63945 helo=mail.lapseofthought.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t1GUl-0003tk-1y for 73827@debbugs.gnu.org; Wed, 16 Oct 2024 22:44:14 -0400 Original-Received: from awb-mbp-m3.local (unknown [IPv6:2601:646:4200:73a0:b502:e338:b669:d22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lapseofthought.com (Postfix) with ESMTPSA id 4XTXGD1fVcz3pftt; Wed, 16 Oct 2024 19:43:48 -0700 (PDT) Authentication-Results: ORIGINATING; auth=pass smtp.auth=alex smtp.mailfrom=alex@bochannek.com In-Reply-To: <87ldynk8un.fsf@jeremybryant.net> (Jeremy Bryant's message of "Wed, 16 Oct 2024 22:59:12 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293698 Archived-At: --=-=-= Content-Type: text/plain Jeremy Bryant writes: > Alex Bochannek writes: > >> Hello! >> >> I have not submitted patches against an ELPA package before, so I hope > > Philip, any comments? > >> >> Apologies again for the format of this submission. If someone could >> point me at instructions for how to make your life easier next time, I'd >> appreciate it. > > Please read the file CONTRIBUTE in the Emacs source tree. Figured out my issue with populating the ELPA repo (new computer, old version of gmake) and I am including the patch in the proper format now. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Fix-unprintable-register-display-logic.patch >From dafcff7c7a9cb6952aa740ef34a67eb61fd2a90d Mon Sep 17 00:00:00 2001 From: Alex Bochannek Date: Wed, 16 Oct 2024 19:35:33 -0700 Subject: [PATCH] Fix unprintable register display logic --- register-list.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/register-list.el b/register-list.el index 846d3efe49..5a81b1b7bb 100644 --- a/register-list.el +++ b/register-list.el @@ -478,8 +478,8 @@ the register or copy its value into the kill ring." (t "error")) (cond ((window-configuration-p (car key)) "W") ((frame-configuration-p (car key)) "F") - ((stringp (car key)) "R") ((string= "Unprintable entity" (car key)) "?") + ((stringp (car key)) "R") (t "error")))) ;;; Edit key/value of the register -- 2.39.5 (Apple Git-154) --=-=-= Content-Type: text/plain -- Alex. --=-=-=--