From: Alex Bochannek <alex@bochannek.com>
To: Jeremy Bryant <jb@jeremybryant.net>
Cc: 73827@debbugs.gnu.org
Subject: bug#73827: [ELPA] [PATCH] register-list fails on "Unprintable entity" registers
Date: Wed, 16 Oct 2024 19:43:47 -0700 [thread overview]
Message-ID: <m2frov5tzw.fsf@bochannek.com> (raw)
In-Reply-To: <87ldynk8un.fsf@jeremybryant.net> (Jeremy Bryant's message of "Wed, 16 Oct 2024 22:59:12 +0100")
[-- Attachment #1: Type: text/plain, Size: 583 bytes --]
Jeremy Bryant <jb@jeremybryant.net> writes:
> Alex Bochannek <alex@bochannek.com> writes:
>
>> Hello!
>>
>> I have not submitted patches against an ELPA package before, so I hope
>
> Philip, any comments?
>
>>
>> Apologies again for the format of this submission. If someone could
>> point me at instructions for how to make your life easier next time, I'd
>> appreciate it.
>
> Please read the file CONTRIBUTE in the Emacs source tree.
Figured out my issue with populating the ELPA repo (new computer, old
version of gmake) and I am including the patch in the proper format now.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-unprintable-register-display-logic.patch --]
[-- Type: text/x-patch, Size: 799 bytes --]
From dafcff7c7a9cb6952aa740ef34a67eb61fd2a90d Mon Sep 17 00:00:00 2001
From: Alex Bochannek <alex@bochannek.com>
Date: Wed, 16 Oct 2024 19:35:33 -0700
Subject: [PATCH] Fix unprintable register display logic
---
register-list.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/register-list.el b/register-list.el
index 846d3efe49..5a81b1b7bb 100644
--- a/register-list.el
+++ b/register-list.el
@@ -478,8 +478,8 @@ the register or copy its value into the kill ring."
(t "error"))
(cond ((window-configuration-p (car key)) "W")
((frame-configuration-p (car key)) "F")
- ((stringp (car key)) "R")
((string= "Unprintable entity" (car key)) "?")
+ ((stringp (car key)) "R")
(t "error"))))
;;; Edit key/value of the register
--
2.39.5 (Apple Git-154)
[-- Attachment #3: Type: text/plain, Size: 11 bytes --]
--
Alex.
next prev parent reply other threads:[~2024-10-17 2:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-15 23:14 bug#73827: [ELPA] [PATCH] register-list fails on "Unprintable entity" registers Alex Bochannek
[not found] ` <87ldynk8un.fsf@jeremybryant.net>
2024-10-17 2:43 ` Alex Bochannek [this message]
2024-11-25 23:02 ` Alex Bochannek
2024-11-26 21:35 ` Jeremy Bryant via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-11-26 21:56 ` Philip Kaludercic
2024-11-27 1:39 ` Alex Bochannek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2frov5tzw.fsf@bochannek.com \
--to=alex@bochannek.com \
--cc=73827@debbugs.gnu.org \
--cc=jb@jeremybryant.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).