From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Newsgroups: gmane.emacs.bugs Subject: bug#75322: SAFE_ALLOCA assumed to root Lisp_Objects/SSDATA(string) Date: Sun, 05 Jan 2025 12:37:42 +0100 Message-ID: References: <87jzbbke6u.fsf@protonmail.com> <86sepx8sth.fsf@gnu.org> <86h66d8pnl.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13082"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: pipcet@protonmail.com, 75322@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 05 12:38:38 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tUOxp-0003H5-JL for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Jan 2025 12:38:37 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tUOxS-0003WQ-QJ; Sun, 05 Jan 2025 06:38:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tUOxG-0003VM-75 for bug-gnu-emacs@gnu.org; Sun, 05 Jan 2025 06:38:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tUOxF-0006VR-VH for bug-gnu-emacs@gnu.org; Sun, 05 Jan 2025 06:38:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=MVPEK1xlkXOouZ/Zh8F1NztEF7niicdHtq6Sl9zEHjU=; b=KciIcsQYSIN7Ryo+cI8h2j71GAndGWeWQLYMBzCizZI4OpWtBLYUjluw1mZhBhkHdAnxqFSCDkeaF6nQ4QwSv9kVEISDXpntF2sDg/cSxdipVBC8JWTuRy3hhbAFasHEjo9/1w28UpfZtZRLztrfiDCXIOmvNWBSiXOQeIJQrDh7ECDHzEZI+TmvTKX0mMDFTK+/7w7VdKeAbKAq4ySNofvL1A6Nj8l0dMn23vrdKBsVj7w1d32uhQBTZNXCpbiATD5wTI9r7+1kXCyM+83jNw7hzsPy5y8y/xPoPDhmGNAISI9SEGtkDT8URETej31YhfkaeKFZIS1LmZWIt8IyFg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tUOxF-0005Sq-Q7 for bug-gnu-emacs@gnu.org; Sun, 05 Jan 2025 06:38:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Jan 2025 11:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75322 X-GNU-PR-Package: emacs Original-Received: via spool by 75322-submit@debbugs.gnu.org id=B75322.173607707220970 (code B ref 75322); Sun, 05 Jan 2025 11:38:01 +0000 Original-Received: (at 75322) by debbugs.gnu.org; 5 Jan 2025 11:37:52 +0000 Original-Received: from localhost ([127.0.0.1]:60177 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tUOx6-0005SA-4C for submit@debbugs.gnu.org; Sun, 05 Jan 2025 06:37:52 -0500 Original-Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]:61807) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tUOx4-0005Rj-JL for 75322@debbugs.gnu.org; Sun, 05 Jan 2025 06:37:51 -0500 Original-Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-4368a293339so100542065e9.3 for <75322@debbugs.gnu.org>; Sun, 05 Jan 2025 03:37:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736077064; x=1736681864; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=MVPEK1xlkXOouZ/Zh8F1NztEF7niicdHtq6Sl9zEHjU=; b=npSszkh2FLbdGv8DzoYZDnOHZmC6JQS1BAcPWNE3FEaJ2Jn/kzMHczKNvBIEExkDZS XmtpX33xLE/z5GCN4rzqr98mkB97XzIaQ+dq1IdgMBTB5hCPmwgBQM81+1ZD2za2d7bJ eeVLu9hOVHVVSTYoSWOL2yvcYABXhQ25VIIwlQrPBKu2xsfXIHTgZxWxyF88ZSvRSvQD d5SxLaD14euUklj2zM66NruYkYiSvcN+7yUwPtUDX80mkAJ7065U+XFjapZ4xV8uB2lQ NZWvh92yNMSwo1DIqw5EQOTCkYZBpQ6r4/faOtJUcb+oOGkzxhPJGO3yozaJzla2nhOO 0bPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736077064; x=1736681864; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MVPEK1xlkXOouZ/Zh8F1NztEF7niicdHtq6Sl9zEHjU=; b=IBWmbYFe7ctGdecqyTotHpAq2gOlcBcG8CPbFIl1sX2HQJnsESvphmsvzlce6TyzIZ NpE+njzGVV6aktlPa9wB53/A/SaEuPwrhPkAHZQBlsuO8UIfBVZfw3TX5CZzzASnRfxY GZzckSwkCKDpRTfTuEk93ngFiDTDuQb/JO7qq3pSBT4qy5O/UkW+YfG5i4bL/eRvHM8x /B8xquhncJ4yVNXCQOisA65nH/wbtcuzxSUcrx7bV1uZqN95ecwjiCY3Wqx9YB4VJKCj 8aTKwb/V2Zbwn3XiRNxyRCHhSOvcN9bXApP00hoOsv2q1kDnUue5Tloo6brnN/Cu4QHf 1N0w== X-Forwarded-Encrypted: i=1; AJvYcCUHbTgpJECQtCBna7H/O2V/95Q1GsqEinX98u+pKwDGETMrmpC/W0+ossG7b2PeNVBtPy+ZJw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxmOqF/v7BOEahY3E0aF34nA3A3XzzyZDXWqR3B2zZ0IGYt0GlU h3XSytX5rMmdXU53h3UQ8JrtLtgh/V8EX5xHvLa8Y1momPQ/tRxJyO/XOw== X-Gm-Gg: ASbGncu1VLWlBJl4n+EI4w95lsedI8pztA5I/JZ5h0uQqDE6cV4eajR73CzTmqEZQTZ kyoYUgKa7tcuQ0bkCrLtFbYcnyhR29qJ/TTq5njrW8zNfu28cOfkjBYtd0W6gsnvfF8EpyTeEj7 VFVrdUnV3IzhoyvxKS0rJLWpQ4o7uWRR/HjCJIDqCDOFU+Ppyk20tBdC/oH7TMik4n8dDdhPT7l ftux1N3zabgYdBVCUue3e0NFFVwZEL7cHOGh80ftgSp7+fOOrDs8Cpb80a8de9D52Pgghc+XYiG CNgtEodN7y6anw6pCxUarzxLvk943ESv6KGlv2eF75gXLn05LlZbw4SE8OecwU9Srw== X-Google-Smtp-Source: AGHT+IE5fhuZv7dm2lN8qsMMwCd5SOrr+QSnf4aTqEPMaQSOjQLLJA5WoN7xa2k1yhav7EE8ojrSdQ== X-Received: by 2002:a05:6000:1565:b0:38a:1b94:ecc1 with SMTP id ffacd0b85a97d-38a221f5e39mr44171306f8f.25.1736077063795; Sun, 05 Jan 2025 03:37:43 -0800 (PST) Original-Received: from pro2 (p200300e0b747500078d774d9859911e7.dip0.t-ipconnect.de. [2003:e0:b747:5000:78d7:74d9:8599:11e7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c828e7asm44910481f8f.21.2025.01.05.03.37.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jan 2025 03:37:43 -0800 (PST) In-Reply-To: <86h66d8pnl.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 05 Jan 2025 13:29:34 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298546 Archived-At: Eli Zaretskii writes: >> If you mean the two patches I sent with "these two", then no. I prefer >> using SAFE_ALLOCA_LISP because that introduces an exact root. > > I guess I'm confused, then. The first patch replaces calls to > SAFE_NALLOCA by SAFE_ALLOCA_LISP, the second patch modifies > SAFE_NALLOCA to call igc_xnmalloc_ambig. That's why I thought they > were alternatives. > > If they are not alternatives, then why did you replace SAFE_NALLOCA in > the first patch? I checked other uses of SAFE_NALLOCA that were not yet mentioned, and found another problematic case. (Something with struct itree_node *, don't remember the function name, it's in some other mail). There were too many grep hits for SAFE_NALLOCA for me, so I shot with a canon :-).