From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: John Wiegley Newsgroups: gmane.emacs.bugs Subject: bug#22859: 25.0.91; Errors in auto-revert-notify-handler Date: Mon, 29 Feb 2016 12:27:35 -0800 Message-ID: Reply-To: John Wiegley NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1456778077 28383 80.91.229.3 (29 Feb 2016 20:34:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 29 Feb 2016 20:34:37 +0000 (UTC) To: 22859@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Feb 29 21:34:19 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aaUWJ-0007nB-6h for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 Feb 2016 21:34:19 +0100 Original-Received: from localhost ([::1]:39036 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aaUWI-00083Q-IP for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 Feb 2016 15:34:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58349) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aaUWF-00082g-PN for bug-gnu-emacs@gnu.org; Mon, 29 Feb 2016 15:34:16 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aaUWC-0004eP-9u for bug-gnu-emacs@gnu.org; Mon, 29 Feb 2016 15:34:15 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:56996) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aaUW2-0004c6-1h for bug-gnu-emacs@gnu.org; Mon, 29 Feb 2016 15:34:12 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aaUW1-0005vx-TU for bug-gnu-emacs@gnu.org; Mon, 29 Feb 2016 15:34:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: John Wiegley Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Feb 2016 20:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 22859 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.145677800922765 (code B ref -1); Mon, 29 Feb 2016 20:34:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 29 Feb 2016 20:33:29 +0000 Original-Received: from localhost ([127.0.0.1]:54123 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aaUVV-0005v7-G5 for submit@debbugs.gnu.org; Mon, 29 Feb 2016 15:33:29 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:39002) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aaUVU-0005uu-Ly for submit@debbugs.gnu.org; Mon, 29 Feb 2016 15:33:28 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aaUVO-0004V8-JU for submit@debbugs.gnu.org; Mon, 29 Feb 2016 15:33:23 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:44608) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aaUVO-0004V4-Fi for submit@debbugs.gnu.org; Mon, 29 Feb 2016 15:33:22 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58199) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aaUVN-0007uG-BO for bug-gnu-emacs@gnu.org; Mon, 29 Feb 2016 15:33:22 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aaUVH-0004Tl-H2 for bug-gnu-emacs@gnu.org; Mon, 29 Feb 2016 15:33:21 -0500 Original-Received: from mail-pa0-x22f.google.com ([2607:f8b0:400e:c03::22f]:33043) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aaUVH-0004Tg-9Z for bug-gnu-emacs@gnu.org; Mon, 29 Feb 2016 15:33:15 -0500 Original-Received: by mail-pa0-x22f.google.com with SMTP id fl4so97852650pad.0 for ; Mon, 29 Feb 2016 12:33:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:user-agent:reply-to :mail-followup-to:mime-version; bh=qqjrokotafMlyLHbp/XURTmGb6iLQl8ii/w3hD+Ywto=; b=A5WLjS39KuubMN5x1uLgn50gTVeTonmi4N1g3wcD1iNiEcxHR4ci7fB21Wj/CgOASt H7j9x4M1c4f0Bn8esBCmAhhy4xQRP/yzTyf73KSPd+gaS4fpBTKMMtiRLqEQOgdh68Ap YlvjSKPCOEB0dUX6RmJ99nLtCU/ZbpHDYqr5G9QU7FaB/Tkg5Q730PAN9uykIwUzgz9R xPPl5Lj/XJTtZ7BcG1LhggAMaaCNEBhvVOo2WDLXMXPjVc3n1/JLghkHu/9Ieg/6juR8 5hCEQo/D3Nxob6/kjRy6k5ai8s7TTTRpPSfIJS0bzboP8r9xs+Pkb4Gw+LfSsQmSYeLm P8Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :reply-to:mail-followup-to:mime-version; bh=qqjrokotafMlyLHbp/XURTmGb6iLQl8ii/w3hD+Ywto=; b=mg0L5jPQEaa6mGFsE+Ls/cBLyeMBMc0FNBDFp/7Ib83D6KiPgf4aVOUXwR40Oo6LB0 nQdSzbbDEkE/TbdPQIxKgiZnxY7Q7OZQ82+nHYHz1UFwxRg89s8yL4vGJiqvemNE1tJ9 qAVXOI3jWIUUft1C7RQ6uBJT67qXvaYb9Jx5JXf7ZO0FSmwDyZjXSkeNztqcLluOcX+U Ce2xZ7QZCMfeFc5uhv1HzzhIKwOjbUvqUBItGY8WwUeLZlQQEC3Pm/EYHFFvbxGpC2FE E06DLs/ugN4dm/lAtJu3QYfrcmS3A6NV0hzl3cZHRD5p0g5fmTz8VyJ3lIwqVVWmPwxe ZI1g== X-Gm-Message-State: AD7BkJJrUvcyAWh+3x7TJoJhmx9ZC/oMyOnNkWGMhHNBmcmWcdeZHxJs0TyRtlMo1RerjA== X-Received: by 10.66.237.39 with SMTP id uz7mr13109345pac.141.1456777994263; Mon, 29 Feb 2016 12:33:14 -0800 (PST) Original-Received: from Vulcan.local (76-234-68-79.lightspeed.frokca.sbcglobal.net. [76.234.68.79]) by smtp.gmail.com with ESMTPSA id 195sm40104211pfa.5.2016.02.29.12.33.12 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 29 Feb 2016 12:33:12 -0800 (PST) X-Google-Original-From: "John Wiegley" Original-Received: by Vulcan.local (Postfix, from userid 501) id C8B5B132E9B24; Mon, 29 Feb 2016 12:33:11 -0800 (PST) User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.0.91 (darwin) Mail-Followup-To: bug-gnu-emacs@gnu.org X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:114165 Archived-At: While doing general editing and saving of files with emacs-25, I'm getting the following backtrace somewhat often: --8<---------------cut here---------------start------------->8--- Debugger entered: ((cl-assertion-failed (stringp file1) nil)) cl--assertion-failed((stringp file1)) auto-revert-notify-handler((29 renamed "/Users/johnw/bae/rings/vignettes/simple_parser_fiat/Main.hs")) file-notify-callback((29 (rename) "/Users/johnw/bae/rings/vignettes/simple_parser_fiat/Main.hs")) file-notify-handle-event((file-notify (29 (rename) "/Users/johnw/bae/rings/vignettes/simple_parser_fiat/Main.hs") file-notify-callback)) funcall-interactively(file-notify-handle-event (file-notify (29 (rename) "/Users/johnw/bae/rings/vignettes/simple_parser_fiat/Main.hs") file-notify-callback)) call-interactively(file-notify-handle-event nil [(file-notify (29 (rename) "/Users/johnw/bae/rings/vignettes/simple_parser_fiat/Main.hs") file-notify-callback)]) command-execute(file-notify-handle-event nil [(file-notify (29 (rename) "/Users/johnw/bae/rings/vignettes/simple_parser_fiat/Main.hs") file-notify-callback)] t) --8<---------------cut here---------------end--------------->8--- The responsible code, in autorevert.el: --8<---------------cut here---------------start------------->8--- (defun auto-revert-notify-handler (event) "Handle an EVENT returned from file notification." (with-demoted-errors (let* ((descriptor (car event)) (action (nth 1 event)) (file (nth 2 event)) (file1 (nth 3 event)) ;; Target of `renamed'. (buffers (gethash descriptor auto-revert-notify-watch-descriptor-hash-list))) ;; Check, that event is meant for us. (cl-assert descriptor) ;; Since we watch a directory, a file name must be returned. (cl-assert (stringp file)) (when (eq action 'renamed) (cl-assert (stringp file1))) --8<---------------cut here---------------end--------------->8--- However, I'm not performing any file renames. Perhaps this is due to the renaming of files used when creating backups? What code might be raising a rename enough without a rename target? From a cursory inspection, it looks like it might be the file notification logic? -- John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2