From: Nick Helm <nick@tenpoint.co.nz>
To: 28697@debbugs.gnu.org
Subject: bug#28697: 25.3; eldoc changes mode-line settings
Date: Wed, 04 Oct 2017 22:25:41 +1300 [thread overview]
Message-ID: <m2efqj6z8q.fsf@tenpoint.co.nz> (raw)
In-Reply-To: <m2r2ujwdnr.fsf@tenpoint.co.nz> (Nick Helm's message of "Wed, 04 Oct 2017 20:55:04 +1300")
On Wed, 4 Oct 2017 at 20:55:04 +1300, Nick Helm wrote:
> - (unless (and (listp mode-line-format)
> - (assq 'eldoc-mode-line-string mode-line-format))
> + (when (and mode-line-format
> + (not (assq 'eldoc-mode-line-string mode-line-format)))
Sorry, I got the patch wrong. This one works a little better:
--- a/lisp/emacs-lisp/eldoc.el 2017-10-04 22:11:09.000000000 +1300
+++ b/lisp/emacs-lisp/eldoc.el 2017-10-04 22:10:32.000000000 +1300
@@ -261,12 +261,13 @@
(or (window-in-direction 'above (minibuffer-window))
(minibuffer-selected-window)
(get-largest-window)))
+ (when mode-line-format
(unless (and (listp mode-line-format)
(assq 'eldoc-mode-line-string mode-line-format))
(setq mode-line-format
(list "" '(eldoc-mode-line-string
(" " eldoc-mode-line-string " "))
- mode-line-format)))
+ mode-line-format))))
(setq eldoc-mode-line-string
(when (stringp format-string)
(apply #'format-message format-string args)))
next prev parent reply other threads:[~2017-10-04 9:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 7:55 bug#28697: 25.3; eldoc changes mode-line settings Nick Helm
2017-10-04 9:25 ` Nick Helm [this message]
2017-10-21 8:43 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2efqj6z8q.fsf@tenpoint.co.nz \
--to=nick@tenpoint.co.nz \
--cc=28697@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).