From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alex Bochannek Newsgroups: gmane.emacs.bugs Subject: bug#74553: [ELPA] [PATCH] register-list does not support framesets Date: Tue, 26 Nov 2024 18:18:18 -0800 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11759"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Philip Kaludercic To: 74553@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 27 03:25:28 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tG7k7-0002vW-V8 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 27 Nov 2024 03:25:28 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tG7jl-0006yH-QY; Tue, 26 Nov 2024 21:25:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tG7jk-0006wo-F7 for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2024 21:25:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tG7jk-0007sV-5x for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2024 21:25:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:Subject; bh=c6Q5gpKqGYSSwpLmWJ278FtEejCy03+ONRXMIDbxwng=; b=vBcQZGd5zErvbdyShUrf/QcmqJMm6wE+cevwb+RndefVTBfVinJ0+dg9htgf1N9W6Ii01yQCB0ntup45q2siIm5gP050bXCqYegyOKfvtM36ixgbe6qMKzKM1qhm44wnDBm1XFGbWMo4F4zkM0rdhGZtN1KOgw3WD/zTh5AK82yUAWDKe622Wc4Y3Y9UkWYc86WcIEtl6wGt/SCRoxxu+ckmvntrbVM79Sw5IAeAElu+Q/3U41UsbMIk/4Se/fxSoUMuFHQ8kyPySXDTeUN307LCmqqaM4XawGZqcsvX4dtmB31U8CIBGzPcWP/SGV/kglNyil7+uOM2ePof12NHHw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tG7ji-0007hC-HC for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2024 21:25:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alex Bochannek Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Nov 2024 02:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 74553 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.173267428729547 (code B ref -1); Wed, 27 Nov 2024 02:25:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 27 Nov 2024 02:24:47 +0000 Original-Received: from localhost ([127.0.0.1]:55913 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tG7jS-0007gV-FN for submit@debbugs.gnu.org; Tue, 26 Nov 2024 21:24:46 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:34542) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tG7jQ-0007gN-H1 for submit@debbugs.gnu.org; Tue, 26 Nov 2024 21:24:44 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tG7jO-0006v1-Gi for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2024 21:24:42 -0500 Original-Received: from ns.lapseofthought.com ([50.0.39.240] helo=mail.lapseofthought.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tG7jM-0007nJ-A0 for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2024 21:24:42 -0500 Original-Received: from awb-mbp-m3.local (c-24-23-131-202.hsd1.ca.comcast.net [24.23.131.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lapseofthought.com (Postfix) with ESMTPSA id 4Xyjlt5sNgz3pt9S; Tue, 26 Nov 2024 18:18:18 -0800 (PST) Authentication-Results: ORIGINATING; auth=pass smtp.auth=alex smtp.mailfrom=alex@bochannek.com Received-SPF: pass client-ip=50.0.39.240; envelope-from=alex@bochannek.com; helo=mail.lapseofthought.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296014 Archived-At: --=-=-= Content-Type: text/plain Hello! This is a follow-up to a comment I made on bug#73827. The register-list package only supports frames, but not framesets. The below patch is not particularly elegant, because framesets are saved as registers as type frameset-register, so the frameset-p predicate does not apply here. This is a pretty simple change and if there is a better way, I am obviously open to it. Also note that I did not remove support for the frame configurations. I instead kept type "F" for both and updated the documentation. Because neither the values of frames nor framesets can be edited, this did not present an issue in testing. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Add-framesets-as-a-register-type.patch >From b5c881ef45a43b72c17dd27de2c3f9cd1c506fe1 Mon Sep 17 00:00:00 2001 From: Alex Bochannek Date: Tue, 26 Nov 2024 17:58:06 -0800 Subject: [PATCH] Add framesets as a register type --- register-list.el | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/register-list.el b/register-list.el index 846d3efe49..435861cd32 100644 --- a/register-list.el +++ b/register-list.el @@ -294,9 +294,9 @@ The Key column displays the character used for this register. Hitting \\[register-list-call-handler-at-point] on the key will prompt for a replacement. -The Type column displays the type of the register, either [F]rame -\[N]umber [M]arkers [R]ectangle [S]string or [W]window. Hitting -\\[register-list-call-handler-at-point] on this column will +The Type column displays the type of the register, either +[F]rame/Frameset [N]umber [M]arkers [R]ectangle [S]tring or [W]indow. +Hitting \\[register-list-call-handler-at-point] on this column will restrict the register list to this type of registers. To quickly list a specific type, hit the type character among [FNMRSW]. @@ -466,7 +466,7 @@ the register or copy its value into the kill ring." (frame-parameter (window-configuration-frame (car value)) 'name))) ((string= "F" type) - (format "[Frame configuration]")) + (format "[Frame/Frameset configuration]")) (t "[Error: unknown type]"))) (defun register-list-get-type (key) @@ -475,6 +475,7 @@ the register or copy its value into the kill ring." (cond ((stringp key) "S") ((markerp key) "M") ((numberp key) "N") + ((equal 'frameset-register (type-of key)) "F") (t "error")) (cond ((window-configuration-p (car key)) "W") ((frame-configuration-p (car key)) "F") -- 2.39.5 (Apple Git-154) --=-=-= Content-Type: text/plain -- Alex. --=-=-=--