From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Luis Gerhorst Newsgroups: gmane.emacs.bugs Subject: bug#25575: Make ido respect completions-common-part face Date: Sun, 29 Jan 2017 23:22:27 +0100 Message-ID: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1485728655 14894 195.159.176.226 (29 Jan 2017 22:24:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 29 Jan 2017 22:24:15 +0000 (UTC) User-Agent: mu4e 0.9.19; emacs 25.1.1 To: 25575@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jan 29 23:24:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXxtK-0003kP-6Q for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Jan 2017 23:24:10 +0100 Original-Received: from localhost ([::1]:57019 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXxtP-0004Xj-Nf for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Jan 2017 17:24:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58831) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXxtG-0004WU-SQ for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2017 17:24:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cXxtC-0001Or-Tn for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2017 17:24:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52293) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cXxtC-0001Ol-Q8 for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2017 17:24:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cXxtC-0000xQ-Ia for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2017 17:24:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Luis Gerhorst Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Jan 2017 22:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 25575 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.14857285843610 (code B ref -1); Sun, 29 Jan 2017 22:24:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 29 Jan 2017 22:23:04 +0000 Original-Received: from localhost ([127.0.0.1]:50492 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXxsG-0000w9-Bx for submit@debbugs.gnu.org; Sun, 29 Jan 2017 17:23:04 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:39440) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXxsF-0000vT-8H for submit@debbugs.gnu.org; Sun, 29 Jan 2017 17:23:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cXxs6-0000ul-OF for submit@debbugs.gnu.org; Sun, 29 Jan 2017 17:22:58 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:55123) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cXxs6-0000uh-L3 for submit@debbugs.gnu.org; Sun, 29 Jan 2017 17:22:54 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58638) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXxs5-0004Us-8n for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2017 17:22:54 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cXxs1-0000sR-9b for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2017 17:22:53 -0500 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]:41587) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cXxs1-0000ry-1e for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2017 17:22:49 -0500 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id D725B206CD for ; Sun, 29 Jan 2017 17:22:46 -0500 (EST) Original-Received: from frontend1 ([10.202.2.160]) by compute3.internal (MEProxy); Sun, 29 Jan 2017 17:22:46 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=luisgerhorst.de; h=content-type:date:from:message-id:mime-version:subject:to :x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=KcD IPKO7sCD/k8i2bYG6wKcX7Nc=; b=DbTXwtoQ/oDiD49v3uydcm/Z5M18jerefzk WIlIc9/f75+TTUVV2dRf9dtsgTRpcxGTCpojXALZJyozJKgBw+rNV3j7Mxo0vxpg HG9D1mkzZa9qYZ3Jia9B72F6mJO7iNl1I86jxFSw74uLfjEAiIsE+Jf4AQ/Cx7oo MdEqMDQ8= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=smtpout; bh=KcDIPKO7sCD/k8i2bYG6wKcX7Nc=; b=BJACq IUbcClsw+BxJY7fPS75uTdEyPZreGlZfaAGC8W/7Fv15j/DVCytDRWM6SvtyR9LT LF+aJblaQC2KathkJgFw01m6GNt59JJtiN1vaYRXzlK9f+aIZsQL9KPQwMDss6u8 eKJ/9Rq61LZcAXqCOb5SwatixX7xiEnO4mqYRo= X-ME-Sender: X-Sasl-enc: Uo4CMtdF0UaahQE40PfKkMwAz5cQnsJEDEWtZa87dY9d 1485728566 Original-Received: from luiss-imac.speedport_w_921v_1_43_000 (p5b33c55f.dip0.t-ipconnect.de [91.51.197.95]) by mail.messagingengine.com (Postfix) with ESMTPA id 4E3667E0E7 for ; Sun, 29 Jan 2017 17:22:46 -0500 (EST) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:128772 Archived-At: Hi, This would allow the user to customize the display of the common part of completions, e.g. remove the decorators around it and only distinguish it by using a different face (which looks much cleaner). Company also display the common part this way (see the `company-preview-common` face). Here's a advice based snippet that does what I want. It does not seem to handle colors properly but since completions-common-part just underlines text for me, it's ok: (defun luis-propertize-ido-common-match-string (&rest _) (when ido-common-match-string (setq ido-common-match-string (propertize ido-common-match-string 'face 'completions-common-part)))) (defun luis-unpropertize-ido-common-match-string (&rest _) (when ido-common-match-string (setq ido-common-match-string (propertize ido-common-match-string 'face nil)))) (advice-add 'ido-completions :before #'luis-propertize-ido-common-match-string) (advice-add 'ido-completions :after #'luis-unpropertize-ido-common-match-string) Best regards, Luis