From: Robert Pluim <rpluim@gmail.com>
To: 37884@debbugs.gnu.org
Cc: eggert@cs.ucla.edu, bernardo.bacic@pobox.com
Subject: bug#37884: 27.0.50; Cannot write to a file in VirtualBox shared directory
Date: Thu, 31 Oct 2019 08:38:59 +0100 [thread overview]
Message-ID: <m2d0edfjos.fsf@gmail.com> (raw)
In-Reply-To: <dc1103a2-bf7b-d0e1-6700-83ec2d056607@cs.ucla.edu> (Paul Eggert's message of "Wed, 30 Oct 2019 18:41:10 -0700")
>>>>> On Wed, 30 Oct 2019 18:41:10 -0700, Paul Eggert <eggert@cs.ucla.edu> said:
Paul> On 10/30/19 9:25 AM, Eli Zaretskii wrote:
>> Paul, do you
>> see any downsides to the last change posted in this discussion? IOW,
>> could there be some situations where it could do any harm?
Paul> That change involves two extra system calls (one of which doesn't
Paul> check the return value?!).
I donʼt know what value there would be in checking the return value of
chmod, given that weʼre already in an error situation.
Paul> In contrast, Bernardo's suggestion is
Paul> simpler, involves no extra system calls (or machine instructions, for
Paul> that matter), and has been tested. So I installed the attached patch
Paul> to implement and document the workaround, and am optimistically
Paul> closing the bug report.
Looks good to me. I was trying to avoid that, since I thought there
was a strong desire to keep the file read-only, otherwise why bother
with the fchmod in the first place?
Robert
next prev parent reply other threads:[~2019-10-31 7:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 10:28 bug#37884: 27.0.50; Cannot write to a file in VirtualBox shared directory Bernardo
2019-10-24 16:10 ` Robert Pluim
[not found] ` <87blu2emi3.fsf@pobox.com>
2019-10-27 15:34 ` Robert Pluim
2019-10-27 15:52 ` Eli Zaretskii
2019-10-27 16:01 ` Robert Pluim
2019-10-27 16:34 ` Eli Zaretskii
2019-10-28 9:23 ` Bernardo
2019-10-28 12:32 ` Robert Pluim
2019-10-29 8:50 ` Bernardo
2019-10-29 9:04 ` Andreas Schwab
2019-10-29 13:41 ` Robert Pluim
2019-10-30 8:44 ` Bernardo
2019-10-30 13:31 ` Robert Pluim
2019-10-30 16:25 ` Eli Zaretskii
2019-10-31 1:41 ` Paul Eggert
2019-10-31 7:38 ` Robert Pluim [this message]
2019-10-31 14:37 ` Eli Zaretskii
2019-10-31 21:24 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2d0edfjos.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=37884@debbugs.gnu.org \
--cc=bernardo.bacic@pobox.com \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).