From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#20891: emacs: Back off if .doc is not an Office document Date: Fri, 15 Nov 2019 10:14:19 +0100 Message-ID: References: <1435144758.2326415.306422097.2EE346E7@webmail.messagingengine.com> <875zngd2v4.fsf@mouse.gnus.org> <87pni54vou.fsf@marxist.se> <87o8xm3wz9.fsf@gnus.org> <83y2wpa7ml.fsf@gnu.org> <87lfsozu0z.fsf@gnus.org> <83a78y96tf.fsf@gnu.org> <874kz6ok88.fsf@gnus.org> <83imnm5yyh.fsf@gnu.org> <83v9rm4ehs.fsf@gnu.org> <83sgmq4dfj.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="102321"; mail-complaints-to="usenet@blaine.gmane.org" Cc: era+emacs@iki.fi, Andreas Schwab , larsi@gnus.org, 20891@debbugs.gnu.org, stefan@marxist.se To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 15 10:15:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iVXh9-000QOe-TS for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Nov 2019 10:15:12 +0100 Original-Received: from localhost ([::1]:36900 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVXh8-0000qe-1z for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Nov 2019 04:15:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48249) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVXh2-0000mN-5k for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2019 04:15:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iVXh0-0006ZP-PH for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2019 04:15:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55069) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iVXh0-0006ZI-Lb for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2019 04:15:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iVXh0-0001Ac-F4 for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2019 04:15:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Nov 2019 09:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20891 X-GNU-PR-Package: emacs Original-Received: via spool by 20891-submit@debbugs.gnu.org id=B20891.15738092714448 (code B ref 20891); Fri, 15 Nov 2019 09:15:02 +0000 Original-Received: (at 20891) by debbugs.gnu.org; 15 Nov 2019 09:14:31 +0000 Original-Received: from localhost ([127.0.0.1]:35657 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVXgV-00019g-BW for submit@debbugs.gnu.org; Fri, 15 Nov 2019 04:14:31 -0500 Original-Received: from mail-wm1-f41.google.com ([209.85.128.41]:39953) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVXgR-00019O-DD for 20891@debbugs.gnu.org; Fri, 15 Nov 2019 04:14:29 -0500 Original-Received: by mail-wm1-f41.google.com with SMTP id f3so9504601wmc.5 for <20891@debbugs.gnu.org>; Fri, 15 Nov 2019 01:14:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:gmane-reply-to-list:date:in-reply-to :message-id:mime-version; bh=G8zg9JrvgZktc6GlCuQx0IMnlFQgbYmHKG8hrx4C/0w=; b=t8VwMz73Ds8MubzAJypLbq6h3Yv+I0u2sVCfAyV7pG7bB/6fw6aYpnQTabsaRwVa0j PAQqQWK2Noiq4i2t6Uh6r8AGHjhRA0W0wwdTDBFYCFnwiaL7w14TY9n4JxUttrAH8GxF t5eOM5jEG4gOdnZ+Gj55v0EeYrSOvnupjgTfo/uvCkmpL1diFsS4wkxQWWdq/sj4UafH rodjUn6tBAA6bFSUiav8smYiPLN8i/U6wtUQXikBvJVKmdudQE9PGCisjwP34E25nQvK 8vJSNS+SamWB1Vbnz2eIJFqe8flkuu9L7H3V887CvKe030cZLbm63ndT/qQTGFEEOsgB c2pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references :gmane-reply-to-list:date:in-reply-to:message-id:mime-version; bh=G8zg9JrvgZktc6GlCuQx0IMnlFQgbYmHKG8hrx4C/0w=; b=LgcyF9xYo8W2/dX9mNOV4mCKzVkAJDAIdeIkBSUeFkEkddqGRSXoqE6a5BCP57GVaQ 4lEhxjU/trU2yKWVemvv1/NDZajwHpqNWZqM9wW6ypg3QX6uz4JJCB2Xo5B7nzuzWNrF qJj4SD7y6pDhX8Qh2YpCgBLYD93JtiWJz+N4nOLLIAl9BUoFJH5KwMlzNMERDaSpeEge PbKjMZ/8w24srLRxyMWkkmkCsTSIuavPOAnz8L8r9D5mv1lAJLCKNFiqmgliY32nk7Z1 aRpDHY3Fgsg//Hrn1HZ0JK3t0sPs2WEFDszxTmm3c46YYxDjCk+akPf19IKAvmQzYd2d y+Wg== X-Gm-Message-State: APjAAAXTL91JfXat3HKwCK2FVleQvXs7nCRyPy50kAqxwfLr0MpamVdX swR8kPJMp3yNauaL8eKA1sQ= X-Google-Smtp-Source: APXvYqyvYEoHLw/gTUlhnM7Txq6wihCwPNW8LKa0LBqZx4+Ea/NKFDpR/0B+VFvG6kunPWlq/6b65g== X-Received: by 2002:a1c:9804:: with SMTP id a4mr12925553wme.57.1573809261163; Fri, 15 Nov 2019 01:14:21 -0800 (PST) Original-Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id 11sm8970324wmi.8.2019.11.15.01.14.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Nov 2019 01:14:20 -0800 (PST) Gmane-Reply-To-List: yes In-Reply-To: <83sgmq4dfj.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 14 Nov 2019 18:42:40 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:171654 Archived-At: >>>>> On Thu, 14 Nov 2019 18:42:40 +0200, Eli Zaretskii said: Eli> So we want to remove docx? from auto-mode-alist and instead to add the Eli> magic signature to magic-mode-alist? But then AFAIK MS Word documents Eli> had different signatures for different versions, so we should have Eli> several. And a literal docx should be left in auto-mode-alist, right? Yes. The following detects a word 97 file for me, and a text .doc file opens in fundamental-mode. diff --git i/lisp/files.el w/lisp/files.el index 053583b4cb..ea3d3deb34 100644 --- i/lisp/files.el +++ w/lisp/files.el @@ -2798,7 +2798,7 @@ auto-mode-alist ("\\.\\(diffs?\\|patch\\|rej\\)\\'" . diff-mode) ("\\.\\(dif\\|pat\\)\\'" . diff-mode) ; for MS-DOS ("\\.[eE]?[pP][sS]\\'" . ps-mode) - ("\\.\\(?:PDF\\|DVI\\|OD[FGPST]\\|DOCX?\\|XLSX?\\|PPTX?\\|pdf\\|djvu\\|dvi\\|od[fgpst]\\|docx?\\|xlsx?\\|pptx?\\)\\'" . doc-view-mode-maybe) + ("\\.\\(?:PDF\\|DVI\\|OD[FGPST]\\|DOCX\\|XLSX?\\|PPTX?\\|pdf\\|djvu\\|dvi\\|od[fgpst]\\|docx\\|xlsx?\\|pptx?\\)\\'" . doc-view-mode-maybe) ("configure\\.\\(ac\\|in\\)\\'" . autoconf-mode) ("\\.s\\(v\\|iv\\|ieve\\)\\'" . sieve-mode) ("BROWSE\\'" . ebrowse-tree-mode) @@ -3062,6 +3062,7 @@ magic-fallback-mode-alist (comment-re (concat "\\(?:!--" incomment-re "*-->[ \t\r\n]*<\\)"))) (concat "[ \t\r\n]*<" comment-re "*!DOCTYPE ")) . sgml-mode) + ("\320\317\021\340\241\261\032\341" . doc-view-mode-maybe) ("%!PS" . ps-mode) ("# xmcd " . conf-unix-mode))) "Like `magic-mode-alist' but has lower priority than `auto-mode-alist'.