From: Alex Bochannek <alex@bochannek.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 43441@debbugs.gnu.org
Subject: bug#43441: 27.1; [PATCH] Fix incorrectly base64-padded faces in gnus-convert-face-to-png
Date: Mon, 28 Sep 2020 08:58:36 -0700 [thread overview]
Message-ID: <m2d025vqoj.fsf@bochannek.com> (raw)
In-Reply-To: <878scuw186.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 28 Sep 2020 14:10:49 +0200")
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Alex Bochannek <alex@bochannek.com> writes:
>
>> Took me a little while, but I broke this out into a utility function as
>> you suggested. I also wrote some tests for it. As part of me getting
>> familiar with ERT, I added a bunch of tests for gnus-string< and
>> gnus-string>, which I hope are useful. They should probably be in a
>> separate commit, but I leave that up to you.
>
> Thanks; looks good to me. I did some minor touch-ups before committing
> -- the first line in the comment string should be a complete sentence,
> and ";;" instead of ";;;", and when is preferred over else-less ifs and
> pushed to Emacs 28.
Great, thanks!
--
Alex.
prev parent reply other threads:[~2020-09-28 15:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 6:06 bug#43441: 27.1; [PATCH] Fix incorrectly base64-padded faces in gnus-convert-face-to-png Alex Bochannek
2020-09-17 15:31 ` Lars Ingebrigtsen
2020-09-28 6:05 ` Alex Bochannek
2020-09-28 12:10 ` Lars Ingebrigtsen
2020-09-28 15:58 ` Alex Bochannek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2d025vqoj.fsf@bochannek.com \
--to=alex@bochannek.com \
--cc=43441@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).