From mboxrd@z Thu Jan 1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Philipp
Newsgroups: gmane.emacs.bugs
Subject: bug#48489: 28.0.50;
Incorrect Edebug instrumentation for old `when-let' form
Date: Tue, 18 May 2021 00:08:30 +0200
Message-ID:
Mime-Version: 1.0
Content-Type: text/plain
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
logging-data="6008"; mail-complaints-to="usenet@ciao.gmane.io"
To: 48489@debbugs.gnu.org
Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 18 00:09:11 2021
Return-path:
Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.92)
(envelope-from )
id 1lilQE-0001Lq-Qa
for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 18 May 2021 00:09:10 +0200
Original-Received: from localhost ([::1]:45416 helo=lists1p.gnu.org)
by lists.gnu.org with esmtp (Exim 4.90_1)
(envelope-from )
id 1lilQD-0006Yh-6J
for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 17 May 2021 18:09:09 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59236)
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from )
id 1lilQ6-0006YU-ST
for bug-gnu-emacs@gnu.org; Mon, 17 May 2021 18:09:02 -0400
Original-Received: from debbugs.gnu.org ([209.51.188.43]:42418)
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from )
id 1lilQ6-0000D7-LC
for bug-gnu-emacs@gnu.org; Mon, 17 May 2021 18:09:02 -0400
Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
(envelope-from ) id 1lilQ6-00036u-FA
for bug-gnu-emacs@gnu.org; Mon, 17 May 2021 18:09:02 -0400
X-Loop: help-debbugs@gnu.org
Resent-From: Philipp
Original-Sender: "Debbugs-submit"
Resent-CC: bug-gnu-emacs@gnu.org
Resent-Date: Mon, 17 May 2021 22:09:02 +0000
Resent-Message-ID:
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: report 48489
X-GNU-PR-Package: emacs
X-Debbugs-Original-To: bug-gnu-emacs@gnu.org
Original-Received: via spool by submit@debbugs.gnu.org id=B.162128932011926
(code B ref -1); Mon, 17 May 2021 22:09:02 +0000
Original-Received: (at submit) by debbugs.gnu.org; 17 May 2021 22:08:40 +0000
Original-Received: from localhost ([127.0.0.1]:53964 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from )
id 1lilPk-00036I-8I
for submit@debbugs.gnu.org; Mon, 17 May 2021 18:08:40 -0400
Original-Received: from lists.gnu.org ([209.51.188.17]:47022)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from ) id 1lilPg-000368-Q4
for submit@debbugs.gnu.org; Mon, 17 May 2021 18:08:39 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59146)
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from )
id 1lilPg-0006Wm-Lv
for bug-gnu-emacs@gnu.org; Mon, 17 May 2021 18:08:36 -0400
Original-Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]:38739)
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from )
id 1lilPe-0008Hr-RH
for bug-gnu-emacs@gnu.org; Mon, 17 May 2021 18:08:36 -0400
Original-Received: by mail-wm1-x329.google.com with SMTP id
u4-20020a05600c00c4b02901774b80945cso354709wmm.3
for ; Mon, 17 May 2021 15:08:33 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=from:to:subject:date:message-id:mime-version;
bh=dOfuk/siKxw/qQx1iEE+WDWjzSVR7SuYYNa2Nvu5+Ds=;
b=dbTn830++fGaKAB2ga8bHtQGbiula09xiYbl0A3D7D8sz/q+HxSNpxqJZ3zOohs+sZ
YIAt5vxkrcMFxewATMGml32yqlQbU6ihmrfLw7YatRSKQNl9RR/YPQVQLy06iHZGTmoc
T0p2GjIQWgXNUSis3ko4ovNNGltkpHTx1o0pRznn+V0Blc5gPzI8PLy4e8TiL/zUdkqA
eplNNz6VV6zeXq+UazrsMV51RyQ57gr7BCSpZeSEQaW3G2B4g9UoFcLx9zHd8TvEFnqf
ffCJ2SX5z1pR50GXnV1yKvGObinA3R3PgvGr0gHbZZi3A4Rwn9fnThceuzFYEqe2BdaV
dOtQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:from:to:subject:date:message-id:mime-version;
bh=dOfuk/siKxw/qQx1iEE+WDWjzSVR7SuYYNa2Nvu5+Ds=;
b=O7u6Wv/CgsW/Kj7/RSc6guzqdgnyW1DyGiDcw4AViWqu16UZoqWL5Fg1cMpFe/ZwD7
iORVH3a8Tc27MI7Yu/ttHjsx5SL5mdl4GQ3xHv0LigWf3nPxFnetOEYUOkTdNNVgBP4w
fg3gf1rIf7SiFr4KobXXK4uTgR/W4JxAyOIQpswnUlnUV/1oC7kiICXK/dadPnCZOOYb
TUDQ5u9uJUpKQh2jb7s4EUDiEH77Z7Rwx4v2XZq/MfHwLEXRRBMTGlMM7JB2JPsgSoN3
fwXa6zHv98j1Qg0o9Rud7PudHKez7TCRfFb+0P/yWynvSTbXgsBCC5vco1wkSBf1zq3k
fxQg==
X-Gm-Message-State: AOAM5336S1PahXTQs06JHhnTVfL3sn7KTykiMWwQCzjl2cgiyFmpflf3
5lsNSkozP9fGgEvI/ZEn7rnnhOjfP5XF3Q==
X-Google-Smtp-Source: ABdhPJx8KsSxMQluQ676kp3/E5/YtLE4w4Ct6jbp9Jec8i0kQgwWiEQFl3JRlbylAbt2dNnYC5f80w==
X-Received: by 2002:a1c:55ca:: with SMTP id j193mr1181949wmb.58.1621289311959;
Mon, 17 May 2021 15:08:31 -0700 (PDT)
Original-Received: from Philipps-MBP.fritz.box ([46.128.198.100])
by smtp.gmail.com with ESMTPSA id q13sm17387819wrw.56.2021.05.17.15.08.31
for
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 17 May 2021 15:08:31 -0700 (PDT)
Received-SPF: pass client-ip=2a00:1450:4864:20::329;
envelope-from=p.stephani2@gmail.com; helo=mail-wm1-x329.google.com
X-Spam_score_int: -17
X-Spam_score: -1.8
X-Spam_bar: -
X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,
RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
X-BeenThere: bug-gnu-emacs@gnu.org
List-Id: "Bug reports for GNU Emacs,
the Swiss army knife of text editors"
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org
Original-Sender: "bug-gnu-emacs"
Xref: news.gmane.io gmane.emacs.bugs:206748
Archived-At:
Insert the following form into *scratch*:
(defun f (a) (when-let (b (not a)) b))
Edebug-evaluate it using C-u M-C-x.
Now evaluate (f 1). Edebug will not stop at the (not a) form, only the
`a' symbol. The instrumented form is indeed incorrect:
(symbol-function 'f) gives
(closure
(t)
(a)
(edebug-enter 'f
(list a)
#'(lambda nil
(edebug-after
(edebug-before 0)
3
(let*
((b
(and t
(not
(edebug-after 0 1 a)))))
(if b
(edebug-after 0 2 b)
nil))))))
Note the missing edebug-before/after around the `not' form.
This can be rectified by swapping the two `&or' branches in the Edebug
specification for `if-let', which makes sense given the first branch is
often a superset of the second. I don't mind doing that, but maybe
there are negative conseqences from that that I don't see?
In GNU Emacs 28.0.50 (build 120, aarch64-apple-darwin20.4.0, NS appkit-2022.44 Version 11.3.1 (Build 20E241))
of 2021-05-17
Repository revision: f572735c5105a84da3175ae6cdad807fa103dfe1
Repository branch: master
Windowing system distributor 'Apple', version 10.3.2022
System Description: macOS 11.3.1
Configured using:
'configure --with-modules --without-xml2 --without-pop --with-mailutils
--enable-gcc-warnings=warn-only --enable-checking=all
--enable-check-lisp-object-type 'CFLAGS=-ggdb3 -O0''
Configured features:
ACL GNUTLS JSON LCMS2 MODULES NOTIFY KQUEUE NS PDUMPER PNG THREADS
TOOLKIT_SCROLL_BARS ZLIB
Important settings:
value of $LANG: de_DE.UTF-8
locale-coding-system: utf-8-unix
Major mode: Lisp Interaction
Minor modes in effect:
tooltip-mode: t
global-eldoc-mode: t
eldoc-mode: t
electric-indent-mode: t
mouse-wheel-mode: t
tool-bar-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
blink-cursor-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
line-number-mode: t
transient-mark-mode: t
Load-path shadows:
None found.
Features:
(shadow sort mail-extr emacsbug message rmc dired dired-loaddefs rfc822
mml mml-sec epa epg epg-config gnus-util rmail rmail-loaddefs time-date
mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils
mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr
mail-utils phst skeleton derived edmacro kmacro pcase ffap thingatpt url
url-proxy url-privacy url-expand url-methods url-history url-cookie
url-domsuf url-util url-parse auth-source cl-seq eieio eieio-core
cl-macs eieio-loaddefs password-cache json map url-vars mailcap rx
gnutls puny dbus xml subr-x seq byte-opt gv bytecomp byte-compile cconv
compile text-property-search comint ansi-color ring cl-loaddefs cl-lib
iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel term/ns-win ns-win ucs-normalize mule-util
term/common-win tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode elisp-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu
timer select scroll-bar mouse jit-lock font-lock syntax font-core
term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese composite charscript charprop case-table epa-hook
jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button
loaddefs faces cus-face macroexp files window text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote threads kqueue cocoa ns lcms2
multi-tty make-network-process emacs)
Memory information:
((conses 16 70904 5824)
(symbols 48 8362 1)
(strings 32 24249 2101)
(string-bytes 1 793015)
(vectors 16 16050)
(vector-slots 8 212531 11281)
(floats 8 26 28)
(intervals 56 219 0)
(buffers 992 10))