From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Filipp Gunbin Newsgroups: gmane.emacs.bugs Subject: bug#62208: 30.0.50; [PATCH] save-some-buffers repeatedly asks for saving abbrev file Date: Wed, 15 Mar 2023 20:42:31 +0300 Message-ID: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23666"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: 62208@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 15 18:43:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pcV9p-0005s3-Rn for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Mar 2023 18:43:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pcV9U-0001n2-Pj; Wed, 15 Mar 2023 13:43:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pcV9S-0001mb-Qw for bug-gnu-emacs@gnu.org; Wed, 15 Mar 2023 13:43:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pcV9S-0000SO-GE for bug-gnu-emacs@gnu.org; Wed, 15 Mar 2023 13:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pcV9S-0004Te-CX for bug-gnu-emacs@gnu.org; Wed, 15 Mar 2023 13:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Filipp Gunbin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Mar 2023 17:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 62208 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.167890216517185 (code B ref -1); Wed, 15 Mar 2023 17:43:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 15 Mar 2023 17:42:45 +0000 Original-Received: from localhost ([127.0.0.1]:40507 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pcV9B-0004T7-8s for submit@debbugs.gnu.org; Wed, 15 Mar 2023 13:42:45 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:42088) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pcV99-0004Sz-KK for submit@debbugs.gnu.org; Wed, 15 Mar 2023 13:42:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pcV96-0001kV-S7 for bug-gnu-emacs@gnu.org; Wed, 15 Mar 2023 13:42:42 -0400 Original-Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pcV94-0000QB-R0 for bug-gnu-emacs@gnu.org; Wed, 15 Mar 2023 13:42:40 -0400 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id A0849320092E for ; Wed, 15 Mar 2023 13:42:35 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 15 Mar 2023 13:42:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= cc:content-type:content-type:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to; s=fm2; t=1678902155; x=1678988555; bh=n8D0LhuDSPBxTwLmtRZdSLkcD RjXq4pWgBrJgwKCyhA=; b=hKn+QSB05kPN+v7D9SDYb4d9F/ScslfLtYYVetxTC oOc+4cnjkUF5QOyOS/aWsHZHH+EAyQM51swpnk0F6l+nFokEBD7Wjj2BXeF8ip3P F60yITCzXfrwC+sFQVxmVFVLZIPqFNnAoVgCAtyafO4SLJa1OFAX9mdoEOkfFCb2 LjTva4FQF1SlO286mVvmqlTMIxyvkISCIe4t3MGBQRnSRLPZNQx00hXBbDq2ip5t onnL5P80KJTIJNBzsDJzSXaaaQwWnxcoWNnscw1xSfwuM2Bo4Ph95eNH0LwlkqIA iOXw3kxhxFWYTYBW3EswhJQJUfTBiQ4FV7+5R0tJsdMUw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1678902155; x=1678988555; bh=n8D0LhuDSPBxTwLmtRZdSLkcDRjXq4pWgBr JgwKCyhA=; b=TWLXy0L5jMu7BjjEfJJk06Mjm6Bw2jNvGeQH4UDyekDKfzjMOUZ kt1copTKZJGhowbJ/Lbpwg87HuRGshQWccACsLQTrxHu+9eFryg83QMZdGKkxOiv ivdlkx7KIkRpTOFznPjBLVJA1/XFRbU8IhToFoxA7OyGlpU0qIuGgj/Fsmw7ACJF 8uivyIFoULQ6L/BSbkt2+2OEb65dAMx68rkilDquq9fxeVM6un7eoxQVM7kPk9YU xlnELbS9MytkqF2e3Hwv4H9S/xuhrVYaA7yNZ1Ml446T0dwKildnyFBgIfExpQEv WfhVmc47g+jjYTGx1SOVIBF3pmFe8EZP/Pw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvddvkedguddtfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufgffffkgggtsehttdertd dtredtnecuhfhrohhmpefhihhlihhpphcuifhunhgsihhnuceofhhguhhnsghinhesfhgr shhtmhgrihhlrdhfmheqnecuggftrfgrthhtvghrnhepteekgffgjedujeekveehudetff duffejuedtveevfeeuvefgieeiueeuleekuddunecuvehluhhsthgvrhfuihiivgeptden ucfrrghrrghmpehmrghilhhfrhhomhepfhhguhhnsghinhesfhgrshhtmhgrihhlrdhfmh X-ME-Proxy: Feedback-ID: id48c41f1:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Wed, 15 Mar 2023 13:42:34 -0400 (EDT) Mail-Followup-To: bug-gnu-emacs@gnu.org Received-SPF: pass client-ip=64.147.123.24; envelope-from=fgunbin@fastmail.fm; helo=wout1-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257970 Archived-At: - emacs -Q - Define an abbrev using C-x a g - C-x s, answer "yes" - Repeat C-x s, it again asks to save abbrevs This is a regression since 28.1. diff --git a/lisp/abbrev.el b/lisp/abbrev.el index ef8ef1ab5a6..1a665efb0a5 100644 --- a/lisp/abbrev.el +++ b/lisp/abbrev.el @@ -1250,17 +1250,17 @@ abbrev--possibly-save ;; asked to. (and save-abbrevs abbrevs-changed - (progn - (if (or arg - (eq save-abbrevs 'silently) - (y-or-n-p (format "Save abbrevs in %s? " abbrev-file-name))) - (progn - (write-abbrev-file nil) - nil) - ;; Don't keep bothering user if they say no. - (setq abbrevs-changed nil) - ;; Inhibit message in `save-some-buffers'. - t))))) + (prog1 + (if (or arg + (eq save-abbrevs 'silently) + (y-or-n-p (format "Save abbrevs in %s? " abbrev-file-name))) + (progn + (write-abbrev-file nil) + nil) + ;; Inhibit message in `save-some-buffers'. + t) + ;; Don't ask again whether saved or user said no. + (setq abbrevs-changed nil))))) (add-hook 'save-some-buffers-functions #'abbrev--possibly-save) In GNU Emacs 30.0.50 (build 3, x86_64-apple-darwin20.6.0, NS appkit-2202.70 Version 11.7 (Build 20G817)) of 2023-03-15 built on fgunbin.local Repository revision: 67a660eb13818a620b301775065c4819a2178428 Repository branch: master System Description: macOS 11.7