From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Arash Esbati Newsgroups: gmane.emacs.bugs Subject: bug#69187: 29.2; Poor compatibility in align.el Date: Fri, 05 Apr 2024 21:59:06 +0200 Message-ID: References: <55489.1708171413@localhost> <2214.1708282932@localhost> <2125.1712336273@localhost> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34588"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 69187@debbugs.gnu.org To: Ikumi Keita Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 05 22:00:31 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rspjj-0008jw-4r for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Apr 2024 22:00:31 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rspjF-000715-HT; Fri, 05 Apr 2024 16:00:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rspjC-0006zw-3U for bug-gnu-emacs@gnu.org; Fri, 05 Apr 2024 15:59:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rspjB-0001Rz-Pb for bug-gnu-emacs@gnu.org; Fri, 05 Apr 2024 15:59:57 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rspjH-0003cx-Fa for bug-gnu-emacs@gnu.org; Fri, 05 Apr 2024 16:00:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Arash Esbati Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Apr 2024 20:00:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69187 X-GNU-PR-Package: emacs Original-Received: via spool by 69187-submit@debbugs.gnu.org id=B69187.171234718013752 (code B ref 69187); Fri, 05 Apr 2024 20:00:03 +0000 Original-Received: (at 69187) by debbugs.gnu.org; 5 Apr 2024 19:59:40 +0000 Original-Received: from localhost ([127.0.0.1]:37534 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rspit-0003Zj-NU for submit@debbugs.gnu.org; Fri, 05 Apr 2024 15:59:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55950) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rspir-0003ZO-56 for 69187@debbugs.gnu.org; Fri, 05 Apr 2024 15:59:38 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rspid-0001OC-TO; Fri, 05 Apr 2024 15:59:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=qOPxXYMjS5J6JUoAK/7CE/PxC87h/wbarakUHk1OPjY=; b=guH6zZPqg5U9vZruWqWX hvD35BnrTf464vhsIdue/kK9Ncsx/ajsokvNV+MLJcGJF3DHYnzpQf6utIGY908cVtGnOjRQbnuTs k05FPe1gD7RAYGc2aBj6jpfvr64xBcj4PXV0Mexv9ZwTWa0kpj3tqIIit5eG+e9DL8V/l+DHe5kTx EjHFyyGKU8lkTZpO0nduwoux5SstaZILIqtmb4bs0wpEA5XZfvh8LrBF+3oEkDAAeIQkh+BuMHIQI sAV7S7NCrrxzfomWVCA42evwd3AoXM/yGBrhv9B422txbojb27Jz2mTWvvZUmkjrbyw90we7qmE42 1KtlWZhfYvtDfQ==; In-Reply-To: <2125.1712336273@localhost> (Ikumi Keita's message of "Sat, 06 Apr 2024 01:57:53 +0900") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282723 Archived-At: Ikumi Keita writes: > That would practically do the job as well, because this entry wouldn't > be relevant in buffers in modes other than latex (LaTeX) mode > actually. My proposal is just to keep the precise behavior the same. Agreed, so the change would look like this, right? --8<---------------cut here---------------start------------->8--- diff --git a/lisp/align.el b/lisp/align.el index 81ccc4b5e2d..0e77a857585 100644 --- a/lisp/align.el +++ b/lisp/align.el @@ -537,10 +537,8 @@ align-rules-list (regexp . ,(lambda (end reverse) (align-match-tex-pattern "\\\\[=>]" end reverse))) (group . (1 2)) - (modes . align-tex-modes) - (repeat . t) - (run-if . ,(lambda () - (eq major-mode 'latex-mode)))) + (modes . '(latex-mode)) + (repeat . t)) (tex-record-break (regexp . "\\(\\s-*\\)\\\\\\\\") --8<---------------cut here---------------end--------------->8--- @Maintainers: How do you want to proceed with this proposal? Do you like to ask John W., or should I prepare a patch and send/install it, or anything else? For bonus points, I offer to delete the unnecessary ":group 'align" in the defcustom's in align.el. Please advise. Thanks. Best, Arash