unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Arash Esbati <arash@gnu.org>
To: Ikumi Keita <ikumi@ikumi.que.jp>
Cc: 69187@debbugs.gnu.org
Subject: bug#69187: 29.2; Poor compatibility in align.el
Date: Fri, 05 Apr 2024 21:59:06 +0200	[thread overview]
Message-ID: <m2cyr31sz9.fsf@macmutant.fritz.box> (raw)
In-Reply-To: <2125.1712336273@localhost> (Ikumi Keita's message of "Sat, 06 Apr 2024 01:57:53 +0900")

Ikumi Keita <ikumi@ikumi.que.jp> writes:

> That would practically do the job as well, because this entry wouldn't
> be relevant in buffers in modes other than latex (LaTeX) mode
> actually. My proposal is just to keep the precise behavior the same.

Agreed, so the change would look like this, right?

--8<---------------cut here---------------start------------->8---
diff --git a/lisp/align.el b/lisp/align.el
index 81ccc4b5e2d..0e77a857585 100644
--- a/lisp/align.el
+++ b/lisp/align.el
@@ -537,10 +537,8 @@ align-rules-list
      (regexp   . ,(lambda (end reverse)
                     (align-match-tex-pattern "\\\\[=>]" end reverse)))
      (group    . (1 2))
-     (modes    . align-tex-modes)
-     (repeat   . t)
-     (run-if   . ,(lambda ()
-                    (eq major-mode 'latex-mode))))
+     (modes    . '(latex-mode))
+     (repeat   . t))

     (tex-record-break
      (regexp   . "\\(\\s-*\\)\\\\\\\\")
--8<---------------cut here---------------end--------------->8---

@Maintainers: How do you want to proceed with this proposal?  Do you
like to ask John W., or should I prepare a patch and send/install it, or
anything else?

For bonus points, I offer to delete the unnecessary ":group 'align" in
the defcustom's in align.el.

Please advise.  Thanks.

Best, Arash





  reply	other threads:[~2024-04-05 19:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-17 12:03 bug#69187: 29.2; Poor compatibility in align.el Ikumi Keita
2024-02-18 19:02 ` Ikumi Keita
2024-04-03 12:22   ` Arash Esbati
2024-04-05 16:57     ` Ikumi Keita
2024-04-05 19:59       ` Arash Esbati [this message]
2024-04-06  6:21         ` Eli Zaretskii
2024-04-06  9:30           ` Ikumi Keita
2024-04-06 11:03             ` Eli Zaretskii
2024-04-06 20:14               ` Arash Esbati
2024-04-07  5:49                 ` Eli Zaretskii
2024-04-07  8:49                   ` Arash Esbati

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2cyr31sz9.fsf@macmutant.fritz.box \
    --to=arash@gnu.org \
    --cc=69187@debbugs.gnu.org \
    --cc=ikumi@ikumi.que.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).