From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alex Bochannek Newsgroups: gmane.emacs.bugs Subject: bug#73827: [ELPA] [PATCH] register-list fails on "Unprintable entity" registers Date: Tue, 26 Nov 2024 17:39:22 -0800 Message-ID: References: <87mshl7j6m.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19331"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 73827@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 27 02:40:31 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tG72c-0004r0-O4 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 27 Nov 2024 02:40:30 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tG72E-0007ve-2h; Tue, 26 Nov 2024 20:40:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tG72B-0007vE-7n for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2024 20:40:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tG72A-0000Oe-Uh for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2024 20:40:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=+bSxaWNDI36h+sEtUVqGjnq6ke5rSYc/jeD3URNJ3Qs=; b=HEOaKfDqQgzrRpd2jLDzeWswYM91Lab61mOFZtSlKDeBOIAyKwWfes5hvgXdUBN0NguX+bzEDOCmgVU/qXIyyUR1QHumm7gbKmOfDtW98zSxCEOo3LBtCBlp1I3eQb06+InwfzRFOC3dUCnBgEgMgMDgbJdLfYi2iwLTmIxfrl4DIv47RYkHiUZ3zOFDLoK+dw2WvLYt5/q5nrLxINrEw2OWiyBpHCu7U8yDpcjsQD3DZbffZ53pk3dXdfnwR9qboadwuguHZNv4rY2gG+y1x7hiAro6Es8afAOW7N7kM+3NlCYwtpVoxoyPFW9gkz+jzS0iFg2rq+IcPKjsflJGDg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tG72A-0005Uk-Ev for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2024 20:40:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alex Bochannek Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Nov 2024 01:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73827 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73827-submit@debbugs.gnu.org id=B73827.173267157321071 (code B ref 73827); Wed, 27 Nov 2024 01:40:02 +0000 Original-Received: (at 73827) by debbugs.gnu.org; 27 Nov 2024 01:39:33 +0000 Original-Received: from localhost ([127.0.0.1]:55625 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tG71h-0005Tl-32 for submit@debbugs.gnu.org; Tue, 26 Nov 2024 20:39:33 -0500 Original-Received: from ns.lapseofthought.com ([50.0.39.240]:12197 helo=mail.lapseofthought.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tG71c-0005TW-Ah for 73827@debbugs.gnu.org; Tue, 26 Nov 2024 20:39:31 -0500 Original-Received: from awb-mbp-m3.local (c-24-23-131-202.hsd1.ca.comcast.net [24.23.131.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lapseofthought.com (Postfix) with ESMTPSA id 4Xyhtz58Nrz3pn9m; Tue, 26 Nov 2024 17:39:23 -0800 (PST) Authentication-Results: ORIGINATING; auth=pass smtp.auth=alex smtp.mailfrom=alex@bochannek.com In-Reply-To: <87mshl7j6m.fsf@posteo.net> (Philip Kaludercic's message of "Tue, 26 Nov 2024 21:56:49 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296009 Archived-At: Philip Kaludercic writes: > Alex Bochannek writes: > >> --- /Users/awb/.emacs.d/elpa/register-list-0.1/register-list.el.~1~ 2023-01-10 19:36:23 >> +++ /Users/awb/.emacs.d/elpa/register-list-0.1/register-list.el 2024-10-15 15:49:37 >> @@ -483,8 +483,8 @@ >> (t "error")) >> (cond ((window-configuration-p (car key)) "W") >> ((frame-configuration-p (car key)) "F") >> - ((stringp (car key)) "R") >> ((string= "Unprintable entity" (car key)) "?") > > The change confuses me, are we sure that (car key) must be a string at > this point? If not, should be prefer `equal' over `string='? > >> + ((stringp (car key)) "R") The change simply swaps the stringp and string= predicates in the cond. If there is a register with "Unprintable entity" (which desktop.el produces), it would not show up correctly as a "?" (assuming "?" has been added to register-list-default-type). Looking at register-alist in my .emacs.desktop, it is always the string "Unprintable entity" and never a symbol. Whether it's string= or equal shouldn't matter, because the difference in error handling between the two isn't relevant here. Unrelated, I looked into how to get frameset support in register-list and the way framesets are stored in register-alist is very different. I'll submit another patch for that, although it isn't particularly elegant. > You can try out > > M-x package-vc-install register-list RET > > that should give you a checkout. You can then make your changes as > usual and then prepare a patch using vc-prepare-patch or git-format-patch(1). Perfect, thank you! Didn't know about package-vc-install. -- Alex.