From: Robert Pluim <rpluim@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 37221@debbugs.gnu.org, Alex Branham <alex.branham@gmail.com>
Subject: bug#37221: 27.0.50; gnus fails to open connection post-NSM update
Date: Wed, 04 Sep 2019 17:04:37 +0200 [thread overview]
Message-ID: <m2blw0p0fu.fsf@gmail.com> (raw)
In-Reply-To: <87sgpccdk8.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 04 Sep 2019 16:59:35 +0200")
>>>>> On Wed, 04 Sep 2019 16:59:35 +0200, Lars Ingebrigtsen <larsi@gnus.org> said:
Lars> Robert Pluim <rpluim@gmail.com> writes:
>> Iʼve spotted one possible problem: nsm-query runs even when the
>> connection is unencrypted, which ends up doing (insert nil), which
>> aborts the connection. Does the following help? (Lars, why is nsm
>> prompting for unencrypted connections?)
Lars> It runs for all kinds of connections -- a non-encrypted one could, for
Lars> instance, be one that's a result of a downgrade attack.
Lars> So if it now assumes that the connection is always encrypted, that's a
Lars> new bug. Hm... anybody know of a server that absolutely not doesn't
Lars> have STARTTLS that I can test with? :-)
Not quite. nsm-query-user assumes that status is non-nil, which is not
the case in my test, which was imap to localhost. It never gets the
chance to emit STARTTLS, since nsm has already killed the connection:
(defun nsm-query-user (message status)
(let ((buffer (get-buffer-create "*Network Security Manager*"))
(cert-buffer (get-buffer-create "*Certificate Details*"))
(certs (plist-get status :certificates)))
(save-window-excursion
;; First format the certificate and warnings.
(with-current-buffer-window
buffer nil nil
(insert (nsm-format-certificate status)) <= status is nil here,
which gives us "(wrong-type-argument char-or-string-p nil)", which
causes nsm-query to kill the connection.
Robert
next prev parent reply other threads:[~2019-09-04 15:04 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 16:56 bug#37221: 27.0.50; gnus fails to open connection post-NSM update Alex Branham
2019-09-02 9:33 ` Robert Pluim
2019-09-03 18:26 ` Alex Branham
2019-09-03 20:16 ` Robert Pluim
2019-09-04 13:13 ` Alex Branham
2019-09-04 13:37 ` Lars Ingebrigtsen
2019-09-04 14:00 ` Alex Branham
2019-09-04 14:16 ` Lars Ingebrigtsen
2019-09-04 14:24 ` Alex Branham
2019-09-04 14:35 ` Lars Ingebrigtsen
2019-09-04 14:51 ` Alex Branham
2019-09-04 14:56 ` Robert Pluim
2019-09-04 14:59 ` Lars Ingebrigtsen
2019-09-04 15:04 ` Robert Pluim [this message]
2019-09-04 15:04 ` Alex Branham
2019-09-04 15:25 ` Robert Pluim
2019-09-04 15:55 ` Alex Branham
2019-09-04 17:00 ` Robert Pluim
2019-09-04 17:06 ` Lars Ingebrigtsen
2019-09-04 17:21 ` Robert Pluim
2019-09-04 17:24 ` Lars Ingebrigtsen
2019-09-04 19:30 ` Robert Pluim
2019-09-04 19:37 ` Lars Ingebrigtsen
2019-09-04 20:37 ` Robert Pluim
2019-09-04 20:41 ` Lars Ingebrigtsen
2019-09-04 21:49 ` Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2blw0p0fu.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=37221@debbugs.gnu.org \
--cc=alex.branham@gmail.com \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).