From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Filipp Gunbin Newsgroups: gmane.emacs.bugs Subject: bug#51037: [PATCH] Make `print-level` & `print-length` customizable in ERT batch tests Date: Sun, 21 Nov 2021 01:19:28 +0300 Message-ID: References: <86tuhvmtpl.fsf@runbox.com> <83fstd1bth.fsf@gnu.org> <87czogslm4.fsf@gnus.org> <86ily2mjtq.fsf@runbox.com> <87r1cp89o4.fsf@gnus.org> <86fst5m48v.fsf@runbox.com> <87a6jd5891.fsf@gnus.org> <86mtmykxro.fsf@runbox.com> <87y26hz24c.fsf@gnus.org> <86bl3blcgm.fsf@runbox.com> <87wnlya9sj.fsf@gnus.org> <86wnlbmooj.fsf@runbox.com> <87fsry7qdy.fsf@gnus.org> <87bl2m7q9g.fsf@gnus.org> <86zgq5kn9y.fsf@runbox.com> <87ilws7d7e.fsf@gnus.org> <87pmqxlsob.fsf@gnus.org> <86pmqwkw1r.fsf@pobox.com> <86mtlylqm6.fsf@pobox.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23311"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (darwin) Cc: gazally@runbox.com, Lars Ingebrigtsen , 51037@debbugs.gnu.org To: Michael Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 20 23:20:35 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1moYil-0005lo-W5 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 20 Nov 2021 23:20:34 +0100 Original-Received: from localhost ([::1]:35224 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1moYik-0006zP-Oz for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 20 Nov 2021 17:20:30 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:44996) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1moYiI-0006wL-Fn for bug-gnu-emacs@gnu.org; Sat, 20 Nov 2021 17:20:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60497) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1moYiI-00055Z-6O for bug-gnu-emacs@gnu.org; Sat, 20 Nov 2021 17:20:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1moYiH-0004H4-VH for bug-gnu-emacs@gnu.org; Sat, 20 Nov 2021 17:20:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Filipp Gunbin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 20 Nov 2021 22:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51037 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51037-submit@debbugs.gnu.org id=B51037.163744678016386 (code B ref 51037); Sat, 20 Nov 2021 22:20:01 +0000 Original-Received: (at 51037) by debbugs.gnu.org; 20 Nov 2021 22:19:40 +0000 Original-Received: from localhost ([127.0.0.1]:43810 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moYhw-0004GD-4M for submit@debbugs.gnu.org; Sat, 20 Nov 2021 17:19:40 -0500 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]:33851) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moYhs-0004Fy-GD for 51037@debbugs.gnu.org; Sat, 20 Nov 2021 17:19:38 -0500 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 66D965C00CD; Sat, 20 Nov 2021 17:19:31 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sat, 20 Nov 2021 17:19:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=dT13oeacRFmBrTW6HqXF/OCTfr LXWpYECde9Jaa6Xfs=; b=crxPAx9+LgdCjAN+deOFEhHWL+XcGhQnaEwSOdU2Or JLh9cjIRZZkaj7rw5qRt5zg4VlTDzNPIkeVb1KQfRGEJWNkWDyGP9rHJXMHLRMLX XU0MwMmEfGlTuERt5Rojuj2zAiFCj/kC5eVJA93bhbxlCAcoOjVR2A6/oyvITXBe +1lRv+Tl0uuc34ZWM8Q8JF6nSj/CcQ9PQYa6VD6UuwNW5VkBBxojH+BUeNy1acOA kdkkeNSdeH2nL2shRMtp2KxEOt0KXU/RDI+lHrKRpV5H+oSnEywsYOVY0ca7c9NC OsOoQ2YhpIZoDOgOiM4Ez2Sj1ezlUDuFOQ49JY0mV8XQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=dT13oe acRFmBrTW6HqXF/OCTfrLXWpYECde9Jaa6Xfs=; b=kEgmwG1AaUsdRvkC5zXK7X PO1jUJI8UuJlxHkFxFQLylAUB+w3eYy54AzPImWPU09Z+EdAc6uFt8rZcq/GfEJp 3jMKqgyvzB5fFFbDCA3BRT0JGOCrFJp4eCySd22elMZce6VFJlvuPFEiufkt56ub oTjhAMkHL77kRWKYV5RvGy57IWl/EFgR0nICPyh2NojoXMf0OemnRr4yFaOf5nkT SbSPfLT8b5VVfNgRb4RNUKsOLAhvy8vUVL/bQDgLNLmuFgFzledgyoH1I+T2u1zh QvqYrkvfTB/88cuawo+L/csJU/LQmvkYh1uzstilnm7MYu0DlDWXk8ziZcBSXgZw == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrgedtgdduiedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhgffffkgggtsehttdertddtredtnecuhfhrohhmpefhihhlihhp phcuifhunhgsihhnuceofhhguhhnsghinhesfhgrshhtmhgrihhlrdhfmheqnecuggftrf grthhtvghrnheptdffhefgffejtddvvdehueetheeiheegudeghffgueetgfdvfeeuudfh feduveeinecuffhomhgrihhnpehgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepfhhguhhnsghinhesfhgrshhtmhgrihhlrdhf mh X-ME-Proxy: Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 20 Nov 2021 17:19:29 -0500 (EST) In-Reply-To: <86mtlylqm6.fsf@pobox.com> (Michael's message of "Sat, 20 Nov 2021 08:49:05 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220524 Archived-At: On 20/11/2021 08:49 -0800, Michael wrote: >> On 19/11/2021 07:24 -0800, Michael wrote: >> >>> Lars Ingebrigtsen writes: >>> >>>> Filipp Gunbin writes: >>>> >>>>> The docstring for backtrace-line-length says: "If set to nil >>>>> or >>>>> zero, >>>>> backtrace mode will not abbreviate the forms it prints." So >>>>> the >>>>> above >>>>> sentence, which I removed, was indeed not true? (a quick >>>>> look over >>>>> its usages confirmed that to me, but I'd like someone else to >>>>> check) >>>> >>>> I think the intention is that a nil value of >>>> backtrace-line-length >>>> shouldn't limit the lengths -- but I haven't tested it. >>>> Doesn't it >>>> work? >>> >>> Yes, I'm a bit lost, Filipp... what is your concern? And I >>> thought I *had* tested that. >> >> That the docstring contained a sentence which is not true. A >> minor >> issue, of course. I give examples here: >> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=51037#117 >> >> (there was also fix of interactive spec of >> `ert-run-tests-interactively', >> but that's obvious I think) >> > Hey Filipp, > > Note that _is_ true, as far as I know, and was intended to be > true before my patch, and I verified that it became true with my > patch :) Can you provide a test case that demonstrates it to be > not true? Yes, here https://debbugs.gnu.org/cgi/bugreport.cgi?bug=51037#117, as I wrote above..