unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Daniel Pettersson <daniel@dpettersson.net>
To: "João Távora" <joaotavora@gmail.com>
Cc: 69241@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
Subject: bug#69241: Fixed patch issues
Date: Sun, 10 Mar 2024 15:28:21 +0100	[thread overview]
Message-ID: <m2bk7mjh4q.fsf@dpettersson.net> (raw)
In-Reply-To: <CALDnm52i7X1SNp8WKbM5da7rNF_xrO1DtAO3hA9pyn_zaXtmyg@mail.gmail.com> ("João Távora"'s message of "Sat, 9 Mar 2024 10:56:22 +0000")

João Távora <joaotavora@gmail.com> writes:

> From where I stand, Daniel Pettersson is the new Jsonrpc maintainer.  I'd give
> him push rights so he can install this and push any follow-up fixes easily.

As I have previously stated I am willing to take on the maintainer role
for Jsonrpc.  

> +           ;; `timer-activate' orders timers by time, which is an
> +           ;; very expensive operation when jsonrpc-mqueue is large,
> +           ;; therefore the time object is reused for each timer
> +           ;; created.

I am interested in what both of you think about relying on undocumented
behavior.

To grasp the scope of this issue, an adapter server sent 50 000
messages. With `read-process-output-max' set to the platforms max, each
of those messages where placed on `timer-list' in the same call to
jsonrpc's filter function, which then had to be sorted as O(N^2)
(calls to timer--time-less-p). 

Which makes Jsonrpc unusable for that particular server.





  reply	other threads:[~2024-03-10 14:28 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-18  1:53 bug#69241: [PATCH] Jsonrpc: improve performance of process filter function Daniel Pettersson
2024-02-28 12:22 ` bug#69241: Fixed patch issues Daniel Pettersson
2024-03-09  8:55   ` Eli Zaretskii
2024-03-09  8:56   ` Eli Zaretskii
2024-03-09 10:56     ` João Távora
2024-03-10 14:28       ` Daniel Pettersson [this message]
2024-03-10 14:41         ` João Távora
2024-03-11  9:44           ` Daniel Pettersson
2024-03-11 13:11             ` Eli Zaretskii
2024-03-11 14:48               ` Daniel Pettersson
2024-03-11 16:27                 ` Eli Zaretskii
2024-03-11 19:03                   ` Daniel Pettersson
2024-03-11 19:18                     ` Eli Zaretskii
2024-03-11 19:39                       ` Daniel Pettersson
2024-03-12  3:27                         ` Eli Zaretskii
2024-03-12 13:31                           ` Eli Zaretskii
2024-03-12 14:34                             ` Daniel Pettersson
2024-03-12 15:00                               ` Eli Zaretskii
2024-03-12 13:28                         ` Eli Zaretskii
2024-03-12 14:33                           ` Daniel Pettersson
2024-03-10 16:46         ` Eli Zaretskii
2024-03-10 20:05           ` Daniel Pettersson
2024-03-10 23:30             ` Daniel Pettersson
2024-03-11 12:24             ` Eli Zaretskii
2024-03-11 12:38               ` Daniel Pettersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2bk7mjh4q.fsf@dpettersson.net \
    --to=daniel@dpettersson.net \
    --cc=69241@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=joaotavora@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).