unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo <sdl.web@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 12051@debbugs.gnu.org
Subject: bug#12051: 24.1; rcirc-send-message doesn't take multibyte into account.
Date: Thu, 16 Aug 2012 11:16:04 +0800	[thread overview]
Message-ID: <m2a9xvle6j.fsf@gmail.com> (raw)
In-Reply-To: <83d32rv9bn.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 16 Aug 2012 05:50:52 +0300")

On 2012-08-16 10:50 +0800, Eli Zaretskii wrote:
>> By worst expansion, do you mean assuming each char to be 5 bytes?
>
> Yes.

The will split English text at the boundary of 84 chars which seems
sub-optimal.

In the current implementation of rcirc-split-message, the inner loop
might not be run if the encoding is utf-8, which we can assume to be 90%
of the cases. So my suggestion is to leave it alone until we hit a real
case of inefficiency. What do you think?

Leo





  reply	other threads:[~2012-08-16  3:16 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-25 16:18 bug#12051: 24.1; rcirc-send-message doesn't take multibyte into account Li Ian-Xue
2012-08-13  1:53 ` Leo
2012-08-14 13:11   ` Leo
2012-08-14 15:45   ` Eli Zaretskii
     [not found]     ` <874no4apau.fsf@acerpad.localdomain>
2012-08-15  2:57       ` Eli Zaretskii
2012-08-15 13:10         ` Leo
2012-08-15 13:29           ` Chong Yidong
2012-08-15 15:45             ` Chong Yidong
2012-08-15 22:55               ` Leo
2012-08-15 16:59           ` Eli Zaretskii
2012-08-15 17:53             ` Li Ian-Xue
2012-08-15 22:54               ` Leo
2012-08-15 23:00             ` Leo
2012-08-16  2:50               ` Eli Zaretskii
2012-08-16  3:16                 ` Leo [this message]
2012-08-16 15:20                   ` Eli Zaretskii
2012-08-16 17:17                     ` Leo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2a9xvle6j.fsf@gmail.com \
    --to=sdl.web@gmail.com \
    --cc=12051@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).