* bug#18496: 24.4.50; RefTeX modes should use font-lock-face instead of face
@ 2014-09-18 9:32 Sebastian Wiesner
2014-09-21 9:36 ` Tassilo Horn
0 siblings, 1 reply; 2+ messages in thread
From: Sebastian Wiesner @ 2014-09-18 9:32 UTC (permalink / raw)
To: 18496
The following RefTeX modes should use the font-lock-face text property
instead of face:
- reftex-toc-mode
- reftex-select-label-mode
- reftex-select-bib-mode
Using face directly breaks fontification if special minor modes are
enabled that add extra fontification.
Originally reported for rainbow-delimiters, see
https://github.com/jlr/rainbow-delimiters/issues/31 and
https://github.com/jlr/rainbow-delimiters/pull/38
On a related note, it seems as if these modes should probably inherit
special-mode, shouldn't they?
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#18496: 24.4.50; RefTeX modes should use font-lock-face instead of face
2014-09-18 9:32 bug#18496: 24.4.50; RefTeX modes should use font-lock-face instead of face Sebastian Wiesner
@ 2014-09-21 9:36 ` Tassilo Horn
0 siblings, 0 replies; 2+ messages in thread
From: Tassilo Horn @ 2014-09-21 9:36 UTC (permalink / raw)
To: Sebastian Wiesner; +Cc: 18496-done
Sebastian Wiesner <swiesner@lunaryorn.com> writes:
> The following RefTeX modes should use the font-lock-face text property
> instead of face:
>
> - reftex-toc-mode
> - reftex-select-label-mode
> - reftex-select-bib-mode
>
> Using face directly breaks fontification if special minor modes are
> enabled that add extra fontification.
Indeed, thanks for the hint.
> On a related note, it seems as if these modes should probably inherit
> special-mode, shouldn't they?
Yes, right.
I've done both in revision 117907.
Thanks,
Tassilo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-21 9:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-18 9:32 bug#18496: 24.4.50; RefTeX modes should use font-lock-face instead of face Sebastian Wiesner
2014-09-21 9:36 ` Tassilo Horn
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).