* bug#21968: Apparent regression on the undo command [not found] ` <CAAdUY-K9zZn4oLhiz6mBf3KBcCH9kEz0H=uNr5C-3svpwst-zA@mail.gmail.com> @ 2015-11-22 0:55 ` David Reitter [not found] ` <1512E415-81ED-4C4D-B03E-4ED0EE29D34C@gmail.com> 1 sibling, 0 replies; 10+ messages in thread From: David Reitter @ 2015-11-22 0:55 UTC (permalink / raw) To: Phillip Lord; +Cc: 21968, emacs-devel Phil, I tried your fix. It works for backward-kill-word, but for kill-word (forward), the cursor ends up in the wrong place (after the word, not where it was initially). - David > On Nov 21, 2015, at 6:18 AM, Artur Malabarba <bruce.connor.am@gmail.com> wrote: > > I can't speak for the code, but I just tested your fix and looks like it works. > > Thanks Phil. > > 2015-11-21 10:02 GMT+00:00 Phillip Lord <phillip.lord@russet.org.uk>: > > I have a possible fix for this now, currently on the > branch fix/undo-point-in-wrong-place. I waiting for some other feedback > on my code before I squash and merge it, but if you have the chance it > would be good to know if it works. > > Phil > > > Artur Malabarba <bruce.connor.am@gmail.com> writes: > > > No problem Phil. > > Thanks for looking into this. > > On 20 Nov 2015 7:51 am, "Phillip Lord" <phillip.lord@newcastle.ac.uk> wrote: > > > >> > >> It is my commit after all. I will work on it as soon as I can. Had a nasty > >> cold for the last few days. > >> > >> Phil > >> ________________________________________ > >> From: emacs-devel-bounces+phillip.lord=newcastle.ac.uk@gnu.org > >> [emacs-devel-bounces+phillip.lord=newcastle.ac.uk@gnu.org] on behalf of > >> Karl Fogel [kfogel@red-bean.com] > >> Sent: 20 November 2015 01:24 > >> To: Phillip Lord > >> Cc: Artur Malabarba; emacs-devel > >> Subject: Re: Apparent regression on the undo command > >> > >> phillip.lord@russet.org.uk (Phillip Lord) writes: > >> >Artur Malabarba <bruce.connor.am@gmail.com> writes: > >> >> 2015-11-19 9:47 GMT+00:00 Phillip Lord <phillip.lord@russet.org.uk>: > >> >>> I'll try and see if I can automate the problem and > >> >>> run a bisect. > >> >> > >> >> The following works for me. When called on the *scratch* buffer it > >> >> returns non-nil if the problem occurs. > >> >> > >> >> (progn > >> >> (kmacro-call-macro nil nil nil [134217788 11 14 14 11 67108911]) > >> >> (equal (point-min) (point))) > >> >> > >> >> That macro simply calls M-< C-k C-n C-n C-k C-/ > >> > > >> > > >> >I tried various combinations -- works interactively but fails in batch > >> >either because *scratch* hasn't been initialized, or undo appears to > >> >work wrongly. > >> > > >> >No worries, it's easy enough to test by hand, and am doing so. > >> > >> Any luck? FWIW I'm noticing the bug too, in emacs-25 branch built from > >> commit c210b8b128c. > >> > >> Best regards, > >> -Karl > >> > >> > ^ permalink raw reply [flat|nested] 10+ messages in thread
[parent not found: <1512E415-81ED-4C4D-B03E-4ED0EE29D34C@gmail.com>]
* bug#21968: Apparent regression on the undo command [not found] ` <1512E415-81ED-4C4D-B03E-4ED0EE29D34C@gmail.com> @ 2015-11-23 17:27 ` Phillip Lord [not found] ` <87wpt8aanq.fsf@russet.org.uk> 1 sibling, 0 replies; 10+ messages in thread From: Phillip Lord @ 2015-11-23 17:27 UTC (permalink / raw) To: David Reitter; +Cc: 21968, emacs-devel Okay, am working on this now! David Reitter <david.reitter@gmail.com> writes: > Phil, > > I tried your fix. It works for backward-kill-word, but for kill-word > (forward), the cursor ends up in the wrong place (after the word, not where it > was initially). > > - David > > >> On Nov 21, 2015, at 6:18 AM, Artur Malabarba <bruce.connor.am@gmail.com> wrote: >> >> I can't speak for the code, but I just tested your fix and looks like it works. >> >> Thanks Phil. >> >> 2015-11-21 10:02 GMT+00:00 Phillip Lord <phillip.lord@russet.org.uk>: >> >> I have a possible fix for this now, currently on the >> branch fix/undo-point-in-wrong-place. I waiting for some other feedback >> on my code before I squash and merge it, but if you have the chance it >> would be good to know if it works. >> >> Phil >> >> >> Artur Malabarba <bruce.connor.am@gmail.com> writes: >> >> > No problem Phil. >> > Thanks for looking into this. >> > On 20 Nov 2015 7:51 am, "Phillip Lord" <phillip.lord@newcastle.ac.uk> wrote: >> > >> >> >> >> It is my commit after all. I will work on it as soon as I can. Had a nasty >> >> cold for the last few days. >> >> >> >> Phil >> >> ________________________________________ >> >> From: emacs-devel-bounces+phillip.lord=newcastle.ac.uk@gnu.org >> >> [emacs-devel-bounces+phillip.lord=newcastle.ac.uk@gnu.org] on behalf of >> >> Karl Fogel [kfogel@red-bean.com] >> >> Sent: 20 November 2015 01:24 >> >> To: Phillip Lord >> >> Cc: Artur Malabarba; emacs-devel >> >> Subject: Re: Apparent regression on the undo command >> >> >> >> phillip.lord@russet.org.uk (Phillip Lord) writes: >> >> >Artur Malabarba <bruce.connor.am@gmail.com> writes: >> >> >> 2015-11-19 9:47 GMT+00:00 Phillip Lord <phillip.lord@russet.org.uk>: >> >> >>> I'll try and see if I can automate the problem and >> >> >>> run a bisect. >> >> >> >> >> >> The following works for me. When called on the *scratch* buffer it >> >> >> returns non-nil if the problem occurs. >> >> >> >> >> >> (progn >> >> >> (kmacro-call-macro nil nil nil [134217788 11 14 14 11 67108911]) >> >> >> (equal (point-min) (point))) >> >> >> >> >> >> That macro simply calls M-< C-k C-n C-n C-k C-/ >> >> > >> >> > >> >> >I tried various combinations -- works interactively but fails in batch >> >> >either because *scratch* hasn't been initialized, or undo appears to >> >> >work wrongly. >> >> > >> >> >No worries, it's easy enough to test by hand, and am doing so. >> >> >> >> Any luck? FWIW I'm noticing the bug too, in emacs-25 branch built from >> >> commit c210b8b128c. >> >> >> >> Best regards, >> >> -Karl >> >> >> >> >> ^ permalink raw reply [flat|nested] 10+ messages in thread
[parent not found: <87wpt8aanq.fsf@russet.org.uk>]
* bug#21968: Apparent regression on the undo command [not found] ` <87wpt8aanq.fsf@russet.org.uk> @ 2015-12-14 20:04 ` John Wiegley 2015-12-14 20:09 ` Eli Zaretskii 0 siblings, 1 reply; 10+ messages in thread From: John Wiegley @ 2015-12-14 20:04 UTC (permalink / raw) To: Phillip Lord; +Cc: David Reitter, 21968 >>>>> Phillip Lord <phillip.lord@russet.org.uk> writes: > Okay, am working on this now! Hi Phil, I just built emacs-25, but most actions that I take give me errors like the following: Symbol’s function definition is void: undo-auto-amalgamate Have I omitted to do something? -- John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2 ^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#21968: Apparent regression on the undo command 2015-12-14 20:04 ` John Wiegley @ 2015-12-14 20:09 ` Eli Zaretskii 2015-12-14 21:28 ` Phillip Lord 0 siblings, 1 reply; 10+ messages in thread From: Eli Zaretskii @ 2015-12-14 20:09 UTC (permalink / raw) To: John Wiegley; +Cc: david.reitter, phillip.lord, 21968 > From: John Wiegley <jwiegley@gmail.com> > Date: Mon, 14 Dec 2015 12:04:59 -0800 > Cc: David Reitter <david.reitter@gmail.com>, 21968@debbugs.gnu.org > > I just built emacs-25, but most actions that I take give me errors like the > following: > > Symbol’s function definition is void: undo-auto-amalgamate > > Have I omitted to do something? I don't know, but that function is in simple.el. Did you build in a clean directory? ^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#21968: Apparent regression on the undo command 2015-12-14 20:09 ` Eli Zaretskii @ 2015-12-14 21:28 ` Phillip Lord 2015-12-14 22:05 ` John Wiegley 0 siblings, 1 reply; 10+ messages in thread From: Phillip Lord @ 2015-12-14 21:28 UTC (permalink / raw) To: Eli Zaretskii; +Cc: John Wiegley, david.reitter, 21968 Eli Zaretskii <eliz@gnu.org> writes: >> From: John Wiegley <jwiegley@gmail.com> >> Date: Mon, 14 Dec 2015 12:04:59 -0800 >> Cc: David Reitter <david.reitter@gmail.com>, 21968@debbugs.gnu.org >> >> I just built emacs-25, but most actions that I take give me errors like the >> following: >> >> Symbol’s function definition is void: undo-auto-amalgamate >> >> Have I omitted to do something? > > I don't know, but that function is in simple.el. Did you build in a > clean directory? I'd suspect a clean build here, also. I introduced undo-auto-amalgamate in eaa1fd6d. Phil ^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#21968: Apparent regression on the undo command 2015-12-14 21:28 ` Phillip Lord @ 2015-12-14 22:05 ` John Wiegley 2015-12-14 22:30 ` Phillip Lord 0 siblings, 1 reply; 10+ messages in thread From: John Wiegley @ 2015-12-14 22:05 UTC (permalink / raw) To: Phillip Lord; +Cc: John Wiegley, david.reitter, 21968 >>>>> Phillip Lord <phillip.lord@russet.org.uk> writes: >> I don't know, but that function is in simple.el. Did you build in a >> clean directory? > I'd suspect a clean build here, also. I introduced undo-auto-amalgamate in > eaa1fd6d. Hmm.. I'm building with Nix, which should by definition mean always having a clean environment. I'll look into it further. Thanks, -- John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2 ^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#21968: Apparent regression on the undo command 2015-12-14 22:05 ` John Wiegley @ 2015-12-14 22:30 ` Phillip Lord 2015-12-14 22:34 ` John Wiegley 0 siblings, 1 reply; 10+ messages in thread From: Phillip Lord @ 2015-12-14 22:30 UTC (permalink / raw) To: John Wiegley; +Cc: david.reitter, 21968 John Wiegley <jwiegley@gmail.com> writes: >>>>>> Phillip Lord <phillip.lord@russet.org.uk> writes: > >>> I don't know, but that function is in simple.el. Did you build in a >>> clean directory? > >> I'd suspect a clean build here, also. I introduced undo-auto-amalgamate in >> eaa1fd6d. > > Hmm.. I'm building with Nix, which should by definition mean always having a > clean environment. I'll look into it further. My guess would be that the src directory has build, but simple.elc was not. Never used nix, am afraid. Phil ^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#21968: Apparent regression on the undo command 2015-12-14 22:30 ` Phillip Lord @ 2015-12-14 22:34 ` John Wiegley 2015-12-15 9:31 ` Phillip Lord 0 siblings, 1 reply; 10+ messages in thread From: John Wiegley @ 2015-12-14 22:34 UTC (permalink / raw) To: Phillip Lord; +Cc: david.reitter, 21968 >>>>> Phillip Lord <phillip.lord@russet.org.uk> writes: > My guess would be that the src directory has build, but simple.elc was not. > Never used nix, am afraid. I can confirm after installation that the source file had the function defined in it, but the compiled version did not. I've changed the Nix build expression to explicitly remove all .elc files, to force a clean rebuild each time. It's going much more slowly now, which is heartening. -- John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2 ^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#21968: Apparent regression on the undo command 2015-12-14 22:34 ` John Wiegley @ 2015-12-15 9:31 ` Phillip Lord 2015-12-15 15:06 ` John Wiegley 0 siblings, 1 reply; 10+ messages in thread From: Phillip Lord @ 2015-12-15 9:31 UTC (permalink / raw) To: John Wiegley; +Cc: david.reitter, 21968 John Wiegley <jwiegley@gmail.com> writes: >>>>>> Phillip Lord <phillip.lord@russet.org.uk> writes: > >> My guess would be that the src directory has build, but simple.elc was not. >> Never used nix, am afraid. > > I can confirm after installation that the source file had the function defined > in it, but the compiled version did not. I've changed the Nix build expression > to explicitly remove all .elc files, to force a clean rebuild each time. It's > going much more slowly now, which is heartening. Well there is a turn up -- someone who is happy that the build is getting slower! I think that this issue is probably complete now. Anyone know how to close it? Phil ^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#21968: Apparent regression on the undo command 2015-12-15 9:31 ` Phillip Lord @ 2015-12-15 15:06 ` John Wiegley 0 siblings, 0 replies; 10+ messages in thread From: John Wiegley @ 2015-12-15 15:06 UTC (permalink / raw) To: Phillip Lord; +Cc: david.reitter, 21968-done >>>>> Phillip Lord <phillip.lord@russet.org.uk> writes: > I think that this issue is probably complete now. Anyone know how to close > it? Closed (by appending "-done" to the bug id in the e-mail addr). -- John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2 ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2015-12-15 15:06 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CAAdUY-+B790iq3u-zZfya9ogTK913XWXf+z+-azkaD3fRCgdJA@mail.gmail.com>
[not found] ` <87bnarsdfy.fsf@russet.org.uk>
[not found] ` <CAAdUY-LyuGzhFDjd5+Q7L-MTWLjDMgt=Fd6V74A1R5RuQGFNcA@mail.gmail.com>
[not found] ` <871tbm9v83.fsf@russet.org.uk>
[not found] ` <CAAdUY-JWg6jXpXrj++KMW7Bb-g4zMaN1TAjCJDrfZVvfXSXZzQ@mail.gmail.com>
[not found] ` <87wpte6slz.fsf@russet.org.uk>
[not found] ` <87io4xpio3.fsf@red-bean.com>
[not found] ` <DBXPR07MB33495C9B6B977F2B5A7861BC51A0@DBXPR07MB334.eurprd07.prod.outlook.com>
[not found] ` <CAAdUY-+qC4kBUN9rSiH8cOC16E6WjWvPmBC5AL-HeoiDq6FQLQ@mail.gmail.com>
[not found] ` <87y4drllg8.fsf@russet.org.uk>
[not found] ` <CAAdUY-K9zZn4oLhiz6mBf3KBcCH9kEz0H=uNr5C-3svpwst-zA@mail.gmail.com>
2015-11-22 0:55 ` bug#21968: Apparent regression on the undo command David Reitter
[not found] ` <1512E415-81ED-4C4D-B03E-4ED0EE29D34C@gmail.com>
2015-11-23 17:27 ` Phillip Lord
[not found] ` <87wpt8aanq.fsf@russet.org.uk>
2015-12-14 20:04 ` John Wiegley
2015-12-14 20:09 ` Eli Zaretskii
2015-12-14 21:28 ` Phillip Lord
2015-12-14 22:05 ` John Wiegley
2015-12-14 22:30 ` Phillip Lord
2015-12-14 22:34 ` John Wiegley
2015-12-15 9:31 ` Phillip Lord
2015-12-15 15:06 ` John Wiegley
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).