From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#30309: Surprising behaviour of insert-kbd-macro Date: Fri, 30 Nov 2018 09:36:43 +0100 Message-ID: References: <87inbit2nm.fsf@gmail.com> <87vafbdj6i.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1543567553 7900 195.159.176.226 (30 Nov 2018 08:45:53 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 30 Nov 2018 08:45:53 +0000 (UTC) Cc: 30309@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 30 09:45:49 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gSeQl-0001vU-VB for geb-bug-gnu-emacs@m.gmane.org; Fri, 30 Nov 2018 09:45:48 +0100 Original-Received: from localhost ([::1]:58705 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gSeSp-0003To-R3 for geb-bug-gnu-emacs@m.gmane.org; Fri, 30 Nov 2018 03:47:58 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51004) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gSePU-0000r1-BU for bug-gnu-emacs@gnu.org; Fri, 30 Nov 2018 03:44:31 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gSeII-00072O-Eu for bug-gnu-emacs@gnu.org; Fri, 30 Nov 2018 03:37:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51239) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gSeII-00072K-B4 for bug-gnu-emacs@gnu.org; Fri, 30 Nov 2018 03:37:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gSeII-0000H8-0A for bug-gnu-emacs@gnu.org; Fri, 30 Nov 2018 03:37:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Nov 2018 08:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30309 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed easy Original-Received: via spool by 30309-submit@debbugs.gnu.org id=B30309.15435670151044 (code B ref 30309); Fri, 30 Nov 2018 08:37:01 +0000 Original-Received: (at 30309) by debbugs.gnu.org; 30 Nov 2018 08:36:55 +0000 Original-Received: from localhost ([127.0.0.1]:55497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gSeIB-0000Gm-9q for submit@debbugs.gnu.org; Fri, 30 Nov 2018 03:36:55 -0500 Original-Received: from mail-wr1-f48.google.com ([209.85.221.48]:39614) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gSeI9-0000GX-AS for 30309@debbugs.gnu.org; Fri, 30 Nov 2018 03:36:53 -0500 Original-Received: by mail-wr1-f48.google.com with SMTP id t27so4417725wra.6 for <30309@debbugs.gnu.org>; Fri, 30 Nov 2018 00:36:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-copies-to:gmane-reply-to-list :date:in-reply-to:message-id:mime-version; bh=EUCD2uh5UEh+EqR57IK9NunpFxSkTmir9xsbplhPEfA=; b=gTDqaJj+BihEFR5kjUZ84wV151OB3TaNCCMtGX2mJXnwhvUWUxY0J/biixKChMoInv jTvQFO/+Altr0xIKGGz02JUJYMirGD2qdbZKsV4iDvo0/x2lsjuLbIqBkH9Zn57l7MU1 vk8AhjG/x2r0oHPEvbR3wD8rYWb+4JkdzGWKh6xdTJ+D0vwUYJ1enmCNooCtqMr/elXo 3JCrQ8tFG8hxFZbV0hPO/DTKXDXA+VOQsTMObvKstuoGHQcFiQJp8okMXxdvP6oO89Jx 4uoaPltRgWlkhn/Dl/MBlSYIAL5AvDOHy5MagBAVFMiUG6EKoxDD0oblIzaUNoQwbsXk 2BxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version; bh=EUCD2uh5UEh+EqR57IK9NunpFxSkTmir9xsbplhPEfA=; b=sEL2mp1XQuW63s4O5ERCOUpa1eFr9ACwGeHnifYywZ7jC1l4BNyarY4JRQZpINx8Hu +PadBilZ3VmowPvnREF4M8tEZp4QoZxVUJIMIkmuQKO6IYkJYf1Mlc6L0PPF3U/g7vik b9/bGOFgIx0vCRmMlr5+gBg61WtfIdJW2FoTUC66gqUxlqJ4t8udVDhlOulL8qM01IlS jXJC+ZRGDMWTwQFTqxmdr1eSvVHMYrpVWZIAXucB427jEa2PRYzPFqAPSwjJPnCjevjz Ynp9FLmy8um4Q/RtMpXNgrKt2N0DRR+RE9MGXi28bk45o7PBMv97lg6uzN/1OExkiF6p ENzA== X-Gm-Message-State: AA+aEWYtyIJ1XT+cQY5IP7vyPxPeKSrZW5orG5qGFRQlKbwGrhLo9vsx YVLtAwaSwkL0WZ2Vdb8+QhFel2RKWYI= X-Google-Smtp-Source: AFSGD/V+Qiu5JoMe4MbeEmTAt6MJQXcHC/OAC0UPf/Kh/3kPU0wajAAMYqa9GRTbopFs6nu7HT6H7w== X-Received: by 2002:a5d:5443:: with SMTP id w3mr3825850wrv.4.1543567007079; Fri, 30 Nov 2018 00:36:47 -0800 (PST) Original-Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id y34sm10251870wrd.68.2018.11.30.00.36.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 30 Nov 2018 00:36:46 -0800 (PST) Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: <87vafbdj6i.fsf@users.sourceforge.net> (Noam Postavsky's message of "Mon, 05 Feb 2018 20:02:29 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152926 Archived-At: Noam Postavsky writes: > tags 30309 + confirmed easy > retitle 30309 C-u M-x insert-kbd-macro RET RET inserts many unrelated "bindings" (menu separators?) > quit > > Robert Pluim writes: > >> #emacs-26 >> emacs -Q >> C-u M-x insert-kbd-macro RET RET >> => >> (setq last-kbd-macro >> nil) >> (global-set-key [C-down-mouse-2 s2] 'last-kbd-macro) >> (global-set-key [C-down-mouse-2 s1] 'last-kbd-macro) >> (global-set-key [menu-bar help-menu sep1] 'last-kbd-macro) > [...] > > Yeah, I guess no keybindings should be inserted in that case. So I guess just checking for last-kbd-macro should be enough, since that should never have a legitimate key binding. diff --git i/lisp/macros.el w/lisp/macros.el index 4078b983ec..53a688a367 100644 --- i/lisp/macros.el +++ w/lisp/macros.el @@ -125,7 +125,7 @@ insert-kbd-macro ;; (kmacro-create [] 0 "%d"). (prin1 definition (current-buffer)))) (insert ")\n") - (if keys + (and keys (not (eq macroname 'last-kbd-macro)) (let ((keys (or (where-is-internal (symbol-function macroname) '(keymap)) (where-is-internal macroname '(keymap)))))