From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#35062: [PATCH 0/4] Trivial code cleanups Date: Mon, 01 Apr 2019 15:43:37 +0200 Message-ID: References: <1554071761.31929.0@yandex.ru> <20190331223742.1351-1-Hi-Angel@yandex.ru> <83d0m6gx30.fsf@gnu.org> <1554125750.2712.1@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="176803"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35062@debbugs.gnu.org To: Konstantin Kharlamov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 01 15:44:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hAxEW-000jtf-M4 for geb-bug-gnu-emacs@m.gmane.org; Mon, 01 Apr 2019 15:44:16 +0200 Original-Received: from localhost ([127.0.0.1]:54461 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hAxEV-00040W-G5 for geb-bug-gnu-emacs@m.gmane.org; Mon, 01 Apr 2019 09:44:15 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40305) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hAxEL-0003zV-N5 for bug-gnu-emacs@gnu.org; Mon, 01 Apr 2019 09:44:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hAxEJ-0008DB-Jq for bug-gnu-emacs@gnu.org; Mon, 01 Apr 2019 09:44:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53647) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hAxEI-0008CO-Im for bug-gnu-emacs@gnu.org; Mon, 01 Apr 2019 09:44:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hAxEH-0007sY-VW for bug-gnu-emacs@gnu.org; Mon, 01 Apr 2019 09:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 Apr 2019 13:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35062 X-GNU-PR-Package: emacs Original-Received: via spool by 35062-submit@debbugs.gnu.org id=B35062.155412622830258 (code B ref 35062); Mon, 01 Apr 2019 13:44:01 +0000 Original-Received: (at 35062) by debbugs.gnu.org; 1 Apr 2019 13:43:48 +0000 Original-Received: from localhost ([127.0.0.1]:38958 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hAxE4-0007rx-2E for submit@debbugs.gnu.org; Mon, 01 Apr 2019 09:43:48 -0400 Original-Received: from mail-wr1-f42.google.com ([209.85.221.42]:43746) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hAxE1-0007ri-Js for 35062@debbugs.gnu.org; Mon, 01 Apr 2019 09:43:45 -0400 Original-Received: by mail-wr1-f42.google.com with SMTP id k17so12087540wrx.10 for <35062@debbugs.gnu.org>; Mon, 01 Apr 2019 06:43:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-copies-to:gmane-reply-to-list :date:in-reply-to:message-id:mime-version:content-transfer-encoding; bh=uPMv6z/dZE7pBD4LnZaa3ZkIZR5SVzkUpVuLhLCmUws=; b=WKHhjojDO25ILb25wFQ29LQJo/yyjEldA/LaRqDh38fcvQiVDZqriqB3FBEXNdJaGE xKjPsyWrbdQtdnzlLcNGh0GLnnXPzxjUymTcMETjFkkKEvG1r1G34sBWgLjlrffWaRg/ 8v+Rz7StvWVAafmYIjexKLffIvdzzxkR0l43L86Ua3JjRVSkIxbm2A9w3bFCoxekFvtN Ywn6HUGhWOT4mMATRZtZ6OjnOQ/VImPflS/cEoK/NEnGaXcDzSEKfmlXqfIeYdw3eS+T vZmSgsf/ZDXTo+uXcS4Bhw7RPNn7XrTO+PaYmEVfXFZHiXVJOaLgo5TH95kceaq900Kt 3meQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=uPMv6z/dZE7pBD4LnZaa3ZkIZR5SVzkUpVuLhLCmUws=; b=axWkT1xz3h8w0Tstih1Beh4FFeMIeB1oIK+rux78pqcYoeQIVJmb52C4X56NznK3n3 Mtr8ja2ZoyGxB5x1YyCXqwwU6ta5oQBf8vqsB9sF7cvKr3ZckW4zZB+1wGHIUV4mzEyU HeMw221521SEIaqa3Qbw+MSLktoR/kVB2t63vSIhN79+gW3ElYo0VUtNh4mMmGwjXw1n gIXUivlpM+akQRSi/Fw9forDduTMJe8fL3CLLW42CHGX3fBIAyNEVgF9nNMWHS8t9YNG cY365S2zJV1V9ZET8nZ732ZNk5VUFh8taqhK2G0PrTjq8XT8dfDLQp/5X2l+K1RkibpT VCww== X-Gm-Message-State: APjAAAVaRkAmoK5Ibgzb2Io3ggpbWSDqMUM+PLM+SdeJ8ZWHim998BBG yygRXnry3REFWWje9I6GZJ10s1T7 X-Google-Smtp-Source: APXvYqzn9eZMTLyPYacVIep0YuhPUAgJQjJTmNDK5yckzzZ1r1JA7OtRTE/ybtlda7mCAx20ta+6qg== X-Received: by 2002:a5d:538d:: with SMTP id d13mr42717934wrv.45.1554126219448; Mon, 01 Apr 2019 06:43:39 -0700 (PDT) Original-Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id z140sm3560800wmc.27.2019.04.01.06.43.38 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 01 Apr 2019 06:43:38 -0700 (PDT) Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: <1554125750.2712.1@yandex.ru> (Konstantin Kharlamov's message of "Mon, 01 Apr 2019 16:35:50 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157025 Archived-At: >>>>> On Mon, 01 Apr 2019 16:35:50 +0300, Konstantin Kharlamov said: >> xterm.c:5346 >>=20 >> if (XSCROLL_BAR (bar)->x_window =3D=3D window_id && FRAME_X_DISPLAY >> (XFRAME (frame)) =3D=3D display && (type =3D 2 || (type =3D=3D 1 && >> XSCROLL_BAR (bar)->horizontal) || (type =3D=3D 0 && !XSCROLL_BAR >> (bar)->horizontal))) return XSCROLL_BAR (bar); >>=20 >> Robert Konstantin> Well, not everything at once! :) I afraid that if I Konstantin> fix lots of warnings in one patch-set, it may get Konstantin> stuck in review because of the amount of changes; Konstantin> besides it's easier for my sanity to send small Konstantin> patchsets because mailing-list based projects in Konstantin> general tend not to accept patches too quickly. That=CA=BCs why you concentrate on things that look like errors :-) Konstantin> Also note: the constness here is not for compiler but Konstantin> for developers. I don=CA=BCt see how developers are particularly helped in this particular case, but then again they're not harmed either. Robert