From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#37932: [PATCH] Support hidpi fringes and images with Cairo Date: Sun, 27 Oct 2019 09:22:06 +0100 Message-ID: References: <83r22zvpg4.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="118466"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Carlos Pita , 37932@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 27 09:23:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iOdpP-000Udu-9u for geb-bug-gnu-emacs@m.gmane.org; Sun, 27 Oct 2019 09:23:11 +0100 Original-Received: from localhost ([::1]:44460 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iOdpO-0006Tk-0S for geb-bug-gnu-emacs@m.gmane.org; Sun, 27 Oct 2019 04:23:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39372) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iOdpH-0006Sw-7q for bug-gnu-emacs@gnu.org; Sun, 27 Oct 2019 04:23:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iOdpG-0006jt-7F for bug-gnu-emacs@gnu.org; Sun, 27 Oct 2019 04:23:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:32824) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iOdpG-0006jp-4N for bug-gnu-emacs@gnu.org; Sun, 27 Oct 2019 04:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iOdpF-00026X-VU for bug-gnu-emacs@gnu.org; Sun, 27 Oct 2019 04:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Oct 2019 08:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37932 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37932-submit@debbugs.gnu.org id=B37932.15721645378038 (code B ref 37932); Sun, 27 Oct 2019 08:23:01 +0000 Original-Received: (at 37932) by debbugs.gnu.org; 27 Oct 2019 08:22:17 +0000 Original-Received: from localhost ([127.0.0.1]:41645 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iOdoX-00025a-6x for submit@debbugs.gnu.org; Sun, 27 Oct 2019 04:22:17 -0400 Original-Received: from mail-wr1-f52.google.com ([209.85.221.52]:37428) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iOdoU-00025M-F2 for 37932@debbugs.gnu.org; Sun, 27 Oct 2019 04:22:15 -0400 Original-Received: by mail-wr1-f52.google.com with SMTP id e11so6710724wrv.4 for <37932@debbugs.gnu.org>; Sun, 27 Oct 2019 01:22:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-copies-to:gmane-reply-to-list :date:in-reply-to:message-id:mime-version:content-transfer-encoding; bh=F50XiCLENMDxwdTAGwG8xN6WpyyOw19Au5qJwaz60F0=; b=p+xKLGnspGKUUSxwbXTYgblYh9eKKOgGH/ohpGg9PXbVBfE5+Zy2qGQjOIEMKJWWPL PCl51ECAYU/MrJmRqgbRCb8pYxWbmaKhn/78Rb+6oq0WUmJI/HHva2v8hPtxx+Nb/n8U 9GG6a0dtjqiPn0MmdVYiU+EWfspi6O75DZf0+0UOflmK/WML+XTSlc9dgdwwWDchPsDB nxBeuWc3kicvw+u/Ws9vwZWbmhdwwoRV9tfuqp0IyQ2a5AP/L4rd9LH0WX74sjuMRxPp B8TJoC48//WaP5J+kPuG4A9ymfxSbrldknDfi+uq+XOK0O4+RcMwfpku/2ZTvDK2Pi7L fIvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=F50XiCLENMDxwdTAGwG8xN6WpyyOw19Au5qJwaz60F0=; b=fYVg1InT3SaxKBYu6A0ewZt7+aZ874kTwyAo4IWkDk+NJfzPAx1Y2uEpKRm+NKQwJF 5CS8U9sz3gMjxVNKgVpvItnhnHCsbsiRCRfABwKPCi5sZJfbpEBw2aFuSH7wDvovo68D qFLPbwcFS4LcGNP7KdEtF6ihvHouAL6l8NbuOZSH4GYY7MzHsc2CLOEIb14rnbEITRrd cFK11A7At+dtJCMfx1MduJC5svc0tIpuCrZnRTKqn5kkpeT28KHYLPCTUM54J/RKHdjh YsRPPlTayV0gaoLggqoyOfRHyiQjn3OrgtotPDEFxbvl9L7zWPn+Iq5S3sDiV9aHzWFB T0jg== X-Gm-Message-State: APjAAAVkUS2ej+KcGNTiohbq/+VyVvdlTDHPyJjWHm9jsCZV0dBEdMQK 03Izge2ibeK3JB0O+J59q0Zrw3hc X-Google-Smtp-Source: APXvYqwzF8bTezvKEOFdQAr8HX4dJbz7yYwHeVQ/G/iHB3c1KFm0meyDLga9PoEkUC1lGyhNFBVfMQ== X-Received: by 2002:adf:ea50:: with SMTP id j16mr9904932wrn.295.1572164528113; Sun, 27 Oct 2019 01:22:08 -0700 (PDT) Original-Received: from rpluim-mac ([2a01:e34:ecfc:a860:402:a949:d521:f754]) by smtp.gmail.com with ESMTPSA id f20sm7100542wmb.6.2019.10.27.01.22.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Oct 2019 01:22:07 -0700 (PDT) Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: <83r22zvpg4.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 26 Oct 2019 12:14:19 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:170234 Archived-At: >>>>> On Sat, 26 Oct 2019 12:14:19 +0300, Eli Zaretskii said: >> * It removes the auto :scale property. I think this is the right thi= ng >> to do, applications that want to use the :scale parameter to transfo= rm >> their images shouldn't lose the hidpi scaling nor explicitly call >> image-compute-scaling-factor. If I read the patch correctly, you now auto-scale inside image.c, which shouldn't change anything when not using :scale. What's the effect when code passes in eg :scale 2? Autoscaling + frame scaling, so for a frame where scale =3D=3D 2 we get * 4? I guess that would be sensible, but we=CA=BCd need to explain it clearly. [1] Eli> I don't think I'm qualified to make an intelligent decision on thi= s by Eli> myself (and you just asked the question not long ago, and proceede= d to Eli> coding without giving anyone any time to answer it :-(). I don't = know Eli> enough about this to make such a decision. maybe Robert, Alan, and Eli> others would chime in and voice their opinions. failing that, ple= ase Eli> tell more about the pro's and con's here, so that we could see what Eli> kind of trade-offs are we talking about. I think Lars did the autoscaling work. If things continue to work as before for the normal case, and we explain the interaction between :scale and frame scale I have no objections. Robert Footnotes: [1] And it would get people out of the "1 physical display pixel =3D=3D 1 logical display pixel" mindset that needed to be fixed in so many places in the X backend.