From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Koning Newsgroups: gmane.emacs.bugs Subject: bug#41761: [PATCH] bug#41761: 28.0.50; M-x count-words counts words only up to a field boundary Date: Sat, 15 Aug 2020 12:44:10 -0500 Message-ID: References: <87y2oxwldi.fsf@gmail.com> <83imdllc2l.fsf@gnu.org> <834kp5kpj1.fsf@gnu.org> <838sefkh5t.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1981"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (darwin) Cc: Stefan Kangas , 41761@debbugs.gnu.org, pipcet@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 15 19:45:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k70Ex-0000Mg-U8 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Aug 2020 19:45:11 +0200 Original-Received: from localhost ([::1]:39512 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k70Ew-0001Ug-V5 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Aug 2020 13:45:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49180) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k70Eo-0001UJ-Qs for bug-gnu-emacs@gnu.org; Sat, 15 Aug 2020 13:45:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44861) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k70Eo-0005Ji-He for bug-gnu-emacs@gnu.org; Sat, 15 Aug 2020 13:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k70Eo-0006WN-GL for bug-gnu-emacs@gnu.org; Sat, 15 Aug 2020 13:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Koning Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Aug 2020 17:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41761 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41761-submit@debbugs.gnu.org id=B41761.159751346525010 (code B ref 41761); Sat, 15 Aug 2020 17:45:02 +0000 Original-Received: (at 41761) by debbugs.gnu.org; 15 Aug 2020 17:44:25 +0000 Original-Received: from localhost ([127.0.0.1]:56407 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k70EC-0006VJ-HC for submit@debbugs.gnu.org; Sat, 15 Aug 2020 13:44:24 -0400 Original-Received: from sender4-of-o56.zoho.com ([136.143.188.56]:21624) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k70EA-0006VB-DX for 41761@debbugs.gnu.org; Sat, 15 Aug 2020 13:44:23 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1597513456; cv=none; d=zohomail.com; s=zohoarc; b=DDpUr4+TZnt7Pqw37o5nPqE5KXEt4+bTKztvsYkMn8QRkQ6Sr0g4zF5t+AtslTxUZ+QjQDD9sktmIqrkDky1zBjOj9iCmlF0ZSy0Q3cgGIAL3UTb5gpvubH7CgG1zB+kVIRM8V5/vwcQxDjYtpyJfPgJQSuiwmPBkB10RYoJrX0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1597513456; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=3G4+zYrS9EiZ6W9LkkaoRnmnqu7iVon0hPYJkmBpsKc=; b=SD7CpxZ+qCpLKrl4aXbPr+aos9Ci0FYVISlBtUg/MH3jvhM1BLkEN5vQKajyVdyn1dv/QnbUjW/IPhyqrEauDUG6w94bPLLeGlHaZ16k6Axeq+H1zkE0DYzs9MS6IdkTGRSYLpqth8UmuR9SqSII1W/R/jilFShHwO2wouao99w= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass smtp.mailfrom=dk@danielkoning.com; dmarc=pass header.from= header.from= Original-Received: from cornelius (112.157.239.35.bc.googleusercontent.com [35.239.157.112]) by mx.zohomail.com with SMTPS id 1597513453005827.371888855199; Sat, 15 Aug 2020 10:44:13 -0700 (PDT) In-Reply-To: <838sefkh5t.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 15 Aug 2020 19:28:14 +0300") X-ZohoMailClient: External X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:185250 Archived-At: Eli Zaretskii writes: >> +** 'count-words' now skips field boundaries. >> +Before, 'count-words' incorrectly stopped counting the number of words >> +in buffer at a field boundary. This bug has been fixed. > > I don't think it was a bug, so the wording should be different. If the old behavior didn't qualify as a bug, then wouldn't you say the docstring was buggy? It said that the function returned or printed something that it really didn't ("the number of words between START and END"). And there's nothing in the docs to suggest that we should read that as "between START and END, or between START and the next field boundary if that boundary comes before END." (Nor does this rule apply to the other tallies that the function makes. Put an extra line of text beneath the line containing the several fields, and the interactive `count-words' message will reflect that line in its line count and character count, but not in its word count. So between "(defun count-words" and its matching ")", something is amiss, whether it's code or documentation.) If you don't like the word "bug" for this, the NEWS item might at least mention that the prior behavior was undocumented and inconsistent, just to clarify why the manual entry isn't changing along with the code. Daniel