From: "Gerd Möllmann" <gerd.moellmann@gmail.com>
To: Rob Browning <rlb@defaultvalue.org>
Cc: 57789@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
Subject: bug#57789: Emacs 28.1 clone build with native compilation crashes on s390x
Date: Sun, 18 Sep 2022 07:22:45 +0200 [thread overview]
Message-ID: <m2a66xxnmi.fsf@Mini.fritz.box> (raw)
In-Reply-To: <87tu55k90g.fsf@trouble.defaultvalue.org> (Rob Browning's message of "Sat, 17 Sep 2022 16:04:31 -0500")
Rob Browning <rlb@defaultvalue.org> writes:
> Gerd Möllmann <gerd.moellmann@gmail.com> writes:
>
>> Looking at Rob's backtrace,
>>
>> #0 mark_object (arg=<optimized out>) at alloc.c:6809
>> #1 0x000002aa001a8ee6 in mark_objects (n=<optimized out>, obj=0x2aa00ac54a8) at alloc.c:6607
>> #2 mark_vectorlike (header=0x2aa00ac54a0) at alloc.c:6382
>> #3 0x000002aa001a8ee6 in mark_objects (n=<optimized out>, obj=0x2aa007f4ca8) at alloc.c:6607
>> #4 mark_vectorlike (header=0x2aa007f4ca0) at alloc.c:6382
>> #5 0x000002aa001a8ee6 in mark_objects (n=<optimized out>, obj=0x2aa007c3b10) at alloc.c:6607
>> #6 mark_vectorlike (header=0x2aa007c3b08) at alloc.c:6382
>> #7 0x000002aa001a7c3e in visit_static_gc_roots (visitor=...) at alloc.c:5926
>>
>> and seeing frame#7, would it be a way forward to determine which
>> staticpro (I assume it is a staticpro) that is? Maybe that can give a
>> clue which one can then use together with a bisect, perhaps?
>
> Not completely sure I followed, but moving up to that frame and printing
> visitor didn't work: "optimized out".
Sorry, I thought another Emacs developer would chime in, when I wrote
that.
Let me try to explain what I'm after. Frame#7, the call to
visit_static_gc_roots shows that we are at the very beginning of a GC,
recursively marking everything that we know must survice the GC.
void
visit_static_gc_roots (struct gc_root_visitor visitor)
{
visit_buffer_root (visitor,
&buffer_defaults,
GC_ROOT_BUFFER_LOCAL_DEFAULT);
visit_buffer_root (visitor,
&buffer_local_symbols,
GC_ROOT_BUFFER_LOCAL_NAME);
for (int i = 0; i < ARRAYELTS (lispsym); i++)
{
Lisp_Object sptr = builtin_lisp_symbol (i);
visitor.visit (&sptr, GC_ROOT_C_SYMBOL, visitor.data);
}
for (int i = 0; i < staticidx; i++)
visitor.visit (staticvec[i], GC_ROOT_STATICPRO, visitor.data);
}
First interesting thing would be where in this function we are when the
crash happens. I was assuming it is somewhere in the last for-loop, for
reasons, but that doesn't have to be the case.
If I'm right, we are currently in the process of marking Lisp objects
referenced from C variables that are known to contains Lisp objects.
Such variables are added to staticvec with a call to staticpro. That's
what the staticpro in my last mail menat.
But let's first see where in visit_... we are.
next prev parent reply other threads:[~2022-09-18 5:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 1:04 bug#57789: Emacs 28.1 clone build with native compilation crashes on s390x Rob Browning
2022-09-14 2:42 ` Eli Zaretskii
2022-09-14 3:06 ` Rob Browning
2022-09-14 3:20 ` Rob Browning
2022-09-14 20:19 ` Rob Browning
2022-09-14 20:21 ` Rob Browning
2022-09-16 6:04 ` Gerd Möllmann
2022-09-17 21:04 ` Rob Browning
2022-09-18 5:22 ` Gerd Möllmann [this message]
2022-09-18 5:49 ` Eli Zaretskii
2022-09-18 5:55 ` Gerd Möllmann
2022-09-18 5:33 ` Eli Zaretskii
2022-09-24 21:06 ` Rob Browning
2023-06-07 21:15 ` Andrea Corallo
2023-09-11 18:08 ` Stefan Kangas
2022-09-15 7:10 ` Eli Zaretskii
2022-09-15 14:51 ` Paul Eggert via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-15 16:26 ` Rob Browning
2022-09-16 8:43 ` Andrea Corallo
2022-09-16 8:39 ` Andrea Corallo
2022-09-17 21:00 ` Rob Browning
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2a66xxnmi.fsf@Mini.fritz.box \
--to=gerd.moellmann@gmail.com \
--cc=57789@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=rlb@defaultvalue.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).