unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: George Huebner <george@feyor.sh>
To: 71792@debbugs.gnu.org
Subject: bug#71792: [PATCH] Fix: make xwidget-webkit-scroll-backward scroll backwards
Date: Thu, 27 Jun 2024 02:50:35 -0500	[thread overview]
Message-ID: <m2a5j6zuwk.fsf@feyor.sh> (raw)

[-- Attachment #1: Type: text/plain, Size: 844 bytes --]

Fixed a typo; this is consistent with the definition of
xwidget-webkit-scroll-down.


In GNU Emacs 29.1 (build 1, aarch64-apple-darwin23.4.0, Carbon 
Version
170 AppKit 2487.5)
Windowing system distributor 'Apple Inc.', version 14.4.0
System Description:  macOS 14.4

Configured using:
 'configure
 --prefix=/nix/store/ismv7jzf3hcqziq5bpjfs54zd4qfjjn7-emacs-mac-macport-29.1
 --disable-build-details --with-modules --without-gif 
 --without-jpeg
 --without-png --without-tiff --without-x --without-xpm
 '--enable-mac-app=$$out/Applications' --with-gnutls --with-mac
 --with-xml2 --without-ns --with-compress-install
 --with-toolkit-scroll-bars --with-native-compilation
 --without-imagemagick --with-mailutils --without-small-ja-dic
 --with-tree-sitter --without-xinput2 --without-xwidgets 
 --without-dbus
 --without-selinux --with-xwidgets'


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-make-xwidget-webkit-scroll-backward-scroll-backw.patch --]
[-- Type: text/x-patch, Size: 1015 bytes --]

From d40761c0c26d28587187fd3f147804adac365563 Mon Sep 17 00:00:00 2001
From: George Huebner <george@feyor.sh>
Date: Tue, 18 Jun 2024 17:14:41 -0500
Subject: [PATCH] Fix: make xwidget-webkit-scroll-backward scroll backwards

* lisp/xwidget.el (xwidget-webkit-scroll-backward): Move hyphen out of
%-formatter, changing semantics from a padding specifier to a negative
sign.
---
 lisp/xwidget.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/xwidget.el b/lisp/xwidget.el
index cca01c8..bf5987d 100644
--- a/lisp/xwidget.el
+++ b/lisp/xwidget.el
@@ -378,7 +378,7 @@ one char."
              (> (window-hscroll) 0))
         (set-window-hscroll nil (- (window-hscroll) n))
       (xwidget-webkit-execute-script session
-                                     (format "window.scrollBy(%-d, 0);"
+                                     (format "window.scrollBy(-%d, 0);"
                                              (* n (window-font-width)))))))
 
 (defun xwidget-webkit-scroll-top ()
-- 
2.44.1


             reply	other threads:[~2024-06-27  7:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-27  7:50 George Huebner [this message]
2024-06-29 12:16 ` bug#71792: [PATCH] Fix: make xwidget-webkit-scroll-backward scroll backwards Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2a5j6zuwk.fsf@feyor.sh \
    --to=george@feyor.sh \
    --cc=71792@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).