From: "Gerd Möllmann" <gerd.moellmann@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 74740@debbugs.gnu.org
Subject: bug#74740: 31.0.50; tty menus not displaying separators
Date: Mon, 09 Dec 2024 15:20:21 +0100 [thread overview]
Message-ID: <m2a5d56iqi.fsf@gmail.com> (raw)
In-Reply-To: <86bjxldks6.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 09 Dec 2024 15:54:17 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Gerd Möllmann <gerd.moellmann@gmail.com>
>> Cc: 74740@debbugs.gnu.org
>> Date: Mon, 09 Dec 2024 05:29:43 +0100
>>
>> >> 23.18.1.3 Menu Separators
>> >> .........................
>> >>
>> >> A menu separator is a kind of menu item that doesn't display any
>> >> text--instead, it divides the menu into subparts with a horizontal line.
>> >> A separator looks like this in the menu keymap:
>> >>
>> >> (menu-item SEPARATOR-TYPE)
>> >>
>> >> where SEPARATOR-TYPE is a string starting with two or more dashes.
>> >>
>> >> followed by a list of separator types, among them the --double-line I
>> >> mentioned.
>> >>
>> >> One can get these from 3rd-party packages. Minion is an example, where
>> >> --double-line appears in a popup menu on the mode line.
>> >
>> > This was never supported in TTY menus (I think I was completely
>> > unaware of this feature when I wrote the code). Patches to support it
>> > will be most welcome.
>>
>> The following patch displays "--" for all separator types. I'd say
>> that's good enough, WDYT?
>
> Yes, LGTM, please install. But please add a FIXME comment there
> mentioning the feature and inviting its implementation.
Thanks, pushed to master, and closing.
prev parent reply other threads:[~2024-12-09 14:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-08 17:34 bug#74740: 31.0.50; tty menus not displaying separators Gerd Möllmann
2024-12-08 18:33 ` Eli Zaretskii
2024-12-08 18:46 ` Gerd Möllmann
2024-12-08 19:04 ` Eli Zaretskii
2024-12-09 4:29 ` Gerd Möllmann
2024-12-09 13:54 ` Eli Zaretskii
2024-12-09 14:20 ` Gerd Möllmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2a5d56iqi.fsf@gmail.com \
--to=gerd.moellmann@gmail.com \
--cc=74740@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).