From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Gemini Lasswell Newsgroups: gmane.emacs.bugs Subject: bug#24743: 26.0.50; Testcover does not correctly instrument a macro that uses defun Date: Wed, 19 Oct 2016 16:51:08 -0700 Message-ID: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1476921147 31308 195.159.176.226 (19 Oct 2016 23:52:27 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 19 Oct 2016 23:52:27 +0000 (UTC) To: 24743@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 20 01:52:23 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bx0eY-0005vE-93 for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 Oct 2016 01:52:10 +0200 Original-Received: from localhost ([::1]:51625 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bx0ea-0007aV-G1 for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Oct 2016 19:52:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46955) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bx0eT-0007aC-VO for bug-gnu-emacs@gnu.org; Wed, 19 Oct 2016 19:52:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bx0eQ-0006wO-Tb for bug-gnu-emacs@gnu.org; Wed, 19 Oct 2016 19:52:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33969) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1bx0eQ-0006wK-Pt for bug-gnu-emacs@gnu.org; Wed, 19 Oct 2016 19:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bx0eQ-0006tN-Ja for bug-gnu-emacs@gnu.org; Wed, 19 Oct 2016 19:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gemini Lasswell Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Oct 2016 23:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 24743 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.147692111526477 (code B ref -1); Wed, 19 Oct 2016 23:52:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 19 Oct 2016 23:51:55 +0000 Original-Received: from localhost ([127.0.0.1]:40159 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bx0eJ-0006sz-Bq for submit@debbugs.gnu.org; Wed, 19 Oct 2016 19:51:55 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:55929) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bx0eI-0006sm-1X for submit@debbugs.gnu.org; Wed, 19 Oct 2016 19:51:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bx0eB-0006rG-Qv for submit@debbugs.gnu.org; Wed, 19 Oct 2016 19:51:48 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:43130) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bx0eB-0006r6-NQ for submit@debbugs.gnu.org; Wed, 19 Oct 2016 19:51:47 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46893) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bx0eA-0007Zx-4q for bug-gnu-emacs@gnu.org; Wed, 19 Oct 2016 19:51:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bx0e7-0006o0-2l for bug-gnu-emacs@gnu.org; Wed, 19 Oct 2016 19:51:46 -0400 Original-Received: from aibo.runbox.com ([91.220.196.211]:33667) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bx0e6-0006nQ-S8 for bug-gnu-emacs@gnu.org; Wed, 19 Oct 2016 19:51:43 -0400 Original-Received: from [10.9.9.212] (helo=mailfront12.runbox.com) by bars.runbox.com with esmtp (Exim 4.71) (envelope-from ) id 1bx0e4-0007vM-AY for bug-gnu-emacs@gnu.org; Thu, 20 Oct 2016 01:51:40 +0200 Original-Received: from c-24-22-244-161.hsd1.wa.comcast.net ([24.22.244.161] helo=rainbow.local) by mailfront12.runbox.com with esmtpsa (uid:179284 ) (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) id 1bx0dl-000157-0V for bug-gnu-emacs@gnu.org; Thu, 20 Oct 2016 01:51:21 +0200 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:124699 Archived-At: Testcover doesn't work on lisp/isearch.el in the Emacs source tree. It fails on the first use of isearch-define-mode-toggle. I've created a much simpler example which produces the same error message: (defmacro my-defun (name &rest body) (declare (debug (symbolp def-body))) `(defun ,name () ,@body)) (my-defun foo (+ 1 2)) To reproduce the bug: 1. Save the above code as bug.el 2. emacs -Q 3. C-x C-f bug.el RET 4. M-: (require 'testcover) RET 5. M-x testcover-start RET bug.el RET Result: "Wrong type argument: consp, nil" and foo does not get defined. (symbol-function #'my-defun) reveals that there is a call to edebug-after in the definition that did not get replaced by testcover-after. In GNU Emacs 26.0.50.2 (x86_64-apple-darwin15.6.0, NS appkit-1404.47 Version 10.11.6 (Build 15G1004)) of 2016-10-19 built on rainbow.local Repository revision: 911ade134058c633ab9bec75f664d44aa1faaac3 Windowing system distributor 'Apple', version 10.3.1404 Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. testcover Edebug: my-defun Eager macro-expansion failure: (wrong-type-argument consp nil) [2 times] cons: Wrong type argument: consp, nil Configured using: 'configure --with-ns --disable-ns-self-contained' Configured features: JPEG RSVG IMAGEMAGICK NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Emacs-Lisp Minor modes in effect: tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message subr-x puny seq byte-opt gv bytecomp byte-compile cl-extra help-mode cconv dired dired-loaddefs format-spec rfc822 mml mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils ielm pp comint ansi-color ring testcover edebug easymenu cl-loaddefs pcase cl-lib time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/ns-win ns-win ucs-normalize term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote kqueue cocoa ns multi-tty make-network-process emacs) Memory information: ((conses 16 212236 12367) (symbols 48 20872 0) (miscs 40 58 213) (strings 32 20332 5553) (string-bytes 1 648497) (vectors 16 35663) (vector-slots 8 676706 4164) (floats 8 180 171) (intervals 56 257 0) (buffers 976 13))