From: charles@aurox.ch (Charles A. Roelli)
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: 17893@debbugs.gnu.org
Subject: bug#17893: 24.4.50; (error "Marker does not point anywhere")
Date: Sun, 19 Nov 2017 20:31:06 +0100 [thread overview]
Message-ID: <m28tf2vzet.fsf@aurox.ch> (raw)
In-Reply-To: <jwvk1ystyiq.fsf-monnier+emacsbugs@gnu.org> (message from Stefan Monnier on Tue, 14 Nov 2017 15:08:08 -0500)
> From: Stefan Monnier <monnier@IRO.UMontreal.CA>
> Date: Tue, 14 Nov 2017 15:08:08 -0500
>
> > I was not careful to make sure that the mark-ring contains valid
> > markers, so it may be an error in my code. On the other hand, looking
> > at the definition of `clone-buffer' (which my patch uses), I don't see
> > anything that would update the markers of the mark-ring in the newly
> > cloned buffer to point to the new buffer instead of the old one.
> > Maybe that is also a problem?
>
> Yup, sounds like we have a bug in clone-buffer, at least.
>
>
> Stefan
Right-o, here's a fix with respect to the emacs-26 branch:
diff --git a/lisp/simple.el b/lisp/simple.el
index 7d47d0f..64b7bde 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -8518,6 +8518,15 @@ clone-buffer
(error nil)))
lvars)
+ ;; Update markers in the copied mark ring to refer to the new buffer.
+ (setq mark-ring
+ (mapcar (lambda (m)
+ (let ((new-marker))
+ (setq new-marker (copy-marker m))
+ (move-marker new-marker new-marker (current-buffer))
+ new-marker))
+ mark-ring))
+
;; Run any hooks (typically set up by the major mode
;; for cloning to work properly).
(run-hooks 'clone-buffer-hook))
It fixes the minimal recipe to reproduce this bug:
> 1. C-h i
> 2. Click/drag a few times in the *info* buffer to set some marks
> 3. M-n C-x o C-x k RET
> 4. Click in the remaining *info*<2> buffer:
>
> set-transient-map PCH: (error "Marker does not point anywhere")
next prev parent reply other threads:[~2017-11-19 19:31 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 21:10 bug#17893: 24.4.50; (error "Marker does not point anywhere") Drew Adams
2014-07-01 22:42 ` Stefan Monnier
2014-07-02 1:17 ` Drew Adams
2014-07-02 2:11 ` Stefan Monnier
2014-07-02 2:49 ` Drew Adams
2014-07-02 14:09 ` Stefan Monnier
2014-07-02 14:22 ` Drew Adams
2014-07-02 14:58 ` Stefan Monnier
2014-07-02 16:08 ` Drew Adams
2014-07-02 18:24 ` Stefan Monnier
2014-07-02 18:39 ` Drew Adams
2014-07-02 18:58 ` Stephen Berman
2014-07-15 16:19 ` Drew Adams
2017-11-12 10:41 ` Charles A. Roelli
2017-11-12 21:03 ` Stefan Monnier
2017-11-14 19:56 ` Charles A. Roelli
2017-11-14 20:08 ` Stefan Monnier
2017-11-19 19:31 ` Charles A. Roelli [this message]
2017-11-20 15:45 ` Eli Zaretskii
2017-11-20 16:51 ` Stefan Monnier
2017-11-20 17:55 ` Eli Zaretskii
2017-11-20 18:59 ` Stefan Monnier
2017-11-20 19:32 ` Eli Zaretskii
2017-11-20 19:49 ` Andreas Schwab
2017-11-20 20:01 ` Charles A. Roelli
2017-11-20 20:29 ` Eli Zaretskii
2017-11-24 20:18 ` Charles A. Roelli
2017-11-24 20:39 ` Eli Zaretskii
2017-11-25 14:13 ` Charles A. Roelli
2017-11-25 16:06 ` Eli Zaretskii
2017-11-25 16:48 ` Stefan Monnier
2017-11-25 17:20 ` Eli Zaretskii
2017-11-25 18:30 ` Andreas Schwab
2017-11-25 19:23 ` Eli Zaretskii
2017-11-25 20:47 ` Andreas Schwab
2017-11-26 10:26 ` martin rudalics
2017-11-26 16:07 ` Eli Zaretskii
2017-11-27 8:50 ` martin rudalics
2017-11-27 9:54 ` Andreas Schwab
2017-11-27 10:02 ` martin rudalics
2017-11-24 21:22 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m28tf2vzet.fsf@aurox.ch \
--to=charles@aurox.ch \
--cc=17893@debbugs.gnu.org \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).