From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#39344: 28.0.50; Gnus: Selecting deleted buffer Date: Wed, 29 Jan 2020 14:42:26 +0100 Message-ID: References: <871rria3fp.fsf@web.de> <87lfpq9zsr.fsf@gmx.net> <87h80e9ylb.fsf@gmx.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="39467"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Michael Heerdegen , Sam Steingold , 39344@debbugs.gnu.org To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 29 14:43:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iwncd-000AFE-CS for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 29 Jan 2020 14:43:11 +0100 Original-Received: from localhost ([::1]:46720 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iwncc-00007E-Bq for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 29 Jan 2020 08:43:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60512) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iwncV-00006v-Ge for bug-gnu-emacs@gnu.org; Wed, 29 Jan 2020 08:43:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iwncU-00034i-Hz for bug-gnu-emacs@gnu.org; Wed, 29 Jan 2020 08:43:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55611) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iwncU-00034Y-EX for bug-gnu-emacs@gnu.org; Wed, 29 Jan 2020 08:43:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iwncU-0008CS-BZ for bug-gnu-emacs@gnu.org; Wed, 29 Jan 2020 08:43:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Jan 2020 13:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39344 X-GNU-PR-Package: emacs Original-Received: via spool by 39344-submit@debbugs.gnu.org id=B39344.158030535631482 (code B ref 39344); Wed, 29 Jan 2020 13:43:02 +0000 Original-Received: (at 39344) by debbugs.gnu.org; 29 Jan 2020 13:42:36 +0000 Original-Received: from localhost ([127.0.0.1]:33351 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iwnc3-0008Bh-Po for submit@debbugs.gnu.org; Wed, 29 Jan 2020 08:42:35 -0500 Original-Received: from mail-wm1-f43.google.com ([209.85.128.43]:36235) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iwnc2-0008BU-4t for 39344@debbugs.gnu.org; Wed, 29 Jan 2020 08:42:34 -0500 Original-Received: by mail-wm1-f43.google.com with SMTP id p17so6521599wma.1 for <39344@debbugs.gnu.org>; Wed, 29 Jan 2020 05:42:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=mTcj10bYXQMMAi+Clu/MGNNmn4S2zrEXgllnabzbr+s=; b=ERuoOjZ+Uktl2hCgW84hYJihJlX+jg2DvGFUxaX0VBQunOjaqhsjI+sr1sSS7PHwLu Dji37K4BUGlk72z7yyN4KwaTAdIpdkOd2o+01/OPAoOfwmxqz+1yUW/UXTaBJ9ZCWFjr y43LoZL70QpZPRLmw3D4Ykydc7Hna7J2H+NhnwNi9270ivSodV46NL8P8u1UBdU22hdr n8v6IxZpXcXizeolE9WCjlGDmbUbpIAOrjgKlEChhqZJKLcmE0xhqsu1uQQqPbQYMfYm G3lWN8n8H88nhZKYTROYvVXKfZQU8n+bph6rjUHaIlxHAMXYCeezy06IFAc8yswA0H5S HlFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=mTcj10bYXQMMAi+Clu/MGNNmn4S2zrEXgllnabzbr+s=; b=jnoMbp5lmSh9HGY4icP+dKBFgu/snYb2QmjKK8rv9GT35kQOEn5CLlrnozcea1wven GcjPTDaEwxbb4vpk9DW0fQ9Ywm0+F8NGpID7HYTp2xZQ8UtsXD8us7+lAYJTrPfJtGfo 6UBCkHW3Xt3cxsYJETHsz42j2GWXA+rEzMgKj75YLVSj7nzOgAhgN1NbM4El/L7ckpBd KDqlyco2180Lb2Ib38YApmLFAFlv5thTleq8L2dK/vvw+nuf4jhidqPbcXOHKbquoHIY qImim8Wb6V8EhDywM7ZaFz9nOYIfli/gNHE56VOZxCBnZrSvZKgX05HyYMrmVmqY8SGp k/7A== X-Gm-Message-State: APjAAAXvzDTorYTnqtE09yXT7u1cjkFBB0ua2TEBASjFwDBf3aHkYjf3 ednpL9w2hjnfsPyilf3xhtmAn7Wy X-Google-Smtp-Source: APXvYqx7VBOTUKD7juRK0cRitMQ/ZaEmXyKCx+1jwXKhdw5uEI5zKMLn2yAYHTK30g241W4bT1Yueg== X-Received: by 2002:a05:600c:2c44:: with SMTP id r4mr11441023wmg.140.1580305347991; Wed, 29 Jan 2020 05:42:27 -0800 (PST) Original-Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id q11sm2929415wrp.24.2020.01.29.05.42.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jan 2020 05:42:27 -0800 (PST) In-Reply-To: <87h80e9ylb.fsf@gmx.net> (Stephen Berman's message of "Wed, 29 Jan 2020 14:33:20 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175389 Archived-At: >>>>> On Wed, 29 Jan 2020 14:33:20 +0100, Stephen Berman said: Stephen> On Wed, 29 Jan 2020 14:25:10 +0100 Robert Pluim wrote: >>>>>>> On Wed, 29 Jan 2020 14:07:16 +0100, Stephen Berman >> said: Stephen> I see this too. The patch below appears to fix it for me, but= I don't Stephen> know if it's just a workaround. >>=20 >> That can=CA=BCt be right. 'gnus-buffers' already checks 'buffer-live= -p'. Stephen> Hm, odd, because when I stepped through gnus-clear-system, the= error Stephen> occurred here: Stephen> ;; Kill Gnus buffers. Stephen> (do-auto-save t) Stephen> (dolist (buffer (gnus-buffers)) Stephen> (with-current-buffer buffer <=3D=3D=3D Stephen> and after adding the buffer-live-p check before that line, the= error no Stephen> longer occurs. So one of Gnus' buffers is being killed in the middle of that dolist. The only way I can see that happening is if the same buffer is in there twice, in which case the following would work as well. diff --git a/lisp/gnus/gnus.el b/lisp/gnus/gnus.el index 6df26b4af8..2fc14c5fff 100644 --- a/lisp/gnus/gnus.el +++ b/lisp/gnus/gnus.el @@ -671,7 +671,7 @@ gnus-kill-buffer =20 (defun gnus-buffers () "Return a list of live Gnus buffers." - (setq gnus-buffers (seq-filter #'buffer-live-p gnus-buffers))) + (setq gnus-buffers (delete-dups (seq-filter #'buffer-live-p gnus-buffers= )))) =20 (defalias 'gnus-prune-buffers #'gnus-buffers) =20