From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#39662: 28.0.50; Emacs crashes in x_cr_define_fringe_bitmap if (fringe-mode 0) Date: Tue, 18 Feb 2020 20:32:37 +0100 Message-ID: References: <87h7zoorys.fsf@thb.lt> <87lfozsuoi.fsf@thb.lt> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="99947"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 39662@debbugs.gnu.org, Dmitry Gutov To: Thibault Polge Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 18 20:33:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j48cM-000Ppk-7Z for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 18 Feb 2020 20:33:14 +0100 Original-Received: from localhost ([::1]:40862 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j48cK-0001HC-Rx for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 18 Feb 2020 14:33:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39112) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j48cA-0001FM-W9 for bug-gnu-emacs@gnu.org; Tue, 18 Feb 2020 14:33:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j48cA-0000e9-2G for bug-gnu-emacs@gnu.org; Tue, 18 Feb 2020 14:33:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35321) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j48c9-0000dw-Sg for bug-gnu-emacs@gnu.org; Tue, 18 Feb 2020 14:33:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j48c9-00024z-Q2 for bug-gnu-emacs@gnu.org; Tue, 18 Feb 2020 14:33:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Feb 2020 19:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39662 X-GNU-PR-Package: emacs Original-Received: via spool by 39662-submit@debbugs.gnu.org id=B39662.15820543667966 (code B ref 39662); Tue, 18 Feb 2020 19:33:01 +0000 Original-Received: (at 39662) by debbugs.gnu.org; 18 Feb 2020 19:32:46 +0000 Original-Received: from localhost ([127.0.0.1]:41294 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j48bu-00024P-Gw for submit@debbugs.gnu.org; Tue, 18 Feb 2020 14:32:46 -0500 Original-Received: from mail-wr1-f46.google.com ([209.85.221.46]:36055) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j48bs-00024D-Gh for 39662@debbugs.gnu.org; Tue, 18 Feb 2020 14:32:45 -0500 Original-Received: by mail-wr1-f46.google.com with SMTP id z3so25456003wru.3 for <39662@debbugs.gnu.org>; Tue, 18 Feb 2020 11:32:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=i5qy/KkOe/ye16lsNnuEU4PMgQhx4l+DOY9PwqYVNSA=; b=o+DgyzgaDyXzWdpR3RNGEMGdAuxrz5/DKUnnlHf7xrokLjoaIjv6wclH1aXl6KD00G AyeGzZ2vovxEpzY9UGGkLD0vlsTgfEIgVliD0lZFZd1wNqHoXkeXKxhFxEanrpXtobnl b84eZf9cZmuQ779SCZNq/bNpbQtdxTj70oIbFRPFICJLzKM+3+K5JkaM7Y4JIc+9ASci YR5bahwPrf4ybcweYpjd3nRKrDT3Ts+wAuqgFQxF+WXGhHnPfRxF+kI7PvQCnh+eKKjJ uKsxxjbAu1E+up8Qs8s/a3yn+m9Cd4yhDg/tiWZgSHAz33UgvPZaTuoBylZo4GjwiFiE 0v4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=i5qy/KkOe/ye16lsNnuEU4PMgQhx4l+DOY9PwqYVNSA=; b=JqpbF74lSpYMnfAvgaAi06eYn384xZ6ZCn41Ib7Ulb22yL6GbsA9ywGFe0CTZmrMwT qfqUSL7wyZvrW1Rm/kWP0e/v1gWJLWqVwpM9RPjc280TUIgM5FW6JMtm1qhEaH/bJu4k iK+JZJqSNbzCZXzx9eWac/mYEvVr8LrramKIU0+5do1HFCDjZt2D803+p8lKWAGvYqS2 qlyNXbv1SE49pVj27IZ00TtjrcOcqvhNlVxhy0s85d9pLzI2f211LzxNZ5ttgwOI/sBK JurVig964O7yQ0HFBD8mdwtiWawfA0Hiz+xyBwagCLNtK4TstM/MlqeG+vPrP7wEdgI6 vxUA== X-Gm-Message-State: APjAAAWcU964PxvKKxz2TcjOaAfYyHm5AwUgokqbHAecnCE8yWPWQw/i CMpWZjtyQ+fxuUfz0jd7B3E= X-Google-Smtp-Source: APXvYqyThPArXXqaJqZJk8QGchcAXkfIWGINo4CuCCYw9kN5UiqbXrY2k1fGCb91XUJ5YoS1y9eDjw== X-Received: by 2002:adf:d84c:: with SMTP id k12mr31036323wrl.96.1582054358569; Tue, 18 Feb 2020 11:32:38 -0800 (PST) Original-Received: from rpluim-mac ([2a01:e34:ecfc:a860:18af:a86f:d22c:3e31]) by smtp.gmail.com with ESMTPSA id f11sm4543253wml.3.2020.02.18.11.32.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Feb 2020 11:32:38 -0800 (PST) In-Reply-To: <87lfozsuoi.fsf@thb.lt> (Thibault Polge's message of "Tue, 18 Feb 2020 17:54:05 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176207 Archived-At: >>>>> On Tue, 18 Feb 2020 17:54:05 +0100, Thibault Polge = said: Thibault> Thanks for the quick response! >> Perhaps we should signal an error for this case and have diff-hl deal >> with the fallout? Thibault> IMHO the issue is at least partially with emacs, not diff-hl = (I just Thibault> didn't have time to dig further), so signaling seems more rea= sonable Thibault> than postponing the crash. I took another look, signaling is not necessary, we can just make define-fringe-bitmap set the width to 1 or some other reasonable value if zero is passed in. I=CA=BCd offer a patch, but I=CA=BCm going to be busy= for the next week or so, so I can get to this afterwards. Thibault> (Also I should have specified that this may be a regression: = I cannot Thibault> reproduce in 26.3.) I haven't tried it in emacs-27, but it probably crashes the same way there. Robert