From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: "John Wiegley" Newsgroups: gmane.emacs.bugs Subject: bug#39724: 26.3; Commit 44298ea6aa006ed227e539b02279bd3fc11fd2a6 breaks font display on macOS Date: Fri, 21 Feb 2020 13:45:08 -0800 Message-ID: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="38754"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (darwin) Cc: Alan Third To: 39724@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 21 22:46:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j5G7g-000A0h-5X for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Feb 2020 22:46:12 +0100 Original-Received: from localhost ([::1]:36556 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j5G7e-0004UA-UZ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Feb 2020 16:46:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36380) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j5G7X-0004U2-Ik for bug-gnu-emacs@gnu.org; Fri, 21 Feb 2020 16:46:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j5G7W-0000bM-Es for bug-gnu-emacs@gnu.org; Fri, 21 Feb 2020 16:46:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42306) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j5G7W-0000bG-BY for bug-gnu-emacs@gnu.org; Fri, 21 Feb 2020 16:46:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j5G7W-0006PE-AV for bug-gnu-emacs@gnu.org; Fri, 21 Feb 2020 16:46:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "John Wiegley" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Feb 2020 21:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 39724 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.158232151924567 (code B ref -1); Fri, 21 Feb 2020 21:46:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 21 Feb 2020 21:45:19 +0000 Original-Received: from localhost ([127.0.0.1]:48279 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j5G6o-0006OB-Ty for submit@debbugs.gnu.org; Fri, 21 Feb 2020 16:45:19 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:37229) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j5G6n-0006O3-94 for submit@debbugs.gnu.org; Fri, 21 Feb 2020 16:45:17 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36323) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j5G6l-0004LB-R0 for bug-gnu-emacs@gnu.org; Fri, 21 Feb 2020 16:45:17 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42242) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j5G6l-0008RK-8Y; Fri, 21 Feb 2020 16:45:15 -0500 Original-Received: from auth2-smtp.messagingengine.com ([66.111.4.228]:33477) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1j5G6k-0004Ae-EL; Fri, 21 Feb 2020 16:45:14 -0500 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailauth.nyi.internal (Postfix) with ESMTP id A61D520CBC; Fri, 21 Feb 2020 16:45:12 -0500 (EST) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 21 Feb 2020 16:45:12 -0500 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrkeeggdduhedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgfgggtsehttdertddtredtnecuhfhrohhmpedflfhohhhnucgh ihgvghhlvgihfdcuoehjohhhnhifsehgnhhurdhorhhgqeenucffohhmrghinhepnhgvfi grrhhtihhsrghnshdrtghomhenucfkphepjeeirddvfeegrdeiledrudegleenucevlhhu shhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehjohhhnhifodhmvg hsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdeikeejkedtleeggedqudejjeehfeek udeiqdhjohhhnhifpeepghhnuhdrohhrghesnhgvfigrrhhtihhsrghnshdrtghomh X-ME-Proxy: Original-Received: from localhost (76-234-69-149.lightspeed.frokca.sbcglobal.net [76.234.69.149]) by mail.messagingengine.com (Postfix) with ESMTPA id 123123060F09; Fri, 21 Feb 2020 16:45:11 -0500 (EST) Mail-Followup-To: bug-gnu-emacs@gnu.org, Alan Third , Eli Zaretskii X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176385 Archived-At: I noticed recently that no text was displaying in my Emacs 27 windows. As if everything were black and black, except that changing the font and background colors did not help. It took two days of rebuilding, but I've isolated this as the breaking commit: commit 44298ea6aa006ed227e539b02279bd3fc11fd2a6 Author: Alan Third Date: Sat Feb 1 21:17:29 2020 +0000 Use CGImage instead of NSBitmapImageRep (bug#32932) * src/nsterm.m (ns_update_end): (ns_clear_frame): Remove forced draws. (ns_draw_fringe_bitmap): (ns_dumpglyphs_image): No longer need to invert images as the context is already flipped. ([EmacsView updateFrameSize:]): ([EmacsView initFrameFromEmacs:]): Use new function. ([EmacsView createDrawingBuffer]): Replaces createDrawingBufferWithRect:. ([EmacsView focusOnDrawingBuffer]): Set CGImage context. ([EmacsView windowDidChangeBackingProperties:]): Use new function. ([EmacsView copyRect:to:]): Copy using CGImages. ([EmacsView wantsUpdateLayer]): ([EmacsView updateLayer]): New Functions. ([EmacsView drawRect:]): We no longer do anything special here for Cocoa. ([EmacsView windowDidChangeBackingProperties:]): Fix indentation and add NSTRACE. Anything prior to this works as expected. From this commit forward, all windows are black on black. -- John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2