From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Newsgroups: gmane.emacs.bugs Subject: bug#65516: 30.0.50; Edebug behavior of signaling errors in &or Date: Wed, 30 Aug 2023 07:11:28 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20786"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Michael Heerdegen , 65516@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 30 07:12:12 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qbDUx-00053y-FC for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Aug 2023 07:12:11 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qbDUo-0004mf-Sw; Wed, 30 Aug 2023 01:12:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbDUj-0004mV-4i for bug-gnu-emacs@gnu.org; Wed, 30 Aug 2023 01:11:57 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qbDUh-0006zM-DD for bug-gnu-emacs@gnu.org; Wed, 30 Aug 2023 01:11:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qbDUo-0003jN-EA for bug-gnu-emacs@gnu.org; Wed, 30 Aug 2023 01:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Aug 2023 05:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65516 X-GNU-PR-Package: emacs Original-Received: via spool by 65516-submit@debbugs.gnu.org id=B65516.169337230814184 (code B ref 65516); Wed, 30 Aug 2023 05:12:02 +0000 Original-Received: (at 65516) by debbugs.gnu.org; 30 Aug 2023 05:11:48 +0000 Original-Received: from localhost ([127.0.0.1]:51914 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbDUa-0003gi-Au for submit@debbugs.gnu.org; Wed, 30 Aug 2023 01:11:48 -0400 Original-Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]:56445) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbDUX-0003gS-0H for 65516@debbugs.gnu.org; Wed, 30 Aug 2023 01:11:47 -0400 Original-Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-500a8b2b73eso7550452e87.0 for <65516@debbugs.gnu.org>; Tue, 29 Aug 2023 22:11:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693372291; x=1693977091; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=KUWRNyJRARf6MADO+ve2Qh2Rlcnl2+PM1tmL340ktFQ=; b=PQOUfOOVptp+Sn1yj0P8AZ7EmGpqIK/jqz7nUKwyk+NLQBjKiCTNXTobX7hCHWWh4/ pgpzrNZzTa9rC3GXbAFp+sqwuX2m7Yl9hgaiIKnDqksAMm8H1owKUBCekZGacYfaRK6d XjMZdDUq9C26fkLEKUwF2Woa8cUo7B2eFrUiPecIxl0Usqz/Ft585yPkGRrBW9winnV5 Kd8YQTmsh28MIWNoHxDNyghOlccM+x4exbxBYq2zAeYP7c4k418waxSYy7H48NthM2on puBdZUGMF9bIe8zXyL8XrDCMqDkC0gw8TFt0ECZ8QKvoN2Bhfc0IBLeuLJiv0WJMI7vy gqZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693372291; x=1693977091; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KUWRNyJRARf6MADO+ve2Qh2Rlcnl2+PM1tmL340ktFQ=; b=JWaNF0mI8na2DywHVDfDLwnS3RZWLx9lYprcGF8pC0yLDbWJ6/d1tAaswZiKi8HOiw 99WRa0C3Bv07PVntrAtIsrqaeay6fmO5IaZrSUR/HeuqQ7HOEAweMg1263IDxAnE3VtO kcgQxWohhXt+G8yWKuqxjkPCPPWbrIWsPSQN7XYVroBziJ7H1dK/jwdDA1osrJrT8DNZ vhV9KzXqY1vgCH0Z8nHfNQWdMW8XFV5eQaU2sptjzIF74Odr3euJETAgfYqddt/AFDMJ 5KwukOisd5HWvPFpFFBlUmRV7Ah5setyMtbAehgjmhgKs8LEKx9qdXMbCVOQBuVFhIt7 rikw== X-Gm-Message-State: AOJu0YxiIYLgbhPWWp2OeO0sjKKzj2CuUSpJLA8lfheF21xl7ccidCL0 Li+DFnPavaoTUY94z7VwN+o= X-Google-Smtp-Source: AGHT+IFZGQmUnwXOMU7/CqZ/nZsIg3ZBNImMN35bQUM82AGqQBNp1cNPEryqBt+TwDS1t1P5mvfh0g== X-Received: by 2002:a05:6512:31c7:b0:500:98ff:4162 with SMTP id j7-20020a05651231c700b0050098ff4162mr720227lfe.40.1693372290757; Tue, 29 Aug 2023 22:11:30 -0700 (PDT) Original-Received: from Mini.fritz.box (p4fe3acd3.dip0.t-ipconnect.de. [79.227.172.211]) by smtp.gmail.com with ESMTPSA id x11-20020aa7d6cb000000b0052284228e3bsm6369623edr.8.2023.08.29.22.11.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Aug 2023 22:11:30 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Tue, 29 Aug 2023 11:35:22 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268688 Archived-At: Stefan Monnier writes: >> To summarize: The "culprit" is this commit: > > Have you confirmed experimentally that this is the culprit for your > use case? No, I didn't experiment. I found the circumstancial evidence sufficient for me. Of course, there might be additional stuff and so on, as usual. > Do you have a recipe? Checkout cc0f546825e whidh should have an cl-flet where the first clause of the &or has a def-form in it. Then run cl-macs-tests and/or edebug-tests. IIRC, Stefan Kangas noticed that, which led to the current bug. >> + (prog1 (edebug-make-form-wrapper >> + cursor >> + (edebug-before-offset cursor) >> + ;; Find the last offset in the list. >> + (let ((offsets (edebug-cursor-offsets cursor))) >> + (while (consp offsets) (setq offsets (cdr offsets))) >> + offsets) >> + specs) >> + ;; Stop backtracking here (Bug#41988). >> + (setq edebug-gate t))) > [...] >> Do you think it would be possible to let e-m-f-wrapper just put >> something on a new "list of actions to be performed oncee the whole >> debug spec has been matched"? I'm thinking of closures as "actions", >> here. > > Maybe, but at the same time, when I read `edebug-make-form-wrapper` > I get the impression that it matches `specs` quite early on, before it > does much damage to the global state, so I think I'd need to step > through the code to better understand what was the problem that the > patch intended to fix. Ok, thanks. I'm thinking of how to proceed from here. IMO, there's at this point enough info now that someone (tm) could fix this, but the cost/benefit ration is sp high that I at least can't bring me to to do it. I can only offer to put it on my todo list, which is, TBH, rather a to-procrastinate list. Any other takers? If not, I'd say let's close this or what else seems appropriate to the maintainers.