From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alex Bochannek Newsgroups: gmane.emacs.bugs Subject: bug#73827: [ELPA] [PATCH] register-list fails on "Unprintable entity" registers Date: Mon, 25 Nov 2024 15:02:43 -0800 Message-ID: References: <87ldynk8un.fsf@jeremybryant.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15365"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 73827@debbugs.gnu.org To: Jeremy Bryant Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 26 00:03:23 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tFi71-0003rE-8e for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 26 Nov 2024 00:03:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tFi6j-0008I9-EV; Mon, 25 Nov 2024 18:03:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tFi6h-0008Hy-2b for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2024 18:03:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tFi6g-0007CX-OT for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2024 18:03:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=M4cs5aWEg60LAEb8vbFS7/PRLllcw1HCPpo5NpFmi1I=; b=J5F7eMHZSSRrOzrBmoXl0f2N54EX6pHVtwKSxQmjjKFTVxOZxX37WFw5wUG2e0W3dpeXPiTGWsYoRZR/WcYxZi99K651pmiPsEnmWAcGbaq5okHn2fxUeEPRFVfj/O3YYNvcDfQ9VDBm8wvYt6/kfGJ2ANHyaLfQAI6sqwCnLxxj7Fye9ASW0DZWSBgAmRA+kBkGW+xkNsKJRP7glP1T3Kjfc8xleKJmomWx6eBU+c37tEPaLafLO6hED89p/Ay6eSOSC1QMU0u6WiQ+6eJUJSRCpl+L7CO7zy7jJlV1W0UwDRdHMfrUXZZEyPNXIQYxujwH8397FSmVizlaAjA6OA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tFi6g-00021L-IF for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2024 18:03:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alex Bochannek Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 Nov 2024 23:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73827 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73827-submit@debbugs.gnu.org id=B73827.17325757707744 (code B ref 73827); Mon, 25 Nov 2024 23:03:02 +0000 Original-Received: (at 73827) by debbugs.gnu.org; 25 Nov 2024 23:02:50 +0000 Original-Received: from localhost ([127.0.0.1]:42710 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFi6T-00020p-Qm for submit@debbugs.gnu.org; Mon, 25 Nov 2024 18:02:50 -0500 Original-Received: from ns.lapseofthought.com ([50.0.39.240]:62168 helo=mail.lapseofthought.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFi6R-00020g-AM for 73827@debbugs.gnu.org; Mon, 25 Nov 2024 18:02:48 -0500 Original-Received: from awb-mbp-m3.local (unknown [IPv6:2601:646:4200:73a0:addd:a64e:a406:ac0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lapseofthought.com (Postfix) with ESMTPSA id 4Xy1Sh3wGzz3pjJN; Mon, 25 Nov 2024 15:02:44 -0800 (PST) Authentication-Results: ORIGINATING; auth=pass smtp.auth=alex smtp.mailfrom=alex@bochannek.com In-Reply-To: (Alex Bochannek's message of "Wed, 16 Oct 2024 19:43:47 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295964 Archived-At: Anything else that's needed from me here? I have another trivial fix for register-list I would like to submit. Thanks! Alex Bochannek writes: > Jeremy Bryant writes: > >> Alex Bochannek writes: >> >>> Hello! >>> >>> I have not submitted patches against an ELPA package before, so I hope >> >> Philip, any comments? >> >>> >>> Apologies again for the format of this submission. If someone could >>> point me at instructions for how to make your life easier next time, I'd >>> appreciate it. >> >> Please read the file CONTRIBUTE in the Emacs source tree. > > Figured out my issue with populating the ELPA repo (new computer, old > version of gmake) and I am including the patch in the proper format now. > > From dafcff7c7a9cb6952aa740ef34a67eb61fd2a90d Mon Sep 17 00:00:00 2001 > From: Alex Bochannek > Date: Wed, 16 Oct 2024 19:35:33 -0700 > Subject: [PATCH] Fix unprintable register display logic > > --- > register-list.el | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/register-list.el b/register-list.el > index 846d3efe49..5a81b1b7bb 100644 > --- a/register-list.el > +++ b/register-list.el > @@ -478,8 +478,8 @@ the register or copy its value into the kill ring." > (t "error")) > (cond ((window-configuration-p (car key)) "W") > ((frame-configuration-p (car key)) "F") > - ((stringp (car key)) "R") > ((string= "Unprintable entity" (car key)) "?") > + ((stringp (car key)) "R") > (t "error")))) > > ;;; Edit key/value of the register > -- > 2.39.5 (Apple Git-154) -- Alex.